All of lore.kernel.org
 help / color / mirror / Atom feed
From: Harish Patil <harish.patil@qlogic.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Dept-Eng DPDK Dev <Dept-EngDPDKDev@qlogic.com>
Subject: Re: [PATCH 2/7] net/qede: refactor filtering code
Date: Tue, 20 Dec 2016 23:12:12 +0000	[thread overview]
Message-ID: <D47EF55F.C24A6%Harish.Patil@cavium.com> (raw)
In-Reply-To: <466b1cf9-78b0-4449-68a0-f5a0e20dbb5a@intel.com>

>
>On 12/12/2016 5:36 PM, Harish Patil wrote:
>> 
>>> On 12/3/2016 2:43 AM, Harish Patil wrote:
>>>> The filter_config in qed_eth_ops_pass is a wrapper call driving all
>>>>the
>>>> filtering configuration. This requires defining multiple structures
>>>>and
>>>> passing different function arguments for each filter type which is
>>>> unnecessary. So as part of this refactoring we remove filter_config
>>>>from
>>>> qed_eth_ops_pass and invoke base apis directly. Another change is to
>>>> use a singly list for unicast/multicast macs and thereby prevent
>>>> duplicate
>>>
>>> singly linked list?
>> 
>> Yes. Two lists to track unicast and multicast mac entries:
>> +       SLIST_HEAD(mc_list_head, qede_mcast_entry) mc_list_head;
>> 
>> +       SLIST_HEAD(uc_list_head, qede_ucast_entry) uc_list_head;
>> 
>> 
>> 
>>>
>>>> entries.
>>>>
>>>> This change is primarily intended to support future tunneling support
>>>> which makes use of existing L2 filtering/classifications.
>>>>
>>>> Fixes: 2ea6f76a ("qede: add core driver")
>>>
>>> What is fixed in this patch, isn't it a refactor?
>> 
>> The fix part is to make use of the newly added lists and prevent
>>duplicate
>> mac filters.
>> Before that there were no checks. Other than that its refactoring to
>> mainly invoke direct base APIs.
>
>So this is not fixing any defect in driver, so I believe Fixes tag can
>be removed. This tag is mainly useful to pick commits for stable trees.

It also fixes the driver. Apart from preventing duplicate filter
programming, the existing qede_mac_addr_add() did not differentiate
between multicast and unicast mac entries. So the multicast mac addition
would wrongly go to unicast table.
So we would need Fixes tag and would need to be picked up for stable trees.

>
>> 
>>>
>>> btw, all Fixes formats are wrong in the patchset, can you please use
>>>the
>>> git alias provided:
>>> 
>>>http://dpdk.org/doc/guides/contributing/patches.html#commit-messages-bod
>>>y

OK sure.

>>>
>>>>
>>>> Signed-off-by: Harish Patil <harish.patil@qlogic.com>
>>>> ---
>>> <...>
>>>
>> 
>> 
>
>



  reply	other threads:[~2016-12-20 23:12 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-03  2:43 [PATCH 1/7] net/qede: reduce noise in debug logs Harish Patil
2016-12-03  2:43 ` [PATCH 2/7] net/qede: refactor filtering code Harish Patil
2016-12-08 16:45   ` Ferruh Yigit
2016-12-12 17:36     ` Harish Patil
2016-12-12 17:53       ` Ferruh Yigit
2016-12-20 23:12         ` Harish Patil [this message]
2016-12-03  2:43 ` [PATCH 3/7] net/qede: add slowpath support for VXLAN tunneling Harish Patil
2016-12-03  2:43 ` [PATCH 4/7] net/qede: add fastpath " Harish Patil
2016-12-03  2:43 ` [PATCH 5/7] net/qede: fix RSS related issue Harish Patil
2016-12-03  2:43 ` [PATCH 6/7] net/qede: fix maximum VF count to 0 Harish Patil
2016-12-08 16:45   ` Ferruh Yigit
2016-12-12 17:47     ` Harish Patil
2016-12-12 18:13       ` Ferruh Yigit
2016-12-19 13:38         ` Thomas Monjalon
2016-12-20 23:15           ` Harish Patil
2016-12-03  2:43 ` [PATCH 7/7] net/qede: restrict maximum queues for PF/VF Harish Patil
2016-12-08 16:45   ` Ferruh Yigit
2016-12-12 19:29     ` Harish Patil
2016-12-12 20:10       ` Ferruh Yigit
2016-12-20 23:16         ` Harish Patil
2016-12-08 16:44 ` [PATCH 1/7] net/qede: reduce noise in debug logs Ferruh Yigit
2016-12-12 17:15   ` Harish Patil
2016-12-12 17:50     ` Ferruh Yigit
2016-12-20 22:02       ` Harish Patil
2016-12-23  0:48   ` [PATCH v2 " Harish Patil
2016-12-23 15:14     ` Ferruh Yigit
2016-12-23 15:25     ` Ferruh Yigit
2016-12-23  0:48   ` [PATCH v2 2/7] net/qede: fix filtering code Harish Patil
2016-12-23  0:48   ` [PATCH v2 3/7] net/qede: add slowpath support for VXLAN tunneling Harish Patil
2016-12-23  0:48   ` [PATCH v2 4/7] net/qede: add fastpath " Harish Patil
2016-12-23  0:48   ` [PATCH v2 5/7] net/qede: fix RSS related issue Harish Patil
2016-12-23  0:48   ` [PATCH v2 6/7] net/qede: fix reporting of SR-IOV PF driver as disabled Harish Patil
2016-12-23  0:48   ` [PATCH v2 7/7] net/qede: restrict maximum queues for PF/VF Harish Patil
2016-12-08 16:48 ` [PATCH 1/7] net/qede: reduce noise in debug logs Ferruh Yigit
2016-12-20 23:29   ` Mody, Rasesh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D47EF55F.C24A6%Harish.Patil@cavium.com \
    --to=harish.patil@qlogic.com \
    --cc=Dept-EngDPDKDev@qlogic.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.