All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Burton <Paul.Burton@imgtec.com>
To: Greg Ungerer <gerg@linux-m68k.org>, Ralf Baechle <ralf@linux-mips.org>
Cc: "linux-mips@linux-mips.org" <linux-mips@linux-mips.org>
Subject: RE: [PATCH 06/11] MIPS: cmpxchg: Implement __cmpxchg() as a function
Date: Thu, 5 Oct 2017 07:07:38 +0000	[thread overview]
Message-ID: <D4E56584A8AFC94F836003742821EF82705B9658@badag02.ba.imgtec.org> (raw)
In-Reply-To: <49fe6972-163d-3459-6963-582ffcc35b19@linux-m68k.org>

Hi Greg,

> On Fri, 9 Jun 2017 17:26:38 -0700, Paul Burton wrote:
> > Replace the macro definition of __cmpxchg() with an inline function,
> > which is easier to read & modify. The cmpxchg() & cmpxchg_local()
> > macros are adjusted to call the new __cmpxchg() function.
> >
> > Signed-off-by: Paul Burton <paul.burton@xxxxxxxxxx>
> > Cc: Ralf Baechle <ralf@xxxxxxxxxxxxxx>
> > Cc: linux-mips@xxxxxxxxxxxxxx
> 
> I think this patch is breaking user space for me. I say "think"
> because it is a bit tricky to bisect for the few patches previous to this one
> since they won't compile cleanly for me (due to this
> https://www.spinics.net/lists/mips/msg68727.html).
> 
> I have a Cavium Octeon 5010 MIPS64 CPU on a custom board, have been
> running it for years running various kernel versions. Linux-4.13 breaks for me,
> and I bisected back to this change.
> 
> What I see is user space bomb strait after boot with console messages like
> this:
> 
> mount[37] killed because of sig - 11
> 
> STACK DUMP:
> <snip>
> 
> I get a lot of them from various programs running from rc scripts.
> It never manages to fully boot to login/shell.
> 
> If I take the linux-4.12 arch/mips/include/asm/cmpxchg.h and drop that in
> place on a linux-4.13 (or even linux-4.14-rc3) I can compile and run everything
> successfully.
> 
> Any thoughts?

Are you running a uniprocessor/non-SMP kernel? Could you try this fix I submitted this fix 5 weeks ago:

https://patchwork.linux-mips.org/patch/17226/

Ralf: Could we get that merged please?

(Apologies if this email is formatted oddly.)

Thanks,
    Paul

  reply	other threads:[~2017-10-05  7:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-05  6:29 [PATCH 06/11] MIPS: cmpxchg: Implement __cmpxchg() as a function Greg Ungerer
2017-10-05  7:07 ` Paul Burton [this message]
2017-10-05 23:27   ` Greg Ungerer
  -- strict thread matches above, loose matches on Subject: below --
2017-06-10  0:26 [PATCH 00/11] MIPS: cmpxchg(), xchg() fixes & queued locks Paul Burton
2017-06-10  0:26 ` [PATCH 06/11] MIPS: cmpxchg: Implement __cmpxchg() as a function Paul Burton
2017-06-10  0:26   ` Paul Burton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D4E56584A8AFC94F836003742821EF82705B9658@badag02.ba.imgtec.org \
    --to=paul.burton@imgtec.com \
    --cc=gerg@linux-m68k.org \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.