From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752052AbbJWDHs (ORCPT ); Thu, 22 Oct 2015 23:07:48 -0400 Received: from mail-by2on0061.outbound.protection.outlook.com ([207.46.100.61]:30510 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751237AbbJWDHo convert rfc822-to-8bit (ORCPT ); Thu, 22 Oct 2015 23:07:44 -0400 Authentication-Results: spf=none (sender IP is 165.204.84.221) smtp.mailfrom=amd.com; alien8.de; dkim=none (message not signed) header.d=none;alien8.de; dmarc=permerror action=none header.from=amd.com; X-WSS-ID: 0NWNKOQ-07-AFZ-02 X-M-MSG: From: "Singh, Brijeshkumar" To: Stepan Moskovchenko CC: "robh+dt@kernel.org" , "pawel.moll@arm.com" , "mark.rutland@arm.com" , "ijc+devicetree@hellion.org.uk" , "galak@codeaurora.org" , "dougthompson@xmission.com" , "bp@alien8.de" , "mchehab@osg.samsung.com" , "devicetree@vger.kernel.org" , "guohanjun@huawei.com" , "andre.przywara@arm.com" , "arnd@arndb.de" , "linux-kernel@vger.kernel.org" , "linux-edac@vger.kernel.org" Subject: RE: [PATCH v2] EDAC: Add ARM64 EDAC Thread-Topic: [PATCH v2] EDAC: Add ARM64 EDAC Thread-Index: AQHRDTVMvkJqAY92o0mmxIoJlQ29EJ54XyRj Date: Fri, 23 Oct 2015 03:07:35 +0000 Message-ID: References: <56299292.5040408@codeaurora.org> In-Reply-To: <56299292.5040408@codeaurora.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.177.96.14] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.221;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(428002)(377454003)(189002)(52604005)(199003)(101416001)(50986999)(102836002)(110136002)(15975445007)(105586002)(86362001)(53416004)(23726002)(5004730100002)(76176999)(5001920100001)(55846006)(11100500001)(106116001)(97736004)(97756001)(50466002)(5250100002)(106466001)(19580405001)(92566002)(46406003)(5008740100001)(33656002)(189998001)(2920100001)(2950100001)(19580395003)(87936001)(5007970100001)(47776003)(5003600100002)(54356999)(2900100001);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR12MB0718;H:atltwp01.amd.com;FPR:;SPF:None;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0718;2:lwapV4CvgqSQ7PG+cmYnWuw9pDbLQBrGbE0pvj3E+Tdub0B3sNRzH/GgIfBNlcAeRpw734uBj+eHaBNRvpmEp+yo0uClpfF+EHBEIfvupd4Pmbg1W1QJ/YTu6gMWkrMG/isQcROwewuwHvXNfZ0Qlc2rez1CHR3/QLy1yJrj6ks=;3:IWTmyojvq+GljcKk7rVi/PNF2WMNe5KAiY+VTESaCNzxGkwXyDzPqTjXTy1nkyuvbKhvxK/vawCn0zuGTnEOEXKmKiKWOe8dAsP6wOkBbe50fracxN03G3Vyj51ZiJWs51EBFBwFeS52/zmOBkJRuwaxnvQwiGJj4LeAjs2fB+ikaXhPhw/vovSJx7otWaCimB6IPE+4P3VeOCRQlquXp2a4CzmTnLpMOnSJ+izaOhJDlRdyZCWKYPfRqiN9xCdH;25:jd3csnVcNLn+kD23cTG7k5QYZ6fWD/ikuODQ2yz16dLbCFgd/BMFD+CzWP2GtWnLln9kFxLP28u6cNBfjIrBYnEkXlaBclVL5BxBA63BoFX6h2EdpkHyQ/hMPm3HMRZBiv+ALKbmbiIYOJNQT/ATWvLMlsmyWlGSELQ8yYpoGHyc9WMGLylAlsZtSxFOcZgqqvjJPNvlm1yDy+RDap7f9DTeXBUQyWq3Tg19pUdoE1ceFNxTCNJy9a81SNAS9Yv19atQ/jYZkYSYbrs0PTyLUA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN1PR12MB0718; X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0718;20:HpCaA6iJ0SoqOHFbM6HZUoNt3kYxUNZaYDJ7GJT/J2UB14Gm+t3sfYdqApF19TwJ/spX+ham7CqFOsiECtcSR70o3QVFb6RrtjtZ29ShL9NKz484ooUM1W4k+9mybMIjQbAYDyeG3Rk99gzj0jgueTfj9ZHmbxV3Gac6VntT2avrTbfpiupa7SCflrOCyO+XAIgE44QE9IeBCjDXtbN48V1yOR+buIX1/UzMAFagh42By8l4Ub1K60PunqU1KLEKuFtRGmutgsY/N9fc0HphJ88StnXLZa0OLl4w66zNL2N6rY9iEokfPVnC6T7T2O7/gYKg4G8xqxEmq5il+zGnvlYqbTXbQfXaqD0AWUGvH2qKgQj+Np/W0b29UfWWa331E8tCsorvGQhS6WbSV8xsUOLvow1aYwl8Mb44e+i5fJu4aWDwxReNJwmKs+U6NTg/S1RxojDWP1Jtx4onkJDbKqv//Pivk4UZv1DnzyrWniB7X48WE+neKASb2hrbKFtR;4:ex3d0bmV4FWmc4GaUBtUVdwT0qb1OE77iTYqoog1/AvkH/0zr6DlmSQienp+Mhh+ah7bVBpSS9KurG6RIjopHK/MQuuf92zFZWRRfPJfWdvNpWCMuBj4XqrYp1HaSYX9vCF2FaxURCyv2mWRj3bJUvV63pAwWQ7bygMzEXcnXotVMS9odv8gkg0pzV+xLMNlXyBMATZ+zTRaE5mWid9NWexlW/CUqku2tNH1PgEJ3/V0hyrJvm+wknbrfdvsqq2c8ZmVihIhHojoy3pRCdPKs06TmrDvgP0kKa/3II8VlHrYEb6r9jN8R71t2XA4haU8L498g/Oi3TYf2NjVzi7bmg1XaonwlkcJvkUSLufgSBnnJgZB+JkvnQRoZmE8v6q4 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(520078)(3002001)(102215026);SRVR:SN1PR12MB0718;BCL:0;PCL:0;RULEID:;SRVR:SN1PR12MB0718; X-Forefront-PRVS: 0738AF4208 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;SN1PR12MB0718;23:k3cmoD/sNyABuqI5FzMdlMNpDSGqwH8/MLo4LBToR?= =?us-ascii?Q?ywMDy37bSUyc4CarjqFVi3IXlDo7iuurRr2mk2tS4J7aFhk+VIQv07fmRCh6?= =?us-ascii?Q?XEPHZIc82fA2obNhxeR9JglKCugopUIIFNk4HgLQZiTsCu24Xz355F5g65PA?= =?us-ascii?Q?YUtr98i0Iuy6Pc8nyJZDJqWgniNC0IB8RQdICHKJIjKn4XTwdZuRCr89IPhq?= =?us-ascii?Q?MjJImZzKNGyrvwERB6sucUCdrHvYgQQZF+fL+VgdrZdv0CZefaCmgw/HHNFk?= =?us-ascii?Q?DaTpou7NMROIENWEG+7MRlzJVXMR8UgVhpm0YMoZrgE6M1e42/BuVdPPutSg?= =?us-ascii?Q?aaDhMtoKma6gYYcYW3A8X1D4GnqCQS3QwP0XNg3xg5MpRzo/N7ZTmuMjEhB1?= =?us-ascii?Q?0wxz4FFomRsDBeIRLdYfsxi/MuTGUzCWQe95WqEK703jLAqX2maRZO8qu+eA?= =?us-ascii?Q?YF/4vmytNyr7T5S8gDOj8BrxNgqDjAEfmntpJg+oo2wUCCrHLqDEY7MdCl3t?= =?us-ascii?Q?tWoo0TswgHmX2S5pVT2OMsXv3NZ84C51fJkY7Go1LrIsLzMwe6nE4YOv2DMW?= =?us-ascii?Q?bwzpiVCn1W0nBmzU/WXDqKLw4WGv4KocvbLEvjv05XQNV+eN6PPdgBgEosup?= =?us-ascii?Q?toGcRjuvHOCvfvuPaV50b+JROovZEpW7rwSHDgSw8GPEbj0ftB2CPdwFrVm7?= =?us-ascii?Q?033ytJoEN1Yb0eOid7phnRRiNJbnww3eEIffkNOG0HoI9CUHRowLlUOW094q?= =?us-ascii?Q?cFeZ0SGvvPGJkh7BYXPzDKwk1bgGeqC1c4VGYSshK6J0bak+NL6VitfJMcZ5?= =?us-ascii?Q?n+HIHbMkUGeoVGbGkczXYSq0YUEhuVK5N2XCUCLBmCxcUNHRO8axjhOAt5wI?= =?us-ascii?Q?JLCBcruJytbRxKHj68tVmtOtn72oRcfSRBx3ihgK7wWf0eOGJdW5QQ+X7lEv?= =?us-ascii?Q?nNdPnxM2/O5940DVXJCyjk8HSB5c5fMUCnB9KhgwzsEkT5Uo9gefi+if/RAG?= =?us-ascii?Q?LnF3CSPdB3VOi+cq/u38LRG2RE9Cxu7tQNsvyhs9DYMG+hqgHpb9eLELcSgC?= =?us-ascii?Q?3wlXUCvxBlcFhThiyfHDAgUL6AY4h3UQ9yRQ7GSTfNCtgl65Ff8S99r4LMUR?= =?us-ascii?Q?+NohpT2jPhkfbAabKqaQCZfJrf70FPYIbYL4EA3lQiq6tQR5iUaFw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0718;5:9eEZl8+m7Wfl6c5g/Hb/zMLdUXjHcnRSF9mBpWJg6y/hFY3orojtAWAskaUms5vgD2VzUjRqBs8XeizS+Fs0t5Bl/R67qmRJ5gEcrxsEUbJoh6QB2vxSiXZZ555Y43IVGWml82N/68MO/HzTlzZrmg==;24:aFGGMxIW5TY8HzjQlDxrw85+wx6H7idK4ph6H9KpIn08Q+bUpA4YJWR9vcmbTYSvbk0urZ6rRjG28RG9obORl7s68QzNY/Ee4WkxmMPNMSo=;20:bJkvV/etBKtV0kEiLem6CjN/NcZJhXf4gh5DO8vROkmoCU5BxxcldPbb/PgWAYNqiUHvy/JmHf7Tl3fbbQqFiSt2ahqgFpDv2AtwGAGRy28+Anx9Ewgxhj0Gr1I10R0Rkg6IwjmCR6cpD9fNrmMlOP7hc/f1xcMEq57E/UtlGeTAKyEzEnGuLWL3P1vvRRcwt7YUswaBPt2VIYDzHHw8/QJN8W00GLE5M9rou4CUj7XoECx8tvAnQPNtif9Xu5mu SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2015 03:07:39.9709 (UTC) X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.221];Helo=[atltwp01.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB0718 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Steve, Thanks for pointing the link, I have not seen that driver before; I was mainly looking at driver/edac/xgene_edac.c and some other arm edac drivers. My first attempt was to do AMD specific edac driver to log correctable L1/L2 error but based on feedback I worked on v2 generic driver which now looks very similar to your driver, are you planning to upstream your driver ? I can work with you to verify it on my current hardware setup. It seems your driver also handles single-bit and double-bit error which I have no way to test in my current hardware setup. On Seattle platform most of error handling is done through firmware APEI except correctable L1/L2. Let me know your thoughts. -Brijesh ________________________________________ From: Stepan Moskovchenko [stepanm@codeaurora.org] Sent: Thursday, October 22, 2015 8:51 PM To: Singh, Brijeshkumar Cc: robh+dt@kernel.org; pawel.moll@arm.com; mark.rutland@arm.com; ijc+devicetree@hellion.org.uk; galak@codeaurora.org; dougthompson@xmission.com; bp@alien8.de; mchehab@osg.samsung.com; devicetree@vger.kernel.org; guohanjun@huawei.com; andre.przywara@arm.com; arnd@arndb.de; linux-kernel@vger.kernel.org; linux-edac@vger.kernel.org Subject: Re: [PATCH v2] EDAC: Add ARM64 EDAC >>> +++ b/drivers/edac/cortex_arm64_edac.c >>> @@ -0,0 +1,457 @@ >>> +/* >>> + * Cortex ARM64 EDAC >>> + * >>> + * Copyright (c) 2015, Advanced Micro Devices >>> + * Author: Brijesh Singh >>> + * >Hi Brijesh, >Your ARM64 EDAC driver seems rather similar to the existing driver that >is linked below. If you have indeed based your driver on this one, can >you please provide the appropriate attribution? >https://www.codeaurora.org/cgit/quic/la/kernel/msm-3.14/tree/drivers/edac/cortex_arm64_edac.c?h=LA.HB.1.1.1_rb1.10