From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chen Baozi <baozich@gmail.com>
Subject: Re: [PATCH v3 5/5] xen/arm: Add OMAP5 architected timer
	initialization codes.
Date: Thu, 8 Aug 2013 16:58:19 +0800
Message-ID: <D580E02D-1AB5-4D34-81AE-4F56C7E1DA2B@gmail.com>
References: <1375885131-32743-1-git-send-email-baozich@gmail.com>
	<1375885131-32743-6-git-send-email-baozich@gmail.com>
	<CAGQvs6gXjpveRGUznPAeG9oWNOsgbck5XpzHh3xAVXHQ_2FCQQ@mail.gmail.com>
Mime-Version: 1.0 (Mac OS X Mail 6.5 \(1508\))
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CAGQvs6gXjpveRGUznPAeG9oWNOsgbck5XpzHh3xAVXHQ_2FCQQ@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrii Anisov <andrii.anisov@globallogic.com>
Cc: Julien Grall <julien.grall@linaro.org>, Ian Campbell <Ian.Campbell@citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org


On Aug 8, 2013, at 4:31 PM, Andrii Anisov <andrii.anisov@globallogic.com> wrote:

> diff --git a/xen/arch/arm/time.c b/xen/arch/arm/time.c
> index 4ed7882..104aefc 100644
> --- a/xen/arch/arm/time.c
> +++ b/xen/arch/arm/time.c
> @@ -104,6 +104,7 @@ int __init init_xen_time(void)
>      struct dt_device_node *dev;
>      int res;
>      unsigned int i;
> +    u32 rate;
> 
>      dev = dt_find_compatible_node(NULL, NULL, "arm,armv7-timer");
>      if ( !dev )
> @@ -134,7 +135,11 @@ int __init init_xen_time(void)
>      if ( !cpu_has_gentimer )
>          panic("CPU does not support the Generic Timer v1 interface.\n");
> 
> -    cpu_khz = READ_SYSREG32(CNTFRQ_EL0) / 1000;
> +    res = dt_property_read_u32(dev, "clock-frequency", &rate);
> +    if ( res )
> +       cpu_khz = rate / 1000;
> +    else
> +        cpu_khz = READ_SYSREG32(CNTFRQ_EL0) / 1000;
> 
>      boot_count = READ_SYSREG64(CNTPCT_EL0);
>      printk("Using generic timer at %lu KHz\n", cpu_khz);
> 
> I would suggest to extract this into a separate patch. This chunk is a generic improvement to add support of dt specified clock freq, while all the rest is a platform specific.

I'm OK with it. What's your opinion, Julien?

Cheers,

Baozi