From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:42326) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R1QEG-0004n6-C0 for qemu-devel@nongnu.org; Wed, 07 Sep 2011 18:04:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R1QEF-0002LN-7Z for qemu-devel@nongnu.org; Wed, 07 Sep 2011 18:04:20 -0400 Received: from cantor2.suse.de ([195.135.220.15]:56978 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R1QEE-0002L9-UZ for qemu-devel@nongnu.org; Wed, 07 Sep 2011 18:04:19 -0400 Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Alexander Graf In-Reply-To: <4E67EA19.5080200@codemonkey.ws> Date: Thu, 8 Sep 2011 00:04:16 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: References: <1314984898-19141-1-git-send-email-aliguori@us.ibm.com> <19806608-2700-48EE-B1A0-492745A61D86@suse.de> <4E67EA19.5080200@codemonkey.ws> Subject: Re: [Qemu-devel] [PATCH 00/15] Convert commands to QAPI (batch 1) (v2) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Kevin Wolf , Michael Roth , Anthony Liguori , qemu-devel@nongnu.org, Luiz Capitulino On 08.09.2011, at 00:03, Anthony Liguori wrote: > On 09/07/2011 04:56 PM, Alexander Graf wrote: >>=20 >> On 02.09.2011, at 19:34, Anthony Liguori wrote: >>=20 >>> This is my attempt to jump-start the QAPI switch over. All of the = hard work >>> is already done in my qapi branch, we just need to start merging = stuff. >>>=20 >>> To simplify the merge process, I've introduced a new mode to the = code generator >>> that lets us do conversions without using the new QMP server. >>>=20 >>> Once this series is merged, anything that touchs QMP (to modify a = command or >>> add a new command) must do it through QAPI--no exceptions. >>>=20 >>> This series also includes Dans change to the 'change' command. I'm = not thrilled >>> about people using this command but its better to err on the side of = caution. >>> It's now officially deprecated with much more robust replacement = commands. >>>=20 >>> Since v1, I've tried to address all review comments. I've also = tested the >>> modified commands extensively. >>=20 >> Just stumbled over this while trying to build. Smells like missing = Makefile dependencies (works just fine with -j1), but I figured I'd give = you a heads up on this. It's a fresh checkout with nothing done but = ./configure; make -j. >>=20 >>=20 >> agraf@e77:/dev/shm/qemu> make -j >> GEN i386-softmmu/config-devices.mak >> GEN arm-softmmu/config-devices.mak >> GEN x86_64-softmmu/config-devices.mak >> GEN cris-softmmu/config-devices.mak >> GEN lm32-softmmu/config-devices.mak >> GEN m68k-softmmu/config-devices.mak >> GEN microblaze-softmmu/config-devices.mak >> GEN microblazeel-softmmu/config-devices.mak >> GEN mips-softmmu/config-devices.mak >> GEN mipsel-softmmu/config-devices.mak >> GEN mips64-softmmu/config-devices.mak >> GEN mips64el-softmmu/config-devices.mak >> GEN ppcemb-softmmu/config-devices.mak >> GEN ppc-softmmu/config-devices.mak >> GEN ppc64-softmmu/config-devices.mak >> GEN sh4-softmmu/config-devices.mak >> GEN sh4eb-softmmu/config-devices.mak >> GEN sparc-softmmu/config-devices.mak >> GEN sparc64-softmmu/config-devices.mak >> GEN i386-linux-user/config-devices.mak >> GEN s390x-softmmu/config-devices.mak >> GEN x86_64-linux-user/config-devices.mak >> GEN alpha-linux-user/config-devices.mak >> GEN arm-linux-user/config-devices.mak >> GEN armeb-linux-user/config-devices.mak >> GEN cris-linux-user/config-devices.mak >> GEN m68k-linux-user/config-devices.mak >> GEN microblaze-linux-user/config-devices.mak >> GEN microblazeel-linux-user/config-devices.mak >> GEN mips-linux-user/config-devices.mak >> GEN mipsel-linux-user/config-devices.mak >> GEN ppc-linux-user/config-devices.mak >> GEN ppc64-linux-user/config-devices.mak >> GEN sh4-linux-user/config-devices.mak >> GEN ppc64abi32-linux-user/config-devices.mak >> GEN sh4eb-linux-user/config-devices.mak >> GEN sparc64-linux-user/config-devices.mak >> GEN sparc32plus-linux-user/config-devices.mak >> GEN unicore32-linux-user/config-devices.mak >> GEN sparc-linux-user/config-devices.mak >> GEN s390x-linux-user/config-devices.mak >> GEN config-all-devices.mak >> GEN config-host.h >> GEN trace.h >> GEN qemu-options.def >> GEN qapi-generated/qga-qapi-visit.h >> GEN trace.c >> CC trace/default.o >> CC trace/control.o >> GEN qemu-img-cmds.h >> cc1: error: qapi-generated: No such file or directory >> cc1: error: qapi-generated: No such file or directory >=20 > I've seen this before too but this is due to guest-agent, not this = patch series. Ah, sorry, didn't track down what exactly was going wrong where and = figured since it fails on qapi, it'd be related :) Alex