From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-bl2nam02on0069.outbound.protection.outlook.com ([104.47.38.69]:2592 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751073AbdHCDYk (ORCPT ); Wed, 2 Aug 2017 23:24:40 -0400 From: "Patil, Harish" To: Bhumika Goyal , "julia.lawall@lip6.fr" , "kvalo@codeaurora.org" , "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Chopra, Manish" , Dept-GE Linux NIC Dev Subject: Re: [PATCH 2/2] qlcnic: add const to bin_attribute structure Date: Thu, 3 Aug 2017 03:24:37 +0000 Message-ID: (sfid-20170803_052458_669457_94308091) References: <1501696634-15765-1-git-send-email-bhumirks@gmail.com> <1501696634-15765-3-git-send-email-bhumirks@gmail.com> In-Reply-To: <1501696634-15765-3-git-send-email-bhumirks@gmail.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: LS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCkZyb206IEJodW1pa2EgR295YWwgPGJodW1pcmtz QGdtYWlsLmNvbT4NCkRhdGU6IFdlZG5lc2RheSwgQXVndXN0IDIsIDIwMTcgYXQgMTE6MjcgUE0N ClRvOiAianVsaWEubGF3YWxsQGxpcDYuZnIiIDxqdWxpYS5sYXdhbGxAbGlwNi5mcj4sICJrdmFs b0Bjb2RlYXVyb3JhLm9yZyINCjxrdmFsb0Bjb2RlYXVyb3JhLm9yZz4sICJsaW51eC13aXJlbGVz c0B2Z2VyLmtlcm5lbC5vcmciDQo8bGludXgtd2lyZWxlc3NAdmdlci5rZXJuZWwub3JnPiwgIm5l dGRldkB2Z2VyLmtlcm5lbC5vcmciDQo8bmV0ZGV2QHZnZXIua2VybmVsLm9yZz4sICJsaW51eC1r ZXJuZWxAdmdlci5rZXJuZWwub3JnIg0KPGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc+LCBI YXJpc2ggUGF0aWwgPEhhcmlzaC5QYXRpbEBjYXZpdW0uY29tPiwNCiJDaG9wcmEsIE1hbmlzaCIg PE1hbmlzaC5DaG9wcmFAY2F2aXVtLmNvbT4sIERlcHQtR0UgTGludXggTklDIERldg0KPERlcHQt R0VMaW51eE5JQ0RldkBjYXZpdW0uY29tPg0KQ2M6IEJodW1pa2EgR295YWwgPGJodW1pcmtzQGdt YWlsLmNvbT4NClN1YmplY3Q6IFtQQVRDSCAyLzJdIHFsY25pYzogYWRkIGNvbnN0IHRvIGJpbl9h dHRyaWJ1dGUgc3RydWN0dXJlDQoNCj5BZGQgY29uc3QgdG8gYmluX2F0dHJpYnV0ZSBzdHJ1Y3R1 cmUgYXMgaXQgaXMgb25seSBwYXNzZWQgdG8gdGhlDQo+ZnVuY3Rpb25zIHN5c2ZzX3tyZW1vdmUv Y3JlYXRlfV9iaW5fZmlsZS4gVGhlIGNvcnJlc3BvbmRpbmcNCj5hcmd1bWVudHMgYXJlIG9mIHR5 cGUgY29uc3QsIHNvIGRlY2xhcmUgdGhlIHN0cnVjdHVyZSB0byBiZSBjb25zdC4NCj4NCj5TaWdu ZWQtb2ZmLWJ5OiBCaHVtaWthIEdveWFsIDxiaHVtaXJrc0BnbWFpbC5jb20+DQo+LS0tDQo+IGRy aXZlcnMvbmV0L2V0aGVybmV0L3Fsb2dpYy9xbGNuaWMvcWxjbmljX3N5c2ZzLmMgfCAyICstDQo+ IDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQ0KPg0KPmRpZmYg LS1naXQgYS9kcml2ZXJzL25ldC9ldGhlcm5ldC9xbG9naWMvcWxjbmljL3FsY25pY19zeXNmcy5j DQo+Yi9kcml2ZXJzL25ldC9ldGhlcm5ldC9xbG9naWMvcWxjbmljL3FsY25pY19zeXNmcy5jDQo+ aW5kZXggNzMwMjdhNi4uODJmY2I4MyAxMDA2NDQNCj4tLS0gYS9kcml2ZXJzL25ldC9ldGhlcm5l dC9xbG9naWMvcWxjbmljL3FsY25pY19zeXNmcy5jDQo+KysrIGIvZHJpdmVycy9uZXQvZXRoZXJu ZXQvcWxvZ2ljL3FsY25pYy9xbGNuaWNfc3lzZnMuYw0KPkBAIC0xMjQ4LDcgKzEyNDgsNyBAQCBz dGF0aWMgc3NpemVfdA0KPnFsY25pY184M3h4X3N5c2ZzX2ZsYXNoX3dyaXRlX2hhbmRsZXIoc3Ry dWN0IGZpbGUgKmZpbHAsDQo+IAkud3JpdGUgPSBxbGNuaWNfc3lzZnNfd3JpdGVfcG1fY29uZmln LA0KPiB9Ow0KPiANCj4tc3RhdGljIHN0cnVjdCBiaW5fYXR0cmlidXRlIGJpbl9hdHRyX2ZsYXNo ID0gew0KPitzdGF0aWMgY29uc3Qgc3RydWN0IGJpbl9hdHRyaWJ1dGUgYmluX2F0dHJfZmxhc2gg PSB7DQo+IAkuYXR0ciA9IHsubmFtZSA9ICJmbGFzaCIsIC5tb2RlID0gKFNfSVJVR08gfCBTX0lX VVNSKX0sDQo+IAkuc2l6ZSA9IDAsDQo+IAkucmVhZCA9IHFsY25pY184M3h4X3N5c2ZzX2ZsYXNo X3JlYWRfaGFuZGxlciwNCj4tLSANCj4xLjkuMQ0KPg0KPkFja2VkLWJ5OiBIYXJpc2ggUGF0aWwg PGhhcmlzaC5wYXRpbEBjYXZpdW0uY29tPg0KDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752133AbdHCDYm (ORCPT ); Wed, 2 Aug 2017 23:24:42 -0400 Received: from mail-bl2nam02on0069.outbound.protection.outlook.com ([104.47.38.69]:2592 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751073AbdHCDYk (ORCPT ); Wed, 2 Aug 2017 23:24:40 -0400 From: "Patil, Harish" To: Bhumika Goyal , "julia.lawall@lip6.fr" , "kvalo@codeaurora.org" , "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Chopra, Manish" , Dept-GE Linux NIC Dev Subject: Re: [PATCH 2/2] qlcnic: add const to bin_attribute structure Thread-Topic: [PATCH 2/2] qlcnic: add const to bin_attribute structure Thread-Index: AQHTC7jVYSnuL1whiU6v/9xcXImTzaJyVLuA Date: Thu, 3 Aug 2017 03:24:37 +0000 Message-ID: References: <1501696634-15765-1-git-send-email-bhumirks@gmail.com> <1501696634-15765-3-git-send-email-bhumirks@gmail.com> In-Reply-To: <1501696634-15765-3-git-send-email-bhumirks@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Harish.Patil@cavium.com; x-originating-ip: [198.186.4.7] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;BN3PR0701MB1410;7:ljNLXuW9xmWlpKc6jUhLktaDK2LbUbgfYh/H26cajjcdxV1KmZpU/FF+ZyzJlHDqSw6NTif7A/E0RKiskA5FWlHDaOa5TPrlmMWib1gzU+11s/6+3YUFdlLZFgo3T63QbkEPy3aL7Wt+rfCm3gBxpz/M6iOPz447PLxMGYw8H8VJgN+2WMUWy4jrNDLDqxfBfFWDd3gzKMgUmsHqJHox68RSoWUpTtmaPYMaSbQGGluhesJHK3ZS1wLXOvB5PQNNX/Pe90rGTBceZxMk90ELG0XSyBv2h9ErAk0iMs5wYyKeMX5jASmTg8Lsz3TzbCvGuwRYqAXwjDX6tlfw8EqUzqDuhdkxnR9eGgFnWqlSQjohIkC4Ewc/h0YTpm7mtshJkKtWx3lxrOol6C4Ey8KEVigqB+fODYgpynksKXNKh3zimeBM2NLFnTm/A7CeOl4FBIQYAOhWy75sNn5XemHATavFraq2sSX/T/TRdyrRwHFjZKL4qnWBXLrRuIpw68bIeOhAdIlG+UCVw5SWD8l+OqjLwPK9JbqkFQ7xMu1LzDbYIdo1QV7HgMaLJCfqRfDWQOnVjSNhbsvnw1G4RRzL7WqS6JMBRcBlx3/gQQW+jdUqnAbq9RFx2fG/pk/5GyeIBh0LouQsC2eveTUbE5O+ASXLiprkwU9PWdTpQFPhRLsLseqzfwFgZLG7owjLQez6eVoFFHIEC6rmAAkBbD7JXCyzlsRaIAcQuckW4rzrvuIsUr8DRUBedFpHK/yZ7u2rWC56LvBs3YxpcGVDm8Gyc1n9EekRdGnKKCzIKK5E/0s= x-ms-office365-filtering-correlation-id: eff26c13-5cbc-422f-a249-08d4da1f2ba2 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603031)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:BN3PR0701MB1410; x-ms-traffictypediagnostic: BN3PR0701MB1410: x-exchange-antispam-report-test: UriScan:(9452136761055); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(100000703101)(100105400095)(6041248)(20161123562025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123558100)(20161123555025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BN3PR0701MB1410;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BN3PR0701MB1410; x-forefront-prvs: 03883BD916 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(39410400002)(39400400002)(39850400002)(39450400003)(39840400002)(189002)(199003)(13464003)(377454003)(66066001)(8936002)(81156014)(81166006)(8676002)(229853002)(6506006)(105586002)(68736007)(6436002)(2501003)(53546010)(2900100001)(102836003)(2201001)(3846002)(6116002)(2950100002)(6486002)(77096006)(6636002)(189998001)(2906002)(36756003)(6246003)(39060400002)(38730400002)(5660300001)(76176999)(54356999)(6512007)(86362001)(99286003)(478600001)(97736004)(72206003)(305945005)(25786009)(3660700001)(106356001)(3280700002)(14454004)(50986999)(7736002)(101416001)(53936002);DIR:OUT;SFP:1101;SCL:1;SRVR:BN3PR0701MB1410;H:MWHPR07MB3184.namprd07.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <8CF4BEA7EE9C5447BDE1C3F1CE507595@namprd07.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Aug 2017 03:24:37.5127 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0701MB1410 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v733OpWV009734 -----Original Message----- From: Bhumika Goyal Date: Wednesday, August 2, 2017 at 11:27 PM To: "julia.lawall@lip6.fr" , "kvalo@codeaurora.org" , "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Harish Patil , "Chopra, Manish" , Dept-GE Linux NIC Dev Cc: Bhumika Goyal Subject: [PATCH 2/2] qlcnic: add const to bin_attribute structure >Add const to bin_attribute structure as it is only passed to the >functions sysfs_{remove/create}_bin_file. The corresponding >arguments are of type const, so declare the structure to be const. > >Signed-off-by: Bhumika Goyal >--- > drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c >b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c >index 73027a6..82fcb83 100644 >--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c >+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c >@@ -1248,7 +1248,7 @@ static ssize_t >qlcnic_83xx_sysfs_flash_write_handler(struct file *filp, > .write = qlcnic_sysfs_write_pm_config, > }; > >-static struct bin_attribute bin_attr_flash = { >+static const struct bin_attribute bin_attr_flash = { > .attr = {.name = "flash", .mode = (S_IRUGO | S_IWUSR)}, > .size = 0, > .read = qlcnic_83xx_sysfs_flash_read_handler, >-- >1.9.1 > >Acked-by: Harish Patil