From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1EF8C433E7 for ; Wed, 2 Sep 2020 21:31:40 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C937D207EA for ; Wed, 2 Sep 2020 21:31:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C937D207EA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 671726E0B8; Wed, 2 Sep 2020 21:31:40 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4ED6E6E0B8 for ; Wed, 2 Sep 2020 21:31:39 +0000 (UTC) IronPort-SDR: KLb8lGefqwJGQqHgwOU/Q3r3Y/3vl9rAcCuBxT8AeQPCPoV62S6WkFUQyBKXSPC0T8VZ3P3Fsz wE7CsuV6oJLg== X-IronPort-AV: E=McAfee;i="6000,8403,9732"; a="156752331" X-IronPort-AV: E=Sophos;i="5.76,384,1592895600"; d="scan'208";a="156752331" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Sep 2020 14:31:38 -0700 IronPort-SDR: RzpgRjET5NSy4ksBpi5vrzCo2uOm2oImnKckR+WIAULSkSOa31AiiMfhJPNagyeeyWh9Yp9m3/ IUk7RbGrgb/g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,384,1592895600"; d="scan'208";a="405283856" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga001.fm.intel.com with ESMTP; 02 Sep 2020 14:31:38 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 2 Sep 2020 14:31:38 -0700 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 2 Sep 2020 14:31:38 -0700 Received: from fmsmsx106.amr.corp.intel.com ([169.254.5.233]) by fmsmsx101.amr.corp.intel.com ([169.254.1.123]) with mapi id 14.03.0439.000; Wed, 2 Sep 2020 14:31:37 -0700 From: "Vivi, Rodrigo" To: "Srivatsa, Anusha" Thread-Topic: [Intel-gfx] [PATCH] drm/i915/pll: Centralize PLL_ENABLE register lookup Thread-Index: AQHWgI+zN2W3izWyOkmWd3rL3gnsqalUoMAAgAGSm4CAACG9AA== Date: Wed, 2 Sep 2020 21:31:37 +0000 Message-ID: References: <20200901182758.29203-1-anusha.srivatsa@intel.com> <20200901192952.GA386451@intel.com> <83F5C7385F545743AD4FB2A62F75B0734E32847A@ORSMSX151.amr.corp.intel.com> In-Reply-To: <83F5C7385F545743AD4FB2A62F75B0734E32847A@ORSMSX151.amr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.212.95.35] Content-ID: <81301542A238CF40B7AA046203B4CCA3@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH] drm/i915/pll: Centralize PLL_ENABLE register lookup X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "intel-gfx@lists.freedesktop.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" DQoNCj4gT24gU2VwIDIsIDIwMjAsIGF0IDEyOjMwIFBNLCBTcml2YXRzYSwgQW51c2hhIDxhbnVz aGEuc3JpdmF0c2FAaW50ZWwuY29tPiB3cm90ZToNCj4gDQo+IA0KPiANCj4+IC0tLS0tT3JpZ2lu YWwgTWVzc2FnZS0tLS0tDQo+PiBGcm9tOiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2aUBpbnRl bC5jb20+DQo+PiBTZW50OiBUdWVzZGF5LCBTZXB0ZW1iZXIgMSwgMjAyMCAxMjozMCBQTQ0KPj4g VG86IFNyaXZhdHNhLCBBbnVzaGEgPGFudXNoYS5zcml2YXRzYUBpbnRlbC5jb20+DQo+PiBDYzog aW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZw0KPj4gU3ViamVjdDogUmU6IFtJbnRlbC1n ZnhdIFtQQVRDSF0gZHJtL2k5MTUvcGxsOiBDZW50cmFsaXplIFBMTF9FTkFCTEUgcmVnaXN0ZXIN Cj4+IGxvb2t1cA0KPj4gDQo+PiBPbiBUdWUsIFNlcCAwMSwgMjAyMCBhdCAxMToyNzo1OEFNIC0w NzAwLCBBbnVzaGEgU3JpdmF0c2Egd3JvdGU6DQo+Pj4gV2UgY3VycmVudHkgY2hlY2sgZm9yIHBs YXRmb3JtIGF0IG11bHRpcGxlIHBhcnRzIGluIHRoZSBkcml2ZXIgdG8gZ3JhYg0KPj4+IHRoZSBj b3JyZWN0IFBMTC4gTGV0IHVzIGJlZ2luIHRvIGNlbnRyYWxpemUgaXQgdGhyb3VnaCBhIGhlbHBl cg0KPj4+IGZ1bmN0aW9uLg0KPj4+IA0KPj4+IHYyOiBzL2ludGVsX2dldF9wbGxfZW5hYmxlX3Jl ZygpL2ludGVsX2NvbWJvX3BsbF9lbmFibGVfcmVnKCkgKFZpbGxlKQ0KPj4+IA0KPj4+IFN1Z2dl c3RlZC1ieTogTWF0dCBSb3BlciA8bWF0dGhldy5kLnJvcGVyQGludGVsLmNvbT4NCj4+PiBDYzog VmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4NCj4+PiBDYzog TWF0dCBSb3BlciA8bWF0dGhldy5kLnJvcGVyQGludGVsLmNvbT4NCj4+PiBTaWduZWQtb2ZmLWJ5 OiBBbnVzaGEgU3JpdmF0c2EgPGFudXNoYS5zcml2YXRzYUBpbnRlbC5jb20+DQo+Pj4gLS0tDQo+ Pj4gZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kcGxsX21nci5jIHwgMjUNCj4+ PiArKysrKysrKysrKy0tLS0tLS0tDQo+Pj4gMSBmaWxlIGNoYW5nZWQsIDE1IGluc2VydGlvbnMo KyksIDEwIGRlbGV0aW9ucygtKQ0KPj4+IA0KPj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9kaXNwbGF5L2ludGVsX2RwbGxfbWdyLmMNCj4+PiBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2Rpc3BsYXkvaW50ZWxfZHBsbF9tZ3IuYw0KPj4+IGluZGV4IGM5MDEzZjhmNzY2Zi4uNzQ0 MDgzNmM1ZTQ0IDEwMDY0NA0KPj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkv aW50ZWxfZHBsbF9tZ3IuYw0KPj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkv aW50ZWxfZHBsbF9tZ3IuYw0KPj4+IEBAIC0xNDcsNiArMTQ3LDE4IEBAIHZvaWQgYXNzZXJ0X3No YXJlZF9kcGxsKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlDQo+PiAqZGV2X3ByaXYsDQo+Pj4gCQkJ cGxsLT5pbmZvLT5uYW1lLCBvbm9mZihzdGF0ZSksIG9ub2ZmKGN1cl9zdGF0ZSkpOyAgfQ0KPj4+ IA0KPj4+ICtzdGF0aWMNCj4+PiAraTkxNV9yZWdfdCBpbnRlbF9jb21ib19wbGxfZW5hYmxlX3Jl ZyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZQ0KPj4gKmRldl9wcml2LA0KPj4+ICsJCQkJICAgIHN0 cnVjdCBpbnRlbF9zaGFyZWRfZHBsbCAqcGxsKSB7DQo+Pj4gKw0KPj4+ICsJaWYgKElTX0VMS0hB UlRMQUtFKGRldl9wcml2KSAmJiAocGxsLT5pbmZvLT5pZCA9PQ0KPj4gRFBMTF9JRF9FSExfRFBM TDQpKQ0KPj4+ICsJCQlyZXR1cm4gTUdfUExMX0VOQUJMRSgwKTsNCj4+PiArDQo+Pj4gKwlyZXR1 cm4gQ05MX0RQTExfRU5BQkxFKHBsbC0+aW5mby0+aWQpOw0KPj4+ICsNCj4+PiArDQo+Pj4gK30N Cj4+PiAvKioNCj4+PiAgKiBpbnRlbF9wcmVwYXJlX3NoYXJlZF9kcGxsIC0gY2FsbCBhIGRwbGwn cyBwcmVwYXJlIGhvb2sNCj4+PiAgKiBAY3J0Y19zdGF0ZTogQ1JUQywgYW5kIGl0cyBzdGF0ZSwg d2hpY2ggaGFzIGEgc2hhcmVkIGRwbGwgQEANCj4+PiAtMzg0MiwxMiArMzg1NCw3IEBAIHN0YXRp YyBib29sIGNvbWJvX3BsbF9nZXRfaHdfc3RhdGUoc3RydWN0DQo+PiBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdiwNCj4+PiAJCQkJICAgc3RydWN0IGludGVsX3NoYXJlZF9kcGxsICpwbGwsDQo+ Pj4gCQkJCSAgIHN0cnVjdCBpbnRlbF9kcGxsX2h3X3N0YXRlICpod19zdGF0ZSkgIHsNCj4+PiAt CWk5MTVfcmVnX3QgZW5hYmxlX3JlZyA9IENOTF9EUExMX0VOQUJMRShwbGwtPmluZm8tPmlkKTsN Cj4+PiAtDQo+Pj4gLQlpZiAoSVNfRUxLSEFSVExBS0UoZGV2X3ByaXYpICYmDQo+Pj4gLQkgICAg cGxsLT5pbmZvLT5pZCA9PSBEUExMX0lEX0VITF9EUExMNCkgew0KPj4+IC0JCWVuYWJsZV9yZWcg PSBNR19QTExfRU5BQkxFKDApOw0KPj4+IC0JfQ0KPj4+ICsJaTkxNV9yZWdfdCBlbmFibGVfcmVn ID0gaW50ZWxfY29tYm9fcGxsX2VuYWJsZV9yZWcoZGV2X3ByaXYsIHBsbCk7DQo+Pj4gDQo+Pj4g CXJldHVybiBpY2xfcGxsX2dldF9od19zdGF0ZShkZXZfcHJpdiwgcGxsLCBod19zdGF0ZSwgZW5h YmxlX3JlZyk7ICB9DQo+Pj4gQEAgLTQwNDUsMTEgKzQwNTIsMTAgQEAgc3RhdGljIHZvaWQgaWNs X3BsbF9lbmFibGUoc3RydWN0DQo+Pj4gZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsICBzdGF0 aWMgdm9pZCBjb21ib19wbGxfZW5hYmxlKHN0cnVjdA0KPj4gZHJtX2k5MTVfcHJpdmF0ZSAqZGV2 X3ByaXYsDQo+Pj4gCQkJICAgICBzdHJ1Y3QgaW50ZWxfc2hhcmVkX2RwbGwgKnBsbCkgIHsNCj4+ PiAtCWk5MTVfcmVnX3QgZW5hYmxlX3JlZyA9IENOTF9EUExMX0VOQUJMRShwbGwtPmluZm8tPmlk KTsNCj4+PiArCWk5MTVfcmVnX3QgZW5hYmxlX3JlZyA9IGludGVsX2NvbWJvX3BsbF9lbmFibGVf cmVnKGRldl9wcml2LCBwbGwpOw0KPj4+IA0KPj4+IAlpZiAoSVNfRUxLSEFSVExBS0UoZGV2X3By aXYpICYmDQo+Pj4gCSAgICBwbGwtPmluZm8tPmlkID09IERQTExfSURfRUhMX0RQTEw0KSB7DQo+ PiANCj4+IHRoZXJlJ3MgcHJvYmFibHkgc29tZXRoaW5nIGVsc2UgdGhhdCB3ZSBjYW4gZG8gbm93 IHdpdGggdGhlDQo+PiBwb3dlcl97cHV0LGdldH0gdG8gZ2V0IHJpZCBvZiB0aGUsIG5vdywgZG91 YmxlZCBpZiBjaGVja3MuLi4NCj4gDQo+IERvbid0IGZvbGxvdyB5b3UgaGVyZSBSb2RyaWdvLg0K DQptZSBuZWl0aGVyIDspDQpJJ20ganVzdCBicmFpbnN0b3JtaW5nLi4uIHRoaW5raW5nIG91dCBs b3V0LiANCg0KPiBBcmUgeW91IHN1Z2dlc3RpbmcgdXNpbmcgcG93ZXJfe3B1dC9nZXR9IHRvIHNv bWVob3cgZ2V0IHJpZCBvZiBkb3VibGVkIGlmPw0KDQphZnRlciB0aGlzIHBhdGNoLCBvbiB0aGlz IHBhdGggd2Ugd2lsbCBkbyB0aGlzIGlmIGNoZWNrIHR3aWNlLg0Kbm90IGEgYmlnIGRlYWwsIGJ1 dCB3ZSBjYW4gcHJvYmFibHkgZG8gc29tZXRoaW5nIGJldHRlci4NCg0KSG93ZXZlciBJIGRvbid0 IHVuZGVyc3RhbmQgd2h5IHdlIGhhZCB0aGlzIGdldC9wdXQgaGVyZSBhdCBmaXJzdCBwbGFjZS4N Ck9ubHkgZm9yIHRoaXMgcGxhdGZvcm0gYW5kIG9ubHkgZm9yIHRoaXMgcGxsNC4gU28sIHdoYXQg SSBhbSB3b25kZXJpbmcgaXMNCnRoYXQgd2UgaGF2ZSBzb21ldGhpbmcgYmV0dGVyIHRvIGRvIHdp dGggdGhlIHBvd2VyX3dlbGwgaW5mcmFzdHJ1Y3R1cmUNCmluIGdlbmVyYWwgdGhhdCB3b3VsZCBh bGxvdyB1cyB0byBhdm9pZCB0aGUgaWYgKHBsYXRmb3JtICYmIHBsbDQpIGluIGZhdm9yDQpvZiBz b21ldGhpbmcgbW9yZSBnZW5lcmljLg0KDQpidXQgZGVmaW5pdGVseSBub3QgYSBibG9ja2VyIGZv ciB0aGlzIHBhdGNoIGl0c2VsZi4NCg0KPiANCj4+PiAtCQllbmFibGVfcmVnID0gTUdfUExMX0VO QUJMRSgwKTsNCj4+PiANCj4+PiAJCS8qDQo+Pj4gCQkgKiBXZSBuZWVkIHRvIGRpc2FibGUgREMg c3RhdGVzIHdoZW4gdGhpcyBEUExMIGlzIGVuYWJsZWQuDQo+Pj4gQEAgLTQxNTcsMTEgKzQxNjMs MTAgQEAgc3RhdGljIHZvaWQgaWNsX3BsbF9kaXNhYmxlKHN0cnVjdA0KPj4+IGRybV9pOTE1X3By aXZhdGUgKmRldl9wcml2LCAgc3RhdGljIHZvaWQgY29tYm9fcGxsX2Rpc2FibGUoc3RydWN0DQo+ PiBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwNCj4+PiAJCQkgICAgICBzdHJ1Y3QgaW50ZWxf c2hhcmVkX2RwbGwgKnBsbCkgIHsNCj4+PiAtCWk5MTVfcmVnX3QgZW5hYmxlX3JlZyA9IENOTF9E UExMX0VOQUJMRShwbGwtPmluZm8tPmlkKTsNCj4+PiArCWk5MTVfcmVnX3QgZW5hYmxlX3JlZyA9 IGludGVsX2NvbWJvX3BsbF9lbmFibGVfcmVnKGRldl9wcml2LCBwbGwpOw0KPj4+IA0KPj4+IAlp ZiAoSVNfRUxLSEFSVExBS0UoZGV2X3ByaXYpICYmDQo+Pj4gCSAgICBwbGwtPmluZm8tPmlkID09 IERQTExfSURfRUhMX0RQTEw0KSB7DQo+Pj4gLQkJZW5hYmxlX3JlZyA9IE1HX1BMTF9FTkFCTEUo MCk7DQo+Pj4gCQlpY2xfcGxsX2Rpc2FibGUoZGV2X3ByaXYsIHBsbCwgZW5hYmxlX3JlZyk7DQo+ PiANCj4+IGJ1dCBoZXJlLCBhdCBsZWFzdCwgbGV0J3MgY2xlYW4gdGhpcyBmdW5jdGlvbiBub3cu Li4NCj4+IG1vdmUgdGhpcyBjYWxsIGFib3ZlIGFuZCBvdXQgb2YgdGhlIGlmIGFuZCBkZWxldGUg dGhlIG9uZSBiZWxvdyBhbmQga2VlcA0KPj4ganVzdCB0aGUgcG93ZXJfcHV0IGluc2lkZSB0aGUg aWYuLi4NCj4gDQo+IEdvb2QgY2hhbmdlLiBUaGFua3MhDQo+IFdpbGwgY2hhbmdlIHRoYXQuDQo+ IA0KPiBBbnVzaGENCj4gDQo+Pj4gDQo+Pj4gCQlpbnRlbF9kaXNwbGF5X3Bvd2VyX3B1dChkZXZf cHJpdiwNCj4+IFBPV0VSX0RPTUFJTl9EUExMX0RDX09GRiwNCj4+PiAtLQ0KPj4+IDIuMjUuMA0K Pj4+IA0KPj4+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f DQo+Pj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdA0KPj4+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcNCj4+PiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2ludGVsLWdmeA0KDQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRl bC1nZngK