All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Alain Michaud <alainmichaud@google.com>
Cc: Johan Hedberg <johan.hedberg@gmail.com>,
	Alain Michaud <alainm@chromium.org>,
	BlueZ <linux-bluetooth@vger.kernel.org>
Subject: Re: [Bluez PATCH] doc: Add definition for Set Kernel Debug Level
Date: Thu, 23 Jan 2020 19:16:56 +0100	[thread overview]
Message-ID: <D61B5AA9-A509-4253-95D7-F6401C832081@holtmann.org> (raw)
In-Reply-To: <CALWDO_Vqboxt4JfV9yGVd5Jv5jZ-vwtOghh4tffpQpQzHuq6NQ@mail.gmail.com>

Hi Alain,

> From a high level, this looks good for me although I agree, this is an
> order of magnitude bigger in terms of scope.  Can you suggest perhaps
> an interactive way to deliver this over a period of time, perhaps
> prioritizing the BT_DEBUG kernel messages first? :)

I am always in favor of increasing the ability to debug things, but we need to do this in a clean fashion and not some short term hacks (since they will come back and haunt us). I like to get some review on my idea first.

What we could do is work on the BT_DBG etc infrastructure to allow switching when dynamic_debug is not available. Then you would use some debugfs toggle in /sys/kernel/debug/bluetooth since that is no stable API for us (and of course the clear understanding that this toggle is temporary).

Regards

Marcel


  reply	other threads:[~2020-01-23 18:16 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-20 20:27 [Bluez PATCH] doc: Add definition for Set Kernel Debug Level Alain Michaud
2020-01-21 16:20 ` Marcel Holtmann
2020-01-21 18:25   ` Alain Michaud
2020-01-21 18:33     ` Johan Hedberg
2020-01-21 18:37       ` Alain Michaud
2020-01-22 21:48         ` Alain Michaud
2020-01-23  5:52           ` Marcel Holtmann
2020-01-23 14:38             ` Alain Michaud
2020-01-23 17:44               ` Marcel Holtmann
2020-01-23 18:04                 ` Alain Michaud
2020-01-23 18:16                   ` Marcel Holtmann [this message]
2020-01-23 18:18                     ` Alain Michaud
2020-01-23 23:13                       ` Luiz Augusto von Dentz
2020-01-27 16:54                     ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D61B5AA9-A509-4253-95D7-F6401C832081@holtmann.org \
    --to=marcel@holtmann.org \
    --cc=alainm@chromium.org \
    --cc=alainmichaud@google.com \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.