From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=50950 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PjA9d-0001cP-DK
	for qemu-devel@nongnu.org; Sat, 29 Jan 2011 07:43:50 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1PjA9c-0005DC-6L
	for qemu-devel@nongnu.org; Sat, 29 Jan 2011 07:43:49 -0500
Received: from fmmailgate01.web.de ([217.72.192.221]:42974)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1PjA9b-0005Cw-W7
	for qemu-devel@nongnu.org; Sat, 29 Jan 2011 07:43:48 -0500
Message-Id: <D8BF4783-91E1-446D-BDE3-C33AD5E6E8BC@web.de>
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <andreas.faerber@web.de>
In-Reply-To: <1296240805-6264-1-git-send-email-weil@mail.berlios.de>
Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Apple Message framework v936)
Subject: Re: [Qemu-devel] [PATCH v2] ui: Load QEMU icon from SDL user interface
Date: Sat, 29 Jan 2011 13:43:45 +0100
References: <4D41E130.2070507@mail.berlios.de>
	<1296240805-6264-1-git-send-email-weil@mail.berlios.de>
Sender: andreas.faerber@web.de
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>, QEMU Developers <qemu-devel@nongnu.org>

Hi Stefan,

Am 28.01.2011 um 19:53 schrieb Stefan Weil:

> Load an optional QEMU icon file. If there is no icon file named
> qemu-icon.bmp in QEMU's default search path, QEMU will run with
> the usual system default icon.
>
> A matching icon file  will be loaded and used by X Windows managers
> or MS Windows while a QEMU instance is running.
>
> SDL requires icon files in 32x32 bmp format.
>
> v2:
> The first version of this patch also included qemu-icon.bmp
> and rules to handle this file. That part will now be published
> in a separate patch as soon as the QEMU community has chosen
> a common QEMU icon. The SDL code here is useful to try
> different icons.
>
> Cc: Anthony Liguori <aliguori@us.ibm.com>
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>

Might to explain this in more detail, please? A .bmp file is a device- 
independent bitmap. The whole point of Windows' icon format was to be  
device-dependent from 16x16 to 64x64 (or 128x128?) resolution and 2-  
to 32-bit color spaces.

So what does SDL do with it, and if SDL is limiting us here can't we  
add a .ico file and call the corresponding Win32 API function directly  
instead?

Regards,
Andreas