All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/3] Bluetooth: Make use of hci_{suspend,resume}_dev on suspend notifier
Date: Tue, 28 Sep 2021 10:06:08 +0200	[thread overview]
Message-ID: <D98BDF56-031B-4AFF-B5E4-A2D30285F9D8@holtmann.org> (raw)
In-Reply-To: <20210927200611.2722757-1-luiz.dentz@gmail.com>

Hi Luiz,

> This moves code from hci_suspend_notifier to hci_{suspend,resume}_dev
> since some driver may handle pm directly using
> HCI_QUIRK_NO_SUSPEND_NOTIFIER.
> 
> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> ---
> net/bluetooth/hci_core.c | 116 ++++++++++++++++++++++-----------------
> 1 file changed, 67 insertions(+), 49 deletions(-)

hmmm. So btmrvl_sdio.c actually calls hci_suspend_dev. And in fact hci_suspend_dev is only there to be called from the drivers. Something called from the core or via debugfs needs a different function name.

Regards

Marcel


      parent reply	other threads:[~2021-09-28  8:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-27 20:06 [PATCH 1/3] Bluetooth: Make use of hci_{suspend,resume}_dev on suspend notifier Luiz Augusto von Dentz
2021-09-27 20:06 ` [PATCH 2/3] Bluetooth: debugfs: Add force_suspend entry Luiz Augusto von Dentz
2021-09-27 20:06 ` [PATCH 3/3] Bluetooth: debugfs: Add force_prevent_wake entry Luiz Augusto von Dentz
2021-09-27 23:09 ` [1/3] Bluetooth: Make use of hci_{suspend,resume}_dev on suspend notifier bluez.test.bot
2021-09-28  8:06 ` Marcel Holtmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D98BDF56-031B-4AFF-B5E4-A2D30285F9D8@holtmann.org \
    --to=marcel@holtmann.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.