Re: [PATCH v5 4/4] Bluetooth: Add toggle to switch off interleave scan

[Marcel Holtmann <marcel@holtmann.org>]

Hi Howard,

> This patch add a configurable parameter to switch off the interleave
> scan feature.
> 
> Signed-off-by: Howard Chung <howardchung@google.com>
> Reviewed-by: Alain Michaud <alainm@chromium.org>
> ---
> 
> (no changes since v4)
> 
> Changes in v4:
> - Set EnableAdvMonInterleaveScan default to Disable
> - Fix 80 chars limit in mgmt_config.c
> 
> include/net/bluetooth/hci_core.h | 1 +
> net/bluetooth/hci_core.c         | 1 +
> net/bluetooth/hci_request.c      | 3 ++-
> net/bluetooth/mgmt_config.c      | 5 +++++
> 4 files changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/include/net/bluetooth/hci_core.h b/include/net/bluetooth/hci_core.h
> index cfede18709d8f..b0225b80152cc 100644
> --- a/include/net/bluetooth/hci_core.h
> +++ b/include/net/bluetooth/hci_core.h
> @@ -363,6 +363,7 @@ struct hci_dev {
> 	__u32		clock;
> 	__u16		advmon_allowlist_duration;
> 	__u16		advmon_no_filter_duration;
> +	__u16		enable_advmon_interleave_scan;

I really have to see the patch for doc/mgmt-api.txt first and I am certainly not really in favor of using an uint16 for a simple boolean on/off value just because the kernel code is simpler that way.

Regards

Marcel