Re: [Buildroot] [PATCH v1 2/2] configs/zynqmp_zcu106_defconfig: transition to tarballs

From: Neal Frager <nealf@xilinx.com>
To: Luca Ceresoli <luca@lucaceresoli.net>
Cc: "buildroot@buildroot.org" <buildroot@buildroot.org>,
	Michal Simek <michals@xilinx.com>,
	"giulio.benetti@benettiengineering.com"
	<giulio.benetti@benettiengineering.com>,
	Neal Frager <neal.frager@amd.com>
Subject: Re: [Buildroot] [PATCH v1 2/2] configs/zynqmp_zcu106_defconfig: transition to tarballs
Date: Thu, 12 May 2022 16:09:42 +0000	[thread overview]
Message-ID: <D9EEAC86-D8CB-46E0-A019-B0F792B0511C@xilinx.com> (raw)
In-Reply-To: <56c3feaa-cbd2-eaa9-7800-cd2102fa8545@lucaceresoli.net>

Hi Luca,

> Le 12 mai 2022 à 16:38, Luca Ceresoli <luca@lucaceresoli.net> a écrit :
> 
> CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email.
> 
> 
> Hi Peter,
> 
> On 11/05/22 17:54, Peter Korsgaard wrote:
>>>>>>> "Neal" == Neal Frager <nealf@xilinx.com> writes:
>> 
>>> Hi Luca,
>>> We may need your help on this one.
>> 
>>> Peter and I have both replaced the pmufw.bin generated by the zynqmp-pmufw-builder with the one generated
>>> by vitis or petalinux.  When we build the boot.bin using the pmufw.bin from vitis or petalinux, reboot works
>>> as expected without changing anything else.
>> 
>>> So there appears to be something in the zynqmp-pmufw-builder which is incorrect for the pmufw 2022.1.
>> 
>> I believe it is an issue with (a different behaviour of) the
>> toolchain. I found a machine at $WORK with petalinux 2021.1 and rebuild
>> zynqmp-pmufw-builder with the following minor patch:
>> 
>> diff --git a/build.sh b/build.sh
>> index 6321733..f01194d 100755
>> --- a/build.sh
>> +++ b/build.sh
>> @@ -59,7 +59,7 @@ pmufw_build()
>>     BSP_TARGETS_LIBDIR="${BSP_DIR}/psu_pmu_0/lib"
>>     BSP_LIBXIL="${BSP_TARGETS_LIBDIR}/libxil.a"
>> 
>> -    CROSS="${HOME}/x-tools/microblazeel-xilinx-elf/bin/microblazeel-xilinx-elf-"
>> +    CROSS="microblaze-xilinx-elf-"
>>     CC=${CROSS}gcc
>>     AR=${CROSS}ar
>>     AS=${CROSS}as
>> @@ -92,7 +92,7 @@ pmufw_build()
>>              AS="${AS}" \
>>              COMPILER="${CC}" \
>>              COMPILER_FLAGS="-O2 -c" \
>> -             EXTRA_COMPILER_FLAGS="-g -Wall -Wextra -Os -flto -ffat-lto-objects" \
>> +             EXTRA_COMPILER_FLAGS="-g -Wall -Wextra -Os -flto -ffat-lto-objects -mlittle-endian -mxl-barrel-shift -mxl-pattern-compare -mcpu=v9.2 -mxl-soft-mul" \
>>              ARCHIVER="${AR}" \
>>              CFLAGS="${CFLAGS}" \
>>              include libs
>> 
>> I had to also pass the -m* flags in EXTRA_COMPILER_FLAGS to get it to
>> link, presumably the petalinux toolchain has incompatible
>> defaults. Luca, any specific reasons to not pass CFLAGS there?
> 
> I'm afraid I have no real answer. :( When I initially wrote the script I
> did it to have the same logic as petalinux. Later I didn't watch for its
> changes. I would love to be helpful but I have no access to a zynqmp
> board now.
> 
> --
> Luca

Would it be possible for you to just implement the changes that Peter has proposed?  Peter appears to have already identified a solution.  

Both Peter and I have zcu106 boards, so we can both test and verify the update works.

Thanks for any help!

Best regards,
Neal Frager
AMD

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot