All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Zhu, Yi" <yi.zhu@intel.com>
To: Vlad Yasevich <vladislav.yasevich@hp.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Sridhar Samudrala <sri@us.ibm.com>
Subject: RE: [PATCH V2 5/7] sctp: use limited socket backlog
Date: Wed, 3 Mar 2010 22:19:46 +0800	[thread overview]
Message-ID: <DA586906BA1FFC4384FCFD6429ECE860A45A699B@shzsmsx502.ccr.corp.intel.com> (raw)
In-Reply-To: <4B8E6DD0.1020603@hp.com>

Vlad Yasevich <vladislav.yasevich@hp.com> wrote:

> I think this will result in a double-free of the skb, because sctp_chunk_free
> attempts to free the skb that's been assigned to the chunk.  You can set the skb
> to NULL to get around that.

Ah, I missed that. Thanks!

<...>

> You also leak the ref counts here since now it's possible to not add a packet to
> the backlog queue.  That means you'll take refs, but never drop them because
> the receive routing will never run.

Good catch. I'll fix it.

BTW, does the current backlog limit (sysctl_rmem_default[1] << 1) enough for sctp?
I noticed the sysctl_sctp_rmem[1] is set to 373500 in my box.

Thanks,
-yi


  reply	other threads:[~2010-03-03 14:19 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-03  8:36 [PATCH V2 1/7] net: add limit for socket backlog Zhu Yi
2010-03-03  8:36 ` [PATCH V2 2/7] tcp: use limited " Zhu Yi
2010-03-03  8:36   ` [PATCH V2 3/7] udp: " Zhu Yi
     [not found]     ` <1267605389-7369-4-git-send-email-yi.zhu@intel.com>
2010-03-03  8:36       ` [PATCH V2 5/7] sctp: " Zhu Yi
2010-03-03  8:36         ` [PATCH V2 6/7] tipc: " Zhu Yi
2010-03-03  8:36           ` [PATCH V2 7/7] net: backlog functions rename Zhu Yi
2010-03-03 14:10         ` [PATCH V2 5/7] sctp: use limited socket backlog Vlad Yasevich
2010-03-03 14:19           ` Zhu, Yi [this message]
2010-03-03 14:36             ` Vlad Yasevich
2010-03-04  2:00               ` Zhu, Yi
2010-03-03  8:53   ` [PATCH V2 2/7] tcp: " Eric Dumazet
2010-03-03  9:06     ` Zhu Yi
2010-03-03 10:07       ` Eric Dumazet
2010-03-03 14:12         ` Zhu, Yi
2010-03-03 14:31           ` Eric Dumazet
2010-03-04  5:21             ` Zhu, Yi
2010-03-04  6:00               ` Eric Dumazet
2010-03-04 11:04                 ` Zhu, Yi
2010-03-04 14:56                   ` Eric Dumazet
2010-03-03  8:54 ` [PATCH V2 1/7] net: add limit for " David Miller
2010-03-03  9:01   ` Zhu Yi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DA586906BA1FFC4384FCFD6429ECE860A45A699B@shzsmsx502.ccr.corp.intel.com \
    --to=yi.zhu@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=sri@us.ibm.com \
    --cc=vladislav.yasevich@hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.