From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A8BAC4360C for ; Fri, 27 Sep 2019 01:20:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4836520835 for ; Fri, 27 Sep 2019 01:20:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="gzWVkz8A" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727868AbfI0BUX (ORCPT ); Thu, 26 Sep 2019 21:20:23 -0400 Received: from mail-eopbgr140049.outbound.protection.outlook.com ([40.107.14.49]:6371 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725808AbfI0BUX (ORCPT ); Thu, 26 Sep 2019 21:20:23 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ql7VdHwyOn3rQse9E8HBpOy7nAH4n4Go2jDSqYuI7qqIMEQFbZL7nbjgjpBiZLwdQiJkt8I+Qe0U41QIXSIxbJ2gkNsaFz4ln9Ze1+X/oYbA++eDpv0xmhNwOszvKB332PFvUyDZ0fL5DMpmsHA3ucHYJAIc5MF2Hv4XHhY3+o7YD5oNaQkZxrr8vIoesSqj9VBzO/mJjZtqyxtrxnMLDjDg20TgmM9MXfNC2P5OTwK8uXLke6i5CAFrzIlCc9oBNbUpqExBK3iRhX8uFjhyJM+JWWPJX/zWJQcNS4NwdEixDHQX+Cy0XFEfYelSn+P2thnUpQdFqXFwwFwiAjA3XA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JXmBSpXUKHDu0Em+Dia+VEzOiwGY0ytRP9L24v+/Z1Q=; b=YSKZqKLukNo9+p0L3aLdpYCyibbJjYORZWiGa6hS394lhEQPaMQzF7sGUqZ+9VxEIctVNkgUqnqbJEcYpcFbq0X2GF6jlEqb8sMIOAC5j40VQakOEcNJ0K8QZ7N3Q4mcOYqzZckgaROYxnORrO5G626LP+cUFcPTMawGYzdxzMeOKeFsjkC7XLqX1LM6RxkwefoWXEPXXqxb/LOafnm+wzgdiltFHmK9EDgP812spDofXg3ub50O6bA9gKeUMcfhnHo8f5dctJ+Gso2dbtSeaWou5qeUsk5C+xqB1sHLVEDR7+Vz1ThxR1Jl1tVHcGTIPusSIcj5EoK6r0OLCD8MxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JXmBSpXUKHDu0Em+Dia+VEzOiwGY0ytRP9L24v+/Z1Q=; b=gzWVkz8A6bR5w4xzjSstCntuCMllNGuJiyucWIrtY4/0JAqN5EjqNNwRv4wOYUb6zOBrcmhEhUmnpXCktCQq0xEaj7t9oCqSpPJYi7q7wCQGWQ/8xdyZJGhQw0ymm8gNKrjewLwvmweF/L6WuT+T6k/KMMRJ6UCKTX8CZoo6ayY= Received: from DB3PR0402MB3916.eurprd04.prod.outlook.com (52.134.72.18) by DB3PR0402MB3753.eurprd04.prod.outlook.com (52.134.71.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2284.21; Fri, 27 Sep 2019 01:20:17 +0000 Received: from DB3PR0402MB3916.eurprd04.prod.outlook.com ([fe80::8958:299c:bc54:2a38]) by DB3PR0402MB3916.eurprd04.prod.outlook.com ([fe80::8958:299c:bc54:2a38%7]) with mapi id 15.20.2284.028; Fri, 27 Sep 2019 01:20:17 +0000 From: Anson Huang To: Leonard Crestez , Marco Felsch , Aisheng Dong CC: "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "festevam@gmail.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , dl-linux-imx Subject: RE: [PATCH] firmware: imx: Skip return value check for some special SCU firmware APIs Thread-Topic: [PATCH] firmware: imx: Skip return value check for some special SCU firmware APIs Thread-Index: AQHVc4lT/ErvPybCJUCbZ2x7mLGjsqc+tdHg Date: Fri, 27 Sep 2019 01:20:17 +0000 Message-ID: References: <1569406066-16626-1-git-send-email-Anson.Huang@nxp.com> <20190926075914.i7tsd3cbpitrqe4q@pengutronix.de> <20190926100558.egils3ds37m3s5wo@pengutronix.de> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=anson.huang@nxp.com; x-originating-ip: [119.31.174.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b45de280-eca6-471d-123d-08d742e8db3c x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600167)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);SRVR:DB3PR0402MB3753; x-ms-traffictypediagnostic: DB3PR0402MB3753:|DB3PR0402MB3753: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0173C6D4D5 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(346002)(366004)(39860400002)(396003)(136003)(376002)(199004)(189003)(6636002)(229853002)(476003)(26005)(55016002)(6246003)(71200400001)(74316002)(66556008)(64756008)(102836004)(2906002)(66476007)(71190400001)(316002)(186003)(8676002)(25786009)(9686003)(81156014)(66066001)(81166006)(99286004)(7696005)(76176011)(486006)(66446008)(44832011)(54906003)(446003)(7736002)(110136005)(33656002)(4326008)(8936002)(478600001)(52536014)(6436002)(305945005)(256004)(53546011)(5660300002)(6116002)(66946007)(11346002)(3846002)(6506007)(14454004)(76116006)(86362001);DIR:OUT;SFP:1101;SCL:1;SRVR:DB3PR0402MB3753;H:DB3PR0402MB3916.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 0ADiU2w0wLaQhm3rv+zbVR4ah1orAPlFkti3R3m193qHDALvcycWmQNrtpIY47quNYZIsYCOeafhwkKhrclTiN5gx/HXjCjwSCO4sI2FQuTrAv97QL791H3awcmRedwXWjee/23foycfdPgK8bQt/FBjLeWX4wpWPYLa1OB7Oo9+qgpJzdVqB7rKCoo5BuhNhS3Qyxx33duIS01quntpSIjPBEYt/kufUeelpqmuAnXet4HvAtsq+rX2DWDOOdrhFQrjbHR7a4LtfeGv8jLqSMYnX39gKjOL5sI8CYflpaoFCtrsnw8D3oJED2XAS6j5JAghubpZODQK1+B/pUIrIQBac24y4CZCpGMdXwaYlOiVBZhRiZzaxrEM5q0jthrUEa0gbL5LexjXajSd9b+q0+ZyOzBcPGSRuMj5eRmHVXY= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: b45de280-eca6-471d-123d-08d742e8db3c X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Sep 2019 01:20:17.3647 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gyZV4f45O8OHhD5Hv9wCK1JfIKqq/bNH/PHhM57/VEO34WmBkUOC1Cl5xTCdVXHtArGjTlIO47CkBkG9wqaL4A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0402MB3753 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org SGksIExlb25hcmQNCg0KPiBPbiAyMDE5LTA5LTI2IDE6MDYgUE0sIE1hcmNvIEZlbHNjaCB3cm90 ZToNCj4gPiBPbiAxOS0wOS0yNiAwODowMywgQW5zb24gSHVhbmcgd3JvdGU6DQo+ID4+PiBPbiAx OS0wOS0yNSAxODowNywgQW5zb24gSHVhbmcgd3JvdGU6DQo+ID4+Pj4gVGhlIFNDVSBmaXJtd2Fy ZSBkb2VzIE5PVCBhbHdheXMgaGF2ZSByZXR1cm4gdmFsdWUgc3RvcmVkIGluDQo+ID4+Pj4gbWVz c2FnZSBoZWFkZXIncyBmdW5jdGlvbiBlbGVtZW50IGV2ZW4gdGhlIEFQSSBoYXMgcmVzcG9uc2Ug ZGF0YSwNCj4gPj4+PiB0aG9zZSBzcGVjaWFsIEFQSXMgYXJlIGRlZmluZWQgYXMgdm9pZCBmdW5j dGlvbiBpbiBTQ1UgZmlybXdhcmUsIHNvDQo+ID4+Pj4gdGhleSBzaG91bGQgYmUgdHJlYXRlZCBh cyByZXR1cm4gc3VjY2VzcyBhbHdheXMuDQo+ID4+Pj4NCj4gPj4+PiArc3RhdGljIGNvbnN0IHN0 cnVjdCBpbXhfc2NfcnBjX21zZyB3aGl0ZWxpc3RbXSA9IHsNCj4gPj4+PiArCXsgLnN2YyA9IElN WF9TQ19SUENfU1ZDX01JU0MsIC5mdW5jID0NCj4gPj4+IElNWF9TQ19NSVNDX0ZVTkNfVU5JUVVF X0lEIH0sDQo+ID4+Pj4gKwl7IC5zdmMgPSBJTVhfU0NfUlBDX1NWQ19NSVNDLCAuZnVuYyA9DQo+ ID4+Pj4gK0lNWF9TQ19NSVNDX0ZVTkNfR0VUX0JVVFRPTl9TVEFUVVMgfSwgfTsNCj4gPj4+DQo+ ID4+PiBJcyB0aGlzIGdvaW5nIHRvIGJlIGV4dGVuZGVkIGluIHRoZSBuZWFyIGZ1dHVyZT8gSSBz ZWUgc29tZSB1cGNvbWluZw0KPiA+Pj4gcHJvYmxlbXMgaGVyZSBpZiBzb21lb25lIHVzZXMgYSBk aWZmZXJlbnQgc2N1LWZ3PC0+a2VybmVsDQo+ID4+PiBjb21iaW5hdGlvbiBhcyBueHAgd291bGQg c3VnZ2VzdC4NCj4gPj4NCj4gPj4gQ291bGQgYmUsIGJ1dCBJIGNoZWNrZWQgdGhlIGN1cnJlbnQg QVBJcywgT05MWSB0aGVzZSAyIHdpbGwgYmUgdXNlZA0KPiA+PiBpbiBMaW51eCBrZXJuZWwsIHNv IEkgT05MWSBhZGQgdGhlc2UgMiBBUElzIGZvciBub3cuDQo+ID4NCj4gPiBPa2F5Lg0KPiA+DQo+ ID4+IEhvd2V2ZXIsIGFmdGVyIHJldGhpbmssIG1heWJlIHdlIHNob3VsZCBhZGQgYW5vdGhlciBp bXhfc2NfcnBjIEFQSQ0KPiA+PiBmb3IgdGhvc2Ugc3BlY2lhbCBBUElzPyBUbyBhdm9pZCBjaGVj a2luZyBpdCBmb3IgYWxsIHRoZSBBUElzIGNhbGxlZCB3aGljaA0KPiBtYXkgaW1wYWN0IHNvbWUg cGVyZm9ybWFuY2UuDQo+ID4+IFN0aWxsIHVuZGVyIGRpc2N1c3Npb24sIGlmIHlvdSBoYXZlIGJl dHRlciBpZGVhLCBwbGVhc2UgYWR2aXNlLCB0aGFua3MhDQo+IA0KPiBNeSBzdWdnZXN0aW9uIGlz IHRvIHJlZmFjdG9yIHRoZSBjb2RlIGFuZCBhZGQgYSBuZXcgQVBJIGZvciB0aGUgdGhpcyAibm8N Cj4gZXJyb3IgdmFsdWUiIGNvbnZlbnRpb24uIEludGVybmFsbHkgdGhleSBjYW4gY2FsbCBhIGNv bW1vbiBmdW5jdGlvbiB3aXRoDQo+IGZsYWdzLg0KDQpJZiBJIHVuZGVyc3RhbmQgeW91ciBwb2lu dCBjb3JyZWN0bHksIHRoYXQgbWVhbnMgdGhlIGxvb3AgY2hlY2sgb2Ygd2hldGhlciB0aGUgQVBJ DQppcyB3aXRoICJubyBlcnJvciB2YWx1ZSIgZm9yIGV2ZXJ5IEFQSSBzdGlsbCBOT1QgYmUgc2tp cHBlZCwgaXQgaXMganVzdCByZWZhY3RvcmluZyB0aGUgY29kZSwNCnJpZ2h0Pw0KDQo+IA0KPiA+ IEFkZGluZyBhIHNwZWNpYWwgYXBpIHNob3VsZG4ndCBiZSB0aGUgcmlnaHQgZml4LiBJbWFnaW5l IGlmIHNvbWVvbmUNCj4gPiAobm90IGEgbnhwLWRldmVsb3Blcikgd2FudHMgdG8gYWRkIGEgbmV3 IGRyaXZlci4gSG93IGNvdWxkIGhlIGJlDQo+ID4gZXhwZWN0ZWQgdG8ga25vdyB3aGljaCBhcGkg aGUgc2hvdWxkIHVzZS4gVGhlIGJldHRlciBhYmJyb2FjaCB3b3VsZCBiZQ0KPiA+IHRvIGZpeCB0 aGUgc2N1LWZ3IGluc3RlYWQgb2YgYWRkaW5nIHF1aXJrcy4uDQoNClllcywgZml4aW5nIFNDVSBG VyBpcyB0aGUgYmVzdCBzb2x1dGlvbiwgYnV0IHdlIGhhdmUgdGFsa2VkIHRvIFNDVSBGVyBvd25l ciwgdGhlIFNDVQ0KRlcgcmVsZWFzZWQgaGFzIGJlZW4gZmluYWxpemVkLCBzbyB0aGUgQVBJIGlt cGxlbWVudGF0aW9uIGNhbiBOT1QgYmUgY2hhbmdlZCwgYnV0DQp0aGV5IHdpbGwgcGF5IGF0dGVu dGlvbiB0byB0aGlzIGlzc3VlIGZvciBuZXcgYWRkZWQgQVBJcyBsYXRlci4gVGhhdCBtZWFucyB0 aGUgbnVtYmVyDQpvZiBBUElzIGhhdmluZyB0aGlzIGlzc3VlIGEgdmVyeSBsaW1pdGVkLiANCg0K PiANCj4gUmlnaHQgbm93IGRldmVsb3BlcnMgd2hvIHdhbnQgdG8gbWFrZSBTQ0ZXIGNhbGxzIGlu IHVwc3RyZWFtIG5lZWQgdG8NCj4gZGVmaW5lIHRoZSBtZXNzYWdlIHN0cnVjdCBpbiB0aGVpciBk cml2ZXIgYmFzZWQgb24gcHJvdG9jb2wgZG9jdW1lbnRhdGlvbi4NCj4gVGhpcyBpbmNsdWRlczoN Cj4gDQo+ICogQmluYXJ5IGxheW91dCBvZiB0aGUgbWVzc2FnZSAoYSBwYWNrZWQgc3RydWN0KQ0K PiAqIElmIHRoZSBtZXNzYWdlIGhhcyBhIHJlc3BvbnNlIChhbHJlYWR5IGEgYm9vbCBmbGFnKQ0K PiAqIElmIGFuIGVycm9yIGNvZGUgaXMgcmV0dXJuZWQgKHRoaXMgcGF0Y2ggYWRkcyBzdXBwb3J0 IGZvciBpdCkNCj4gDQo+IFNpbmNlIGNhbGxlcnMgYXJlIGFscmVhZHkgZXhwb3NlZCB0byB0aGUg YmluYXJ5IHByb3RvY29sIGV4cG9zaW5nIHRoZW0gdG8NCj4gbWlub3IgcXVpcmtzIG9mIHRoZSBj YWxsaW5nIGNvbnZlbnRpb24gYWxzbyBzZWVtcyByZWFzb25hYmxlLiBIYXZpbmcgdGhlDQo+IGxv dy1sZXZlbCBJUEMgY29kZSBwZWVrIGF0IG1lc3NhZ2UgSURzIHNlZW1zIGxpa2UgYSBoYWNrOyB0 aGlzIGJlbG9uZyBhdCBhDQo+IHNsaWdodGx5IGhpZ2hlciBsZXZlbC4NCg0KQSBsaXR0bGUgY29u ZnVzZWQsIHNvIHdoYXQgeW91IHN1Z2dlc3RlZCBpcyB0byBhZGQgbWFrZSB0aGUgaW14X3NjdV9j YWxsX3JwYygpDQpiZWNvbWVzIHRoZSAic2xpZ2h0bHkgaGlnaGVyIGxldmVsIiBBUEksIHRoZW4g aW4gdGhpcyBBUEksIGNoZWNrIHRoZSBtZXNzYWdlIElEcw0KdG8gZGVjaWRlIHdoZXRoZXIgdG8g cmV0dXJuIGVycm9yIHZhbHVlLCB0aGVuIGNhbGxzIGEgbmV3IEFQSSB3aGljaCB3aWxsIGhhdmUN CnRoZSBsb3ctbGV2ZWwgSVBDIGNvZGUsIHRoZSB0aGlzIG5ldyBBUEkgd2lsbCBoYXZlIGEgZmxh ZyBwYXNzZWQgZnJvbSBpbXhfc2N1X2NhbGxfcnBjKCkNCmZ1bmN0aW9uLCBhbSBJIHJpZ2h0Pw0K DQpBbnNvbg0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBA55C4360C for ; Fri, 27 Sep 2019 01:20:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ADB7120835 for ; Fri, 27 Sep 2019 01:20:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="l7mT6gOp"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="gzWVkz8A" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ADB7120835 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7IBfrGmr16e8tZLnRHAlGZEBQMk3jnysigjSYNkJwRE=; b=l7mT6gOpD7V9Ym ZkN8p6hv8CdX3L2F+OjvpfjxBjyqtSPPiRVE4ugv529LIfF9RPVswmF6EUtQ9c1b9FBHmiGW7NOgx rLAC3jM4wBcyshlRsJz/iZNVL1PIakgQ4kEr9uK3HOTcyPn3EUQOMeJlqKgDFYPrXvvmP2OQgVc8T 7f2E666liFwkmEfvL4lfo2E2tMOmI925/xlX2uWd2OolxE6w0Pz28/ILyXKPTSRyQ7p6lbPvBwiaE aNw7quHMMdvUJWPFZH6Gy5rExs4KACGQhRRUT/LlTsdFxXgASjT8t6d0meVhNfKJUMkvVCWwpi063 WioW3t3nl1shFO45sjgQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iDevq-0007y7-UU; Fri, 27 Sep 2019 01:20:26 +0000 Received: from mail-eopbgr140075.outbound.protection.outlook.com ([40.107.14.75] helo=EUR01-VE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iDevn-0007xL-CA for linux-arm-kernel@lists.infradead.org; Fri, 27 Sep 2019 01:20:25 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ql7VdHwyOn3rQse9E8HBpOy7nAH4n4Go2jDSqYuI7qqIMEQFbZL7nbjgjpBiZLwdQiJkt8I+Qe0U41QIXSIxbJ2gkNsaFz4ln9Ze1+X/oYbA++eDpv0xmhNwOszvKB332PFvUyDZ0fL5DMpmsHA3ucHYJAIc5MF2Hv4XHhY3+o7YD5oNaQkZxrr8vIoesSqj9VBzO/mJjZtqyxtrxnMLDjDg20TgmM9MXfNC2P5OTwK8uXLke6i5CAFrzIlCc9oBNbUpqExBK3iRhX8uFjhyJM+JWWPJX/zWJQcNS4NwdEixDHQX+Cy0XFEfYelSn+P2thnUpQdFqXFwwFwiAjA3XA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JXmBSpXUKHDu0Em+Dia+VEzOiwGY0ytRP9L24v+/Z1Q=; b=YSKZqKLukNo9+p0L3aLdpYCyibbJjYORZWiGa6hS394lhEQPaMQzF7sGUqZ+9VxEIctVNkgUqnqbJEcYpcFbq0X2GF6jlEqb8sMIOAC5j40VQakOEcNJ0K8QZ7N3Q4mcOYqzZckgaROYxnORrO5G626LP+cUFcPTMawGYzdxzMeOKeFsjkC7XLqX1LM6RxkwefoWXEPXXqxb/LOafnm+wzgdiltFHmK9EDgP812spDofXg3ub50O6bA9gKeUMcfhnHo8f5dctJ+Gso2dbtSeaWou5qeUsk5C+xqB1sHLVEDR7+Vz1ThxR1Jl1tVHcGTIPusSIcj5EoK6r0OLCD8MxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JXmBSpXUKHDu0Em+Dia+VEzOiwGY0ytRP9L24v+/Z1Q=; b=gzWVkz8A6bR5w4xzjSstCntuCMllNGuJiyucWIrtY4/0JAqN5EjqNNwRv4wOYUb6zOBrcmhEhUmnpXCktCQq0xEaj7t9oCqSpPJYi7q7wCQGWQ/8xdyZJGhQw0ymm8gNKrjewLwvmweF/L6WuT+T6k/KMMRJ6UCKTX8CZoo6ayY= Received: from DB3PR0402MB3916.eurprd04.prod.outlook.com (52.134.72.18) by DB3PR0402MB3753.eurprd04.prod.outlook.com (52.134.71.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2284.21; Fri, 27 Sep 2019 01:20:17 +0000 Received: from DB3PR0402MB3916.eurprd04.prod.outlook.com ([fe80::8958:299c:bc54:2a38]) by DB3PR0402MB3916.eurprd04.prod.outlook.com ([fe80::8958:299c:bc54:2a38%7]) with mapi id 15.20.2284.028; Fri, 27 Sep 2019 01:20:17 +0000 From: Anson Huang To: Leonard Crestez , Marco Felsch , Aisheng Dong Subject: RE: [PATCH] firmware: imx: Skip return value check for some special SCU firmware APIs Thread-Topic: [PATCH] firmware: imx: Skip return value check for some special SCU firmware APIs Thread-Index: AQHVc4lT/ErvPybCJUCbZ2x7mLGjsqc+tdHg Date: Fri, 27 Sep 2019 01:20:17 +0000 Message-ID: References: <1569406066-16626-1-git-send-email-Anson.Huang@nxp.com> <20190926075914.i7tsd3cbpitrqe4q@pengutronix.de> <20190926100558.egils3ds37m3s5wo@pengutronix.de> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=anson.huang@nxp.com; x-originating-ip: [119.31.174.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b45de280-eca6-471d-123d-08d742e8db3c x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600167)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:DB3PR0402MB3753; x-ms-traffictypediagnostic: DB3PR0402MB3753:|DB3PR0402MB3753: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0173C6D4D5 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(366004)(39860400002)(396003)(136003)(376002)(199004)(189003)(6636002)(229853002)(476003)(26005)(55016002)(6246003)(71200400001)(74316002)(66556008)(64756008)(102836004)(2906002)(66476007)(71190400001)(316002)(186003)(8676002)(25786009)(9686003)(81156014)(66066001)(81166006)(99286004)(7696005)(76176011)(486006)(66446008)(44832011)(54906003)(446003)(7736002)(110136005)(33656002)(4326008)(8936002)(478600001)(52536014)(6436002)(305945005)(256004)(53546011)(5660300002)(6116002)(66946007)(11346002)(3846002)(6506007)(14454004)(76116006)(86362001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0402MB3753; H:DB3PR0402MB3916.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 0ADiU2w0wLaQhm3rv+zbVR4ah1orAPlFkti3R3m193qHDALvcycWmQNrtpIY47quNYZIsYCOeafhwkKhrclTiN5gx/HXjCjwSCO4sI2FQuTrAv97QL791H3awcmRedwXWjee/23foycfdPgK8bQt/FBjLeWX4wpWPYLa1OB7Oo9+qgpJzdVqB7rKCoo5BuhNhS3Qyxx33duIS01quntpSIjPBEYt/kufUeelpqmuAnXet4HvAtsq+rX2DWDOOdrhFQrjbHR7a4LtfeGv8jLqSMYnX39gKjOL5sI8CYflpaoFCtrsnw8D3oJED2XAS6j5JAghubpZODQK1+B/pUIrIQBac24y4CZCpGMdXwaYlOiVBZhRiZzaxrEM5q0jthrUEa0gbL5LexjXajSd9b+q0+ZyOzBcPGSRuMj5eRmHVXY= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: b45de280-eca6-471d-123d-08d742e8db3c X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Sep 2019 01:20:17.3647 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gyZV4f45O8OHhD5Hv9wCK1JfIKqq/bNH/PHhM57/VEO34WmBkUOC1Cl5xTCdVXHtArGjTlIO47CkBkG9wqaL4A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0402MB3753 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190926_182023_620330_ABCA0A49 X-CRM114-Status: GOOD ( 24.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "linux-kernel@vger.kernel.org" , dl-linux-imx , "kernel@pengutronix.de" , "festevam@gmail.com" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Leonard > On 2019-09-26 1:06 PM, Marco Felsch wrote: > > On 19-09-26 08:03, Anson Huang wrote: > >>> On 19-09-25 18:07, Anson Huang wrote: > >>>> The SCU firmware does NOT always have return value stored in > >>>> message header's function element even the API has response data, > >>>> those special APIs are defined as void function in SCU firmware, so > >>>> they should be treated as return success always. > >>>> > >>>> +static const struct imx_sc_rpc_msg whitelist[] = { > >>>> + { .svc = IMX_SC_RPC_SVC_MISC, .func = > >>> IMX_SC_MISC_FUNC_UNIQUE_ID }, > >>>> + { .svc = IMX_SC_RPC_SVC_MISC, .func = > >>>> +IMX_SC_MISC_FUNC_GET_BUTTON_STATUS }, }; > >>> > >>> Is this going to be extended in the near future? I see some upcoming > >>> problems here if someone uses a different scu-fw<->kernel > >>> combination as nxp would suggest. > >> > >> Could be, but I checked the current APIs, ONLY these 2 will be used > >> in Linux kernel, so I ONLY add these 2 APIs for now. > > > > Okay. > > > >> However, after rethink, maybe we should add another imx_sc_rpc API > >> for those special APIs? To avoid checking it for all the APIs called which > may impact some performance. > >> Still under discussion, if you have better idea, please advise, thanks! > > My suggestion is to refactor the code and add a new API for the this "no > error value" convention. Internally they can call a common function with > flags. If I understand your point correctly, that means the loop check of whether the API is with "no error value" for every API still NOT be skipped, it is just refactoring the code, right? > > > Adding a special api shouldn't be the right fix. Imagine if someone > > (not a nxp-developer) wants to add a new driver. How could he be > > expected to know which api he should use. The better abbroach would be > > to fix the scu-fw instead of adding quirks.. Yes, fixing SCU FW is the best solution, but we have talked to SCU FW owner, the SCU FW released has been finalized, so the API implementation can NOT be changed, but they will pay attention to this issue for new added APIs later. That means the number of APIs having this issue a very limited. > > Right now developers who want to make SCFW calls in upstream need to > define the message struct in their driver based on protocol documentation. > This includes: > > * Binary layout of the message (a packed struct) > * If the message has a response (already a bool flag) > * If an error code is returned (this patch adds support for it) > > Since callers are already exposed to the binary protocol exposing them to > minor quirks of the calling convention also seems reasonable. Having the > low-level IPC code peek at message IDs seems like a hack; this belong at a > slightly higher level. A little confused, so what you suggested is to add make the imx_scu_call_rpc() becomes the "slightly higher level" API, then in this API, check the message IDs to decide whether to return error value, then calls a new API which will have the low-level IPC code, the this new API will have a flag passed from imx_scu_call_rpc() function, am I right? Anson _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel