From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Xueming(Steven) Li" <xuemingl@mellanox.com>
Subject: Re: [PATCH v2 1/2] eal/malloc: fix RTE malloc debug macro
Date: Sat, 9 Sep 2017 07:33:09 +0000
Message-ID: <DB3PR05MB2977125DD080F84AF186BADAC6A0@DB3PR05MB297.eurprd05.prod.outlook.com>
References: <20170823022926.169272-1-xuemingl@mellanox.com>
 <20170908145055.50280-1-xuemingl@mellanox.com>
 <20170908090351.457fe42c@xeon-e3>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <dev-bounces@dpdk.org>
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-eopbgr00062.outbound.protection.outlook.com [40.107.0.62])
 by dpdk.org (Postfix) with ESMTP id ACEEF5905
 for <dev@dpdk.org>; Sat,  9 Sep 2017 09:33:12 +0200 (CEST)
In-Reply-To: <20170908090351.457fe42c@xeon-e3>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Thanks, updated in v3.

> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Saturday, September 9, 2017 12:04 AM
> To: Xueming(Steven) Li <xuemingl@mellanox.com>
> Cc: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>;
> dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 1/2] eal/malloc: fix RTE malloc debug m=
acro
>=20
> On Fri,  8 Sep 2017 22:50:54 +0800
> Xueming Li <xuemingl@mellanox.com> wrote:
>=20
> > -				printf("rte_zmalloc didn't zero"
> > +				printf("rte_zmalloc didn't zero "
> >  				       "the allocated memory\n");
>=20
> Please don't break error messages onto two lines.
> It makes it harder to use tools like grep and google searches to find whe=
re
> message is located.
>=20
> Checkpatch and other tools make an exception for long lines in quoted str=
ings.