From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752357AbbFVOxB (ORCPT ); Mon, 22 Jun 2015 10:53:01 -0400 Received: from mail-am1on0098.outbound.protection.outlook.com ([157.56.112.98]:21920 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751183AbbFVOww convert rfc822-to-8bit (ORCPT ); Mon, 22 Jun 2015 10:52:52 -0400 From: Noam Camus To: David Miller CC: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Alexey.Brodkin@synopsys.com" , "vgupta@synopsys.com" , Gilad Ben Yossef , Chris Metcalf , Tal Zilcer Subject: RE: [PATCH v5] NET: Add ezchip ethernet driver Thread-Topic: [PATCH v5] NET: Add ezchip ethernet driver Thread-Index: AQHQqEG9aWsxNYjK3UG7C4uXMyhBdZ23LF4AgAFwaDA= Date: Mon, 22 Jun 2015 14:52:48 +0000 Message-ID: References: <1434263193-16877-1-git-send-email-noamc@ezchip.com> <1434465342-7412-1-git-send-email-noamc@ezchip.com> <20150621.092218.2158342160706463595.davem@davemloft.net> In-Reply-To: <20150621.092218.2158342160706463595.davem@davemloft.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: davemloft.net; dkim=none (message not signed) header.d=none; x-originating-ip: [212.179.42.66] x-microsoft-exchange-diagnostics: 1;DB4PR02MB0431;5:QbBP24deAMNbgVG3+OHXfqq8VBLsruLScgYm5O/L/4gxUVbilx1YuBeSNsed5uabUfpmkjV7lrf/Y3yfIECS8oNIHCSYl97DhhnD+gKE1/o4Qx80tedani8XCNXYSgR3LHLyVrY/L1mkhqpS4bE1Fg==;24:bREgqLOAj3TiVrrGHwxLgMNTpW+OAkK9I8p3wNeyPB9ge6Igu2M5pH/D8EveuI//1qAz6nnwByZYF80K9Jk6EFjv9sswDpFZULe5FrvFDto=;20:aLZkZ8C4pnsK3yL1uzcbUfb5J8FiL7EkxmpTJlwtbbFOmjG3fBl3ibTJShpRx1F4PoC1PPoeHKoyhFlChOL5Og== x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB4PR02MB0431; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:DB4PR02MB0431;BCL:0;PCL:0;RULEID:;SRVR:DB4PR02MB0431; x-forefront-prvs: 06157D541C x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(377454003)(51704005)(102836002)(33656002)(50986999)(66066001)(40100003)(54356999)(77096005)(87936001)(2656002)(19580395003)(86362001)(19580405001)(74316001)(106116001)(5001920100001)(92566002)(5002640100001)(189998001)(110136002)(107886002)(5001960100002)(62966003)(77156002)(76576001)(46102003)(2950100001)(76176999)(2900100001)(5003600100002)(4001430100001);DIR:OUT;SFP:1101;SCL:1;SRVR:DB4PR02MB0431;H:DB4PR02MB272.eurprd02.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; Content-Type: text/plain; charset="iso-8859-7" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: ezchip.com X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jun 2015 14:52:48.7367 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 0fc16e0a-3cd3-4092-8b2f-0a42cff122c3 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR02MB0431 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: David Miller [mailto:davem@davemloft.net] Sent: Sunday, June 21, 2015 7:22 PM > This builds with several warnings and also doesn't compile. > > drivers/net/ethernet/ezchip/nps_enet.c: In function ¡nps_enet_read_rx_fifo¢: > drivers/net/ethernet/ezchip/nps_enet.c:43:24: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] > drivers/net/ethernet/ezchip/nps_enet.c:43:24: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] > drivers/net/ethernet/ezchip/nps_enet.c: In function ¡nps_enet_send_frame¢: > drivers/net/ethernet/ezchip/nps_enet.c:366:24: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] > drivers/net/ethernet/ezchip/nps_enet.c:366:24: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] Once I start to use newer GCC (5.1.1) I get those as well. My previous GCC (4.8) did not report them. > drivers/net/ethernet/ezchip/nps_enet.c: In function ¡nps_enet_poll_controller¢: > drivers/net/ethernet/ezchip/nps_enet.c:535:2: error: implicit declaration of function ¡nps_enet_board_irq_handler¢ [-Werror=implicit-function-declaration] cc1: some warnings being treated as errors My configuration lacked the CONFIG_NET_POLL_CONTROLLER this is why I missed this typo caused due to renaming. I added CONFIG_NETCONSOLE to my configuration, now GCC report this error as well. > I do not even see where npe_enet_board_irq_handler could possible be defined. It was renamed: nps_enet_board_irq_handler -> nps_enet_irq_handler (I removed the _board). > It is quite infuriating to receive a patch like this which is claimed to be complete and ready to be applied to my tree, yet it is very clearly not. My sincerest apologies for any problem I have made. I will send another version that will be worth applying to your tree. Noam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/ From mboxrd@z Thu Jan 1 00:00:00 1970 From: Noam Camus Subject: RE: [PATCH v5] NET: Add ezchip ethernet driver Date: Mon, 22 Jun 2015 14:52:48 +0000 Message-ID: References: <1434263193-16877-1-git-send-email-noamc@ezchip.com> <1434465342-7412-1-git-send-email-noamc@ezchip.com> <20150621.092218.2158342160706463595.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-7 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Alexey.Brodkin@synopsys.com" , "vgupta@synopsys.com" , Gilad Ben Yossef , Chris Metcalf , Tal Zilcer To: David Miller Return-path: Received: from mail-am1on0098.outbound.protection.outlook.com ([157.56.112.98]:21920 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751183AbbFVOww convert rfc822-to-8bit (ORCPT ); Mon, 22 Jun 2015 10:52:52 -0400 In-Reply-To: <20150621.092218.2158342160706463595.davem@davemloft.net> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: =46rom: David Miller [mailto:davem@davemloft.net]=20 Sent: Sunday, June 21, 2015 7:22 PM > This builds with several warnings and also doesn't compile. > > drivers/net/ethernet/ezchip/nps_enet.c: In function =A1nps_enet_read_= rx_fifo=A2: > drivers/net/ethernet/ezchip/nps_enet.c:43:24: warning: cast from poin= ter to integer of different size [-Wpointer-to-int-cast] > drivers/net/ethernet/ezchip/nps_enet.c:43:24: warning: cast from poin= ter to integer of different size [-Wpointer-to-int-cast] > drivers/net/ethernet/ezchip/nps_enet.c: In function =A1nps_enet_send_= frame=A2: > drivers/net/ethernet/ezchip/nps_enet.c:366:24: warning: cast from poi= nter to integer of different size [-Wpointer-to-int-cast] > drivers/net/ethernet/ezchip/nps_enet.c:366:24: warning: cast from poi= nter to integer of different size [-Wpointer-to-int-cast] Once I start to use newer GCC (5.1.1) I get those as well. My previous = GCC (4.8) did not report them. > drivers/net/ethernet/ezchip/nps_enet.c: In function =A1nps_enet_poll_= controller=A2: > drivers/net/ethernet/ezchip/nps_enet.c:535:2: error: implicit declara= tion of function =A1nps_enet_board_irq_handler=A2 [-Werror=3Dimplicit-f= unction-declaration] cc1: some warnings being treated as errors My configuration lacked the CONFIG_NET_POLL_CONTROLLER this is why I mi= ssed this typo caused due to renaming. I added CONFIG_NETCONSOLE to my = configuration, now GCC report this error as well. > I do not even see where npe_enet_board_irq_handler could possible be = defined. It was renamed: nps_enet_board_irq_handler -> nps_enet_irq_handler (I r= emoved the _board). > It is quite infuriating to receive a patch like this which is claimed= to be complete and ready to be applied to my tree, yet it is very clea= rly not. My sincerest apologies for any problem I have made. I will send anothe= r version that will be worth applying to your tree. Noam