From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753450AbbFWGFp (ORCPT ); Tue, 23 Jun 2015 02:05:45 -0400 Received: from mail-am1on0066.outbound.protection.outlook.com ([157.56.112.66]:64532 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751476AbbFWGFg (ORCPT ); Tue, 23 Jun 2015 02:05:36 -0400 From: Noam Camus To: Mahesh Bandewar CC: linux-netdev , "linux-kernel@vger.kernel.org" , "Alexey.Brodkin@synopsys.com" , "vgupta@synopsys.com" , Gilad Ben Yossef , Chris Metcalf , Tal Zilcer Subject: RE: [PATCH v5] NET: Add ezchip ethernet driver Thread-Topic: [PATCH v5] NET: Add ezchip ethernet driver Thread-Index: AQHQqEG9aWsxNYjK3UG7C4uXMyhBdZ241eCAgADNTPA= Date: Tue, 23 Jun 2015 06:05:32 +0000 Message-ID: References: <1434263193-16877-1-git-send-email-noamc@ezchip.com> <1434465342-7412-1-git-send-email-noamc@ezchip.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: google.com; dkim=none (message not signed) header.d=none; x-originating-ip: [212.179.42.66] x-microsoft-exchange-diagnostics: 1;DB4PR02MB0430;5:Lx2nPwqSp5MAliZYNICVkTLp5Mls602q2J60TeVJwHG9vNwVHpIMTlCeoxlZ6DOUVLTmCsUf5y7Vhh4QWHH1PE3imB5YzCZXL5USjMXRm+1zssgcdPBF6ZN3XQluEKkHeBQVTnTwlo4PThKX/hxrug==;24:Cd3fLmCq1PUpqLQpSmSupW31y2rs23kYNhzYyay3DA68yei2JNOsqJSZn6KrqJdxcFzvEqvMV+4AgHKLpf8eoFoAMTdkNFr1615cWVY0C/s=;20:kzw3Z/3sP3yK0QYM5trzkbt3vX2WGLf5UFC3njkElBtzGJs8BkK5DAznJRy2p5HAQjopPjdsctvfa4Zz0cny/g== x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB4PR02MB0430; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:DB4PR02MB0430;BCL:0;PCL:0;RULEID:;SRVR:DB4PR02MB0430; x-forefront-prvs: 06167FAD59 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(51704005)(377454003)(46102003)(76576001)(102836002)(77096005)(62966003)(74316001)(122556002)(2950100001)(77156002)(189998001)(92566002)(106116001)(2900100001)(5003600100002)(40100003)(54356999)(5001960100002)(107886002)(110136002)(5002640100001)(2656002)(66066001)(33656002)(86362001)(19580405001)(19580395003)(50986999)(87936001)(76176999)(4001430100001);DIR:OUT;SFP:1101;SCL:1;SRVR:DB4PR02MB0430;H:DB4PR02MB272.eurprd02.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: ezchip.com X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jun 2015 06:05:32.8153 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 0fc16e0a-3cd3-4092-8b2f-0a42cff122c3 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR02MB0430 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id t5N65n18008906 From: Mahesh Bandewar [mailto:maheshb@google.com] Sent: Monday, June 22, 2015 8:45 PM > > a/drivers/net/ethernet/ezchip/Kconfig > > b/drivers/net/ethernet/ezchip/Kconfig > > new file mode 100644 > > index 0000000..d031177 > > --- /dev/null > > +++ b/drivers/net/ethernet/ezchip/Kconfig > > @@ -0,0 +1,27 @@ > > +# > > +# EZchip network device configuration # > > + > > +config NET_VENDOR_EZCHIP > > + bool "EZchip devices" > > + default y > > > Why this has to be included in the default build? Shouldn't it be either "m" or "N" by default? >>From what I see this is the common practice for all Ethernet devices. Noam {.n++%ݶw{.n+{Gsy杶ii From mboxrd@z Thu Jan 1 00:00:00 1970 From: Noam Camus Subject: RE: [PATCH v5] NET: Add ezchip ethernet driver Date: Tue, 23 Jun 2015 06:05:32 +0000 Message-ID: References: <1434263193-16877-1-git-send-email-noamc@ezchip.com> <1434465342-7412-1-git-send-email-noamc@ezchip.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: linux-netdev , "linux-kernel@vger.kernel.org" , "Alexey.Brodkin@synopsys.com" , "vgupta@synopsys.com" , Gilad Ben Yossef , Chris Metcalf , Tal Zilcer To: Mahesh Bandewar Return-path: Received: from mail-am1on0066.outbound.protection.outlook.com ([157.56.112.66]:64532 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751476AbbFWGFg (ORCPT ); Tue, 23 Jun 2015 02:05:36 -0400 In-Reply-To: Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: RnJvbTogTWFoZXNoIEJhbmRld2FyIFttYWlsdG86bWFoZXNoYkBnb29nbGUuY29tXSANClNlbnQ6 IE1vbmRheSwgSnVuZSAyMiwgMjAxNSA4OjQ1IFBNDQoNCj4gPiBhL2RyaXZlcnMvbmV0L2V0aGVy bmV0L2V6Y2hpcC9LY29uZmlnIA0KPiA+IGIvZHJpdmVycy9uZXQvZXRoZXJuZXQvZXpjaGlwL0tj b25maWcNCj4gPiBuZXcgZmlsZSBtb2RlIDEwMDY0NA0KPiA+IGluZGV4IDAwMDAwMDAuLmQwMzEx NzcNCj4gPiAtLS0gL2Rldi9udWxsDQo+ID4gKysrIGIvZHJpdmVycy9uZXQvZXRoZXJuZXQvZXpj aGlwL0tjb25maWcNCj4gPiBAQCAtMCwwICsxLDI3IEBADQo+ID4gKyMNCj4gPiArIyBFWmNoaXAg bmV0d29yayBkZXZpY2UgY29uZmlndXJhdGlvbiAjDQo+ID4gKw0KPiA+ICtjb25maWcgTkVUX1ZF TkRPUl9FWkNISVANCj4gPiArICAgICAgIGJvb2wgIkVaY2hpcCBkZXZpY2VzIg0KPiA+ICsgICAg ICAgZGVmYXVsdCB5DQo+ID4NCj4gV2h5IHRoaXMgaGFzIHRvIGJlIGluY2x1ZGVkIGluIHRoZSBk ZWZhdWx0IGJ1aWxkPyBTaG91bGRuJ3QgaXQgYmUgZWl0aGVyICJtIiBvciAiTiIgYnkgZGVmYXVs dD8NCg0KRnJvbSB3aGF0IEkgc2VlIHRoaXMgaXMgdGhlIGNvbW1vbiBwcmFjdGljZSBmb3IgYWxs IEV0aGVybmV0IGRldmljZXMuDQoNCk5vYW0NCg==