From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liming Sun Subject: Re: [PATCH v2 1/3] driver/net/mpipe: support native build on tilegx platform. Date: Tue, 9 Feb 2016 18:37:41 +0000 Message-ID: References: <1450193851-9100-4-git-send-email-lsun@ezchip.com> <1452263438-21634-1-git-send-email-lsun@ezchip.com> <1642628.fgbdceb2p5@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" To: Thomas Monjalon Return-path: Received: from emea01-db3-obe.outbound.protection.outlook.com (mail-db3on0077.outbound.protection.outlook.com [157.55.234.77]) by dpdk.org (Postfix) with ESMTP id 3F63D2C72 for ; Tue, 9 Feb 2016 19:37:43 +0100 (CET) In-Reply-To: <1642628.fgbdceb2p5@xps13> Content-Language: en-US List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Thanks Thomas for the comments. Please see the response inline. Thanks, Liming -----Original Message----- From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]=20 Sent: Tuesday, February 09, 2016 11:16 AM To: Liming Sun Cc: dev@dpdk.org; bruce.richardson@intel.com Subject: Re: [dpdk-dev] [PATCH v2 1/3] driver/net/mpipe: support native bui= ld on tilegx platform. Hi, Sorry for being late for commenting. 2016-01-08 09:30, Liming Sun: > -EZchip TILE-Gx > +EZchip TILE-Gx/Mx A comment about the TILE-Mx would be welcome. Is it supported currently? Isn't it an ARM arch? [lsun] Yes, it's ARM arch, but with similar mpipe driver. It's not fully supported yet. I'll remove this change and add it in a diffe= rent serie when it's ready. > M: Zhigang Lu > +M: Liming Sun > F: lib/librte_eal/common/include/arch/tile/ > F: drivers/net/mpipe/ [...] > +# Compile combined lib by default. > +CONFIG_RTE_BUILD_COMBINE_LIBS=3Dy Why forcing this option in the defconfig file? [lsun] It's just trying to make it handy for other applications like OVS or= ODP on top of DPDK. However we could remove this change if it's not the re= commended way. [...] > ARCH ?=3D tile > + > +HOST_ARCH :=3D ${shell uname -m} > +ifneq ($(filter tile%,${HOST_ARCH}),) CROSS =3D else > CROSS ?=3D tile- > +endif I don't think the CROSS variable should have a default value. It really depends on the toolchain. [lsun] Make sense. The current code (before the change) has default value '= CROSS ?=3D tile-' defined, which cause some issue when doing native build. = Another way is to define it as "CROSS ?=3D" just like other platforms. So w= hen doing cross-compile, we could pass " CROSS=3Dtile-" . Talking about the toolchain, is it possible to build DPDK with the provided= binary toolchain http://www.tilera.com/scm/tilegx-x86_64.tar.bz2 ? This is the Tilera Open Source page: http://www.tilera.com/scm/ [lsun] I tried it just now. The gcc appears ok. But this tarball lacks of s= ome header files and libraries to compile DPDK. We're looking into it to see whether it can be easily fixed.