From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liming Sun Subject: Re: [PATCH v2 1/3] driver/net/mpipe: support native build on tilegx platform. Date: Tue, 9 Feb 2016 21:15:27 +0000 Message-ID: References: <1450193851-9100-4-git-send-email-lsun@ezchip.com> <1642628.fgbdceb2p5@xps13> , <1753191.PlZlSmjA8r@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" To: Thomas Monjalon Return-path: Received: from emea01-am1-obe.outbound.protection.outlook.com (mail-am1on0079.outbound.protection.outlook.com [157.56.112.79]) by dpdk.org (Postfix) with ESMTP id 8B3D62C72 for ; Tue, 9 Feb 2016 22:15:28 +0100 (CET) In-Reply-To: <1753191.PlZlSmjA8r@xps13> Content-Language: en-US List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Looks like this patch serie has been merged into dpdk-next-net/rel_16_04. What would be the usual way to submit changes for new comments? Would it be= incremental changes (new commit) based on previous one? Thanks. ________________________________________ From: Thomas Monjalon Sent: Tuesday, February 9, 2016 3:33 PM To: Liming Sun Cc: dev@dpdk.org; bruce.richardson@intel.com Subject: Re: [dpdk-dev] [PATCH v2 1/3] driver/net/mpipe: support native bui= ld on tilegx platform. 2016-02-09 18:37, Liming Sun: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > A comment about the TILE-Mx would be welcome. > Is it supported currently? > Isn't it an ARM arch? > > [lsun] Yes, it's ARM arch, but with similar mpipe driver. > It's not fully supported yet. I'll remove this change and add it in a dif= ferent serie when it's ready. OK So we'll discuss how to integrate it later. > > +# Compile combined lib by default. > > +CONFIG_RTE_BUILD_COMBINE_LIBS=3Dy > > Why forcing this option in the defconfig file? > > [lsun] It's just trying to make it handy for other applications like OVS = or ODP on top of DPDK. However we could remove this change if it's not the = recommended way. Yes please remove it. > > ARCH ?=3D tile > > + > > +HOST_ARCH :=3D ${shell uname -m} > > +ifneq ($(filter tile%,${HOST_ARCH}),) CROSS =3D else > > CROSS ?=3D tile- > > +endif > > I don't think the CROSS variable should have a default value. > It really depends on the toolchain. > > [lsun] Make sense. The current code (before the change) has default value= 'CROSS ?=3D tile-' defined, which cause some issue when doing native build= . Another way is to define it as "CROSS ?=3D" just like other platforms. So= when doing cross-compile, we could pass " CROSS=3Dtile-" . No need to keep a "CROSS ?=3D" line. The variables defined in the command line get the priority. > Talking about the toolchain, is it possible to build DPDK with the provid= ed binary toolchain http://www.tilera.com/scm/tilegx-x86_64.tar.bz2 ? > This is the Tilera Open Source page: http://www.tilera.com/scm/ > > [lsun] I tried it just now. The gcc appears ok. But this tarball lacks of= some header files and libraries to compile DPDK. Yes that's what I've experienced. > We're looking into it to see whether it can be easily fixed. Please keep us informed when the toolchain is ready. Thanks=