From mboxrd@z Thu Jan 1 00:00:00 1970 From: Prabhakar Kushwaha Date: Sun, 23 Oct 2016 14:04:00 +0000 Subject: [U-Boot] [PATCH] Kconfig: ifc: Moving IFC_BANK_COUNT from Kconfig to config.h In-Reply-To: References: <1477024638-24312-1-git-send-email-prabhakar.kushwaha@nxp.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi York, > -----Original Message----- > From: york sun > Sent: Friday, October 21, 2016 7:55 PM > To: Prabhakar Kushwaha ; u- > boot at lists.denx.de > Cc: oss at buserror.net > Subject: Re: [PATCH] Kconfig: ifc: Moving IFC_BANK_COUNT from Kconfig to > config.h > > On 10/20/2016 11:37 PM, Prabhakar Kushwaha wrote: > > Migration of IFC_BANK_COUNT from Kconfig to config.h avoids adding > > SoC name in Kconfig as Dependencies. It will help in having > > all SoC related defines in config.h - easy to maintain. > > > > Prabhakar, > > Why do you want to go back to config.h? I think we are going with > Kconfig. Having everything in one config file conflicts with Kconfig. > The former has centralized config per SoC, the latter has centralized > config per feature. > There are 2 reason for this 1) in File arch/arm/cpu/armv8/fsl-layerscape/Kconfig, "depends" row will keep on increasing with SoC. And if I add new field CONFIG_SYS_FSL_IFC_CLK_DIV, similar entry will be done and it will also keep on increasing with SoC. I want to avoid it. config SYS_FSL_IFC_BANK_COUNT int "Maximum banks of Integrated flash controller" depends on ARCH_LS1043A || ARCH_LS1046A || ARCH_LS2080A default 4 if ARCH_LS1043A default 4 if ARCH_LS1046A default 8 if ARCH_LS2080A 2) There is no file similar to " arch/arm/cpu/armv8/fsl-layerscape/Kconfig" for powerpc platform. So how to add new " CONFIG SYS_FSL_IFC_CLK_DIV" with different values per SoC. This problem will come for defining other clocks for " armv8/fsl-lsch3: consolidate the clock system initialization" --prabhakar