From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shreyansh Jain Subject: Re: [PATCHv2 01/34] lib/ether: add rte_device in rte_eth_dev Date: Tue, 20 Dec 2016 04:41:27 +0000 Message-ID: References: <1480875447-23680-1-git-send-email-hemant.agrawal@nxp.com> <1482180853-18823-1-git-send-email-hemant.agrawal@nxp.com> <1482180853-18823-2-git-send-email-hemant.agrawal@nxp.com> <20161219081651.6482f6b1@xeon-e3> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" , "thomas.monjalon@6wind.com" , "bruce.richardson@intel.com" , "john.mcnamara@intel.com" , "ferruh.yigit@intel.com" , "jerin.jacob@caviumnetworks.com" To: Stephen Hemminger , Hemant Agrawal Return-path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10049.outbound.protection.outlook.com [40.107.1.49]) by dpdk.org (Postfix) with ESMTP id ED0C3FAD4 for ; Tue, 20 Dec 2016 05:41:39 +0100 (CET) In-Reply-To: <20161219081651.6482f6b1@xeon-e3> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Monday, December 19, 2016 9:47 PM > To: Hemant Agrawal > Cc: dev@dpdk.org; thomas.monjalon@6wind.com; bruce.richardson@intel.com; > Shreyansh Jain ; john.mcnamara@intel.com; > ferruh.yigit@intel.com; jerin.jacob@caviumnetworks.com > Subject: Re: [dpdk-dev] [PATCHv2 01/34] lib/ether: add rte_device in > rte_eth_dev >=20 > On Tue, 20 Dec 2016 02:23:40 +0530 > Hemant Agrawal wrote: >=20 > > Signed-off-by: Hemant Agrawal > > --- > > lib/librte_ether/rte_ethdev.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethde= v.h > > index 9678179..0b601e9 100644 > > --- a/lib/librte_ether/rte_ethdev.h > > +++ b/lib/librte_ether/rte_ethdev.h > > @@ -1626,6 +1626,7 @@ struct rte_eth_dev { > > eth_rx_burst_t rx_pkt_burst; /**< Pointer to PMD receive function. */ > > eth_tx_burst_t tx_pkt_burst; /**< Pointer to PMD transmit function. *= / > > struct rte_eth_dev_data *data; /**< Pointer to device data */ > > + struct rte_device *device; > > const struct eth_driver *driver;/**< Driver for this device */ > > const struct eth_dev_ops *dev_ops; /**< Functions exported by PMD */ > > struct rte_pci_device *pci_dev; /**< PCI info. supplied by probing */ >=20 > NAK > I would rather that rte_pci_device be eliminated from rte_eth_dev_data an= d > replace by more generic rte_device. I am working on a patch set to do thi= s, > it is not fundamentally hard. That's interesting. I am already working on it (removing pci_dev from rte_e= th_dev and pci_drv from eth_driver). Anyways, I will focus on something dif= ferent if you are already working on it. (Do let me know if you are working on eth_driver change as well - replacing= rte_pci_driver with rte_driver or complete removal of eth_driver all toget= her as discussed on ML). - Shreyansh