From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shreyansh Jain Subject: Re: [PATCH v8 4/9] eal/bus: support for scanning of bus Date: Wed, 18 Jan 2017 05:15:15 +0000 Message-ID: References: <1484647774-28984-1-git-send-email-shreyansh.jain@nxp.com> <1484660264-6531-1-git-send-email-shreyansh.jain@nxp.com> <1484660264-6531-5-git-send-email-shreyansh.jain@nxp.com> <1666796.CLgGY7A5Bb@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" To: Thomas Monjalon Return-path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0040.outbound.protection.outlook.com [104.47.1.40]) by dpdk.org (Postfix) with ESMTP id ADDF32B83 for ; Wed, 18 Jan 2017 06:15:37 +0100 (CET) In-Reply-To: <1666796.CLgGY7A5Bb@xps13> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, January 18, 2017 5:07 AM > To: Shreyansh Jain > Cc: dev@dpdk.org > Subject: Re: [PATCH v8 4/9] eal/bus: support for scanning of bus >=20 > 2017-01-17 19:07, Shreyansh Jain: > > + * Generic bus object passed only as a helper for implementation to fi= nd > > + * their respective registered bus object. Implementations can choose = not > > + * to use this variable. >=20 > I think this comment is obsolete. =20 I will remove it. >=20 > > + * > > + * @return > > + * 0 for successful scan > > + * !0 (<0) for unsuccessful scan with error value >=20 > What do you mean with !0 (<0) ? > I guess <0 is enough. >=20 =20 Only to highlight that only '-ve' values would be returned. I will change i= t to !0 only. > > + */ > > +typedef int (*rte_bus_scan_t)(void); > > >=20