All of lore.kernel.org
 help / color / mirror / Atom feed
From: Z.q. Hou <zhiqiang.hou@nxp.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] pci: Change the first CFG read to Vendor ID in enumeration
Date: Tue, 9 Oct 2018 08:07:38 +0000	[thread overview]
Message-ID: <DB5PR04MB12213ECF957F9F99CF19825384E70@DB5PR04MB1221.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <CAPnjgZ1Q+Z2_n8fb8iUzEmehBDGj0WLhao0E-YbeRtzA0SoBgw@mail.gmail.com>

Hi Simon and Bin,

Do I need to send the standalone patch 1/2 in version 2?

Thanks,
Zhiqiang

> -----Original Message-----
> From: sjg at google.com <sjg@google.com> On Behalf Of Simon Glass
> Sent: 2018年10月9日 11:41
> To: Bin Meng <bmeng.cn@gmail.com>
> Cc: Z.q. Hou <zhiqiang.hou@nxp.com>; U-Boot Mailing List
> <u-boot@lists.denx.de>; Christian Gmeiner <christian.gmeiner@gmail.com>;
> Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi>; Bernhard Messerklinger
> <bernhard.messerklinger@br-automation.com>; Masahiro Yamada
> <yamada.masahiro@socionext.com>; Mingkai Hu <mingkai.hu@nxp.com>;
> M.h. Lian <minghuan.lian@nxp.com>
> Subject: Re: [PATCH 2/2] pci: Change the first CFG read to Vendor ID in
> enumeration
> 
> Hi Bin,
> 
> On 8 October 2018 at 02:54, Bin Meng <bmeng.cn@gmail.com> wrote:
> > On Mon, Oct 8, 2018 at 4:36 PM Zhiqiang Hou <Zhiqiang.Hou@nxp.com>
> wrote:
> >>
> >> From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> >>
> >> As the PCIe specification recommend reading the Vendor ID register to
> >> determine if a Function is present, read the Vendor ID of a
> >> non-existent Function must not result in system error, so we'd better
> >> make the first CFG read to Vendor ID instead of Header Type register
> >> in the PCIe enumeration.
> >>
> >> Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> >> ---
> >>  drivers/pci/pci.c | 4 ++--
> >>  1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >
> > Simon, do we need fix the non-DM version or adding new "capability" to
> > the non-DM drivers? I guess the answer is no and we should set some
> > deadline for PCI DM conversion too?
> 
> We should not fix or add new features to non-DM PCI. No one should be using
> it at this point.
> 
> I agree about the deadline. Do you want to send a patch?
> 
> Regards,
> Simon

  parent reply	other threads:[~2018-10-09  8:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-08  8:35 [U-Boot] [PATCH 1/2] dm/pci: Change the first CFG read to Vendor ID in enumeration Zhiqiang Hou
2018-10-08  8:35 ` [U-Boot] [PATCH 2/2] pci: " Zhiqiang Hou
2018-10-08  8:54   ` Bin Meng
2018-10-09  3:40     ` Simon Glass
2018-10-09  5:15       ` Bin Meng
2018-10-09  8:07       ` Z.q. Hou [this message]
2018-10-19  3:27         ` Simon Glass
2018-10-08  8:53 ` [U-Boot] [PATCH 1/2] dm/pci: " Bin Meng
2018-10-08  9:20   ` Z.q. Hou
2018-11-22 20:22   ` sjg at google.com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB5PR04MB12213ECF957F9F99CF19825384E70@DB5PR04MB1221.eurprd04.prod.outlook.com \
    --to=zhiqiang.hou@nxp.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.