Re: [meta-fsl-arm][PATCH 8/9] gstreamer1.0-plugins-bad: Fix gleffects fisheye shader compile error

[Yuqing Zhu <carol.zhu@nxp.com>]

Hi Carlos,


      The float number will diminishes readability, but we will create a ticket to GStreamer bugzilla. 
       If they accept it, I will push the patch to poky.

B.R.
Yuqing Zhu



-----Original Message-----
From: meta-freescale-bounces@yoctoproject.org [mailto:meta-freescale-bounces@yoctoproject.org] On Behalf Of Carlos Rafael Giani
Sent: Wednesday, January 27, 2016 8:11 PM
To: meta-freescale@yoctoproject.org
Subject: Re: [meta-freescale] [meta-fsl-arm][PATCH 8/9] gstreamer1.0-plugins-bad: Fix gleffects fisheye shader compile error

This commit is acceptable. I can also live with the "i.MX specific" 
part, since this is a Vivante GPU problem.

I think this could be upstreamed, though, because having "sqrt(2)" in the shader does not actually gain anybody anything. It would be perfectly acceptable to replace it with 1.414213562 instead. I recommend posting this to GStreamer bugzilla.


On 01/27/2016 10:41 AM, Yuqing Zhu wrote:
> shader function "sqrt" is not support, use float number 1.414
>
> Signed-off-by: Yuqing Zhu <b54851@freescale.com>
> ---
>   ...-glplugin-fix-gleffects-fisheye-shader-co.patch | 31 ++++++++++++++++++++++
>   .../gstreamer/gstreamer1.0-plugins-bad_%.bbappend  |  1 +
>   2 files changed, 32 insertions(+)
>   create mode 100755 
> recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad/0009-glplugin-fi
> x-gleffects-fisheye-shader-co.patch
>
> diff --git 
> a/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad/0009-glplugin-
> fix-gleffects-fisheye-shader-co.patch 
> b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad/0009-glplugin-
> fix-gleffects-fisheye-shader-co.patch
> new file mode 100755
> index 0000000..d017a1f
> --- /dev/null
> +++ b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad/0009-glplu
> +++ gin-fix-gleffects-fisheye-shader-co.patch
> @@ -0,0 +1,31 @@
> +From de919fc1cf4250db240757a94f302d81620b451c Mon Sep 17 00:00:00 
> +2001
> +From: Haihua Hu <b55597@freescale.com>
> +Date: Tue, 8 Dec 2015 14:09:58 +0800
> +Subject: [PATCH 5/5] [MMFMWK-6966] [glplugin] fix gleffects fisheye 
> +shader  compile error
> +
> +shader function "sqrt" is not support, use float number 1.414
> +
> +Upstream-Status: Inappropriate [i.MX specific]
> +
> +Signed-off-by: Haihua Hu <b55597@freescale.com>
> +---
> + ext/gl/effects/gstgleffectssources.c |    2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/ext/gl/effects/gstgleffectssources.c 
> +b/ext/gl/effects/gstgleffectssources.c
> +index 3da856c..076e21b 100644
> +--- a/ext/gl/effects/gstgleffectssources.c
> ++++ b/ext/gl/effects/gstgleffectssources.c
> +@@ -152,7 +152,7 @@ const gchar *fisheye_fragment_source_gles2 =
> +   "  vec2 normcoord;"
> +   "  normcoord = texturecoord - 0.5;"
> +   "  float r = length (normcoord);"
> +-  "  normcoord *= r * sqrt(2);"
> ++  "  normcoord *= r * 1.414;"
> +   "  texturecoord = normcoord + 0.5;"
> +   "  gl_FragColor = texture2D (tex, texturecoord);"
> +   "}";
> +--
> +1.7.9.5
> +
> diff --git 
> a/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_%.bbappend 
> b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_%.bbappend
> index d3b8c2d..ce8a158 100644
> --- a/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_%.bbappend
> +++ b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_%.bbappend
> @@ -18,6 +18,7 @@ IMX_PATCHES = " file://0001-PATCH-install-gstaggregator-and-gstvideoaggregator-h
>                   file://0006-glplugin-Support-fb-backend-for-gl-plugins.patch \
>                   file://0007-glplugin-Change-wayland-default-res-to-1024x768.patch \
>                   
> file://0008-glplugin-Add-fps-print-in-glimagesink.patch \
> +                
> + file://0009-glplugin-fix-gleffects-fisheye-shader-co.patch \
>   "
>   
>   SRC_URI_append_mx6 = "${IMX_PATCHES}"

--
_______________________________________________
meta-freescale mailing list
meta-freescale@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-freescale