All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alison Wang <alison.wang@nxp.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: ls102xa: Remove reduplicate definition for Generic Timer frequency
Date: Sat, 8 Oct 2016 02:21:10 +0000	[thread overview]
Message-ID: <DB5PR04MB215206487776CF4C9E45E1A0F4D90@DB5PR04MB2152.eurprd04.prod.outlook.com> (raw)

Hi, York,

> On 09/23/2016 01:15 AM, Alison Wang wrote:
> > GENERIC_TIMER_CLK and CONFIG_TIMER_CLK_FREQ are both used to define
> > Generic Timer frequency. It is reduplicate. This patch will remove
> > GENERIC_TIMER_CLK macro.
> >
> > Signed-off-by: Alison Wang <alison.wang@nxp.com>
> > ---
> >  arch/arm/cpu/armv7/ls102xa/psci.S  | 2 +-
> > arch/arm/cpu/armv7/ls102xa/timer.c | 2 +-
> >  include/configs/ls1021aqds.h       | 5 -----
> >  include/configs/ls1021atwr.h       | 5 -----
> >  4 files changed, 2 insertions(+), 12 deletions(-)
> >
> > diff --git a/arch/arm/cpu/armv7/ls102xa/psci.S
> > b/arch/arm/cpu/armv7/ls102xa/psci.S
> > index 8f38680..9efb6d8 100644
> > --- a/arch/arm/cpu/armv7/ls102xa/psci.S
> > +++ b/arch/arm/cpu/armv7/ls102xa/psci.S
> > @@ -36,7 +36,7 @@
> >
> >  	.align	5
> >
> > -#define	ONE_MS		(GENERIC_TIMER_CLK / 1000)
> > +#define	ONE_MS		(CONFIG_TIMER_CLK_FREQ / 1000)
> >  #define	RESET_WAIT	(30 * ONE_MS)
> >
> 
> Alison,
> 
> Can you use GENERIC_TIMER_CLK? Recent change in U-Boot doesn't favor
> using CONFIG_* macros.
[Alison Wang] If GENERIC_TIMER_CLK is used and CONFIG_TIMER_CLK_FREQ is removed,
I need to modify the generic codes which use CONFIG_TIMER_CLK_FREQ in
arch/arm/cpu/armv7/nonsec_virt.S. Some other platforms may be affected. So I
remove GENERIC_TIMER_CLK in v1.

What's your idea?

Best Regards,
Alison Wang

             reply	other threads:[~2016-10-08  2:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-08  2:21 Alison Wang [this message]
2016-10-08 17:00 ` [U-Boot] [PATCH] arm: ls102xa: Remove reduplicate definition for Generic Timer frequency york sun
  -- strict thread matches above, loose matches on Subject: below --
2016-09-23  8:03 Alison Wang
2016-10-05 16:06 ` york sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB5PR04MB215206487776CF4C9E45E1A0F4D90@DB5PR04MB2152.eurprd04.prod.outlook.com \
    --to=alison.wang@nxp.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.