From mboxrd@z Thu Jan 1 00:00:00 1970 From: Biwen Li (OSS) Date: Fri, 17 Apr 2020 05:57:52 +0000 Subject: [PATCH 20/27] dm: ppc: MPC8548CDS: add i2c DM support In-Reply-To: References: <20200412085428.27519-1-biwen.li@oss.nxp.com> <20200412085428.27519-20-biwen.li@oss.nxp.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de > Subject: RE: [PATCH 20/27] dm: ppc: MPC8548CDS: add i2c DM support > > >-----Original Message----- > >From: U-Boot On Behalf Of Biwen Li > >Sent: Sunday, April 12, 2020 2:24 PM > >To: Jagdish Gediya ; Priyanka Jain > >; hs at denx.de; jagan at amarulasolutions.com; > >aford173 at gmail.com; Alison Wang ; > >jh80.chung at samsung.com; Pramod Kumar ; > Rajesh > >Bhagat ; Ruchika Gupta > ; > >olteanv at gmail.com > >Cc: Xiaobo Xie ; Jiafei Pan ; > >u- boot at lists.denx.de; Z.q. Hou ; Biwen Li > > > >Subject: [PATCH 20/27] dm: ppc: MPC8548CDS: add i2c DM support > > > >From: Biwen Li > > > >This supports i2c DM for board MPC8548CDS > > > >Signed-off-by: Biwen Li > >--- > > board/freescale/common/sys_eeprom.c | 3 ++- > > include/configs/MPC8548CDS.h | 9 ++++++++- > > 2 files changed, 10 insertions(+), 2 deletions(-) > > > >diff --git a/board/freescale/common/sys_eeprom.c > >b/board/freescale/common/sys_eeprom.c > >index 6f151b0f71..c52af7060e 100644 > >--- a/board/freescale/common/sys_eeprom.c > >+++ b/board/freescale/common/sys_eeprom.c > >@@ -589,6 +589,7 @@ unsigned int get_cpu_board_revision(void) > > u8 major; /* 0x04 Board revision, major */ > > u8 minor; /* 0x05 Board revision, minor */ > > } be; > >+ int ret; > > > > #ifndef CONFIG_DM_I2C > > i2c_read(CONFIG_SYS_I2C_EEPROM_ADDR, 0, > >CONFIG_SYS_I2C_EEPROM_ADDR_LEN, @@ -603,7 +604,7 @@ unsigned int > >get_cpu_board_revision(void) #else > > ret = i2c_get_chip_for_busnum(0, CONFIG_SYS_I2C_EEPROM_ADDR, > > CONFIG_SYS_I2C_EEPROM_ADDR_LEN, > >- &dev) > >+ &dev); > Was this compilation error exist before this patch series as well? > > > #endif > > if (!ret) > > dm_i2c_read(dev, 0, (void *)&be, sizeof(be)); diff --git > >a/include/configs/MPC8548CDS.h b/include/configs/MPC8548CDS.h index > >a68d190f6a..d185926cab 100644 > >--- a/include/configs/MPC8548CDS.h > >+++ b/include/configs/MPC8548CDS.h > >@@ -1,6 +1,7 @@ > > /* SPDX-License-Identifier: GPL-2.0+ */ > > /* > > * Copyright 2004, 2007, 2010-2011 Freescale Semiconductor. > >+ * Copyright 2020 NXP > > */ > > > > /* > >@@ -304,12 +305,18 @@ extern unsigned long get_clock_freq(void); > > /* > > * I2C > > */ > >+#ifndef CONFIG_DM_I2C > > #define CONFIG_SYS_I2C > >+#define CONFIG_SYS_I2C_NOPROBES { {0, 0x69} } > >+#else > >+#define CONFIG_SYS_SPD_BUS_NUM 0 > >+#define CONFIG_I2C_SET_DEFAULT_BUS_NUM > >+#define CONFIG_I2C_DEFAULT_BUS_NUMBER 0 > >+#endif > > #define CONFIG_SYS_I2C_FSL > > #define CONFIG_SYS_FSL_I2C_SPEED 400000 > In other similar patches, you were adding this kind of defines under #ifndef > CONFIG_DM_I2C Why it is different for this patch? I will move it to #ifndef CONFIG_DM_I2C, and below configs in v2. #define CONFIG_SYS_FSL_I2C_SLAVE 0x7F #define CONFIG_SYS_FSL_I2C_OFFSET 0x3000 > Priyanka > > #define CONFIG_SYS_FSL_I2C_SLAVE 0x7F > > #define CONFIG_SYS_FSL_I2C_OFFSET 0x3000 > >-#define CONFIG_SYS_I2C_NOPROBES { {0, 0x69} } > > > > /* EEPROM */ > > #define CONFIG_ID_EEPROM > >-- > >2.17.1