From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757210AbcIGJTt (ORCPT ); Wed, 7 Sep 2016 05:19:49 -0400 Received: from mail-db5eur01on0051.outbound.protection.outlook.com ([104.47.2.51]:55648 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753724AbcIGJTr (ORCPT ); Wed, 7 Sep 2016 05:19:47 -0400 From: Meng Yi To: Stefan Agner , "dri-devel@lists.freedesktop.org" CC: "alison.wang@freescale.com" , "jianwei.wang.chn@gmail.com" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH 3/4] drm/fsl-dcu: update all registers on flush Thread-Topic: [PATCH 3/4] drm/fsl-dcu: update all registers on flush Thread-Index: AQHSB/OL2niZ3JvDf0Goo3v+LFTRsaBttNqQ Date: Wed, 7 Sep 2016 08:46:32 +0000 Message-ID: References: <20160906040233.32471-1-stefan@agner.ch> <20160906040233.32471-4-stefan@agner.ch> In-Reply-To: <20160906040233.32471-4-stefan@agner.ch> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=meng.yi@nxp.com; x-originating-ip: [199.59.231.64] x-ms-office365-filtering-correlation-id: 8c7be212-75df-43a7-77f9-08d3d6fb77e6 x-microsoft-exchange-diagnostics: 1;DB6PR0401MB2629;6:LM/VjXbMd8SSLRRhKy6RhsLOxrGQrRQD2JmSAan6BTeSnDrD0EeDnY/JQbCEFkErDVthstHDYiGwoSVMeE9xuRAGsD+W7Ycgu5q5O0mLUp63gi9sbUCaTZ8cf+Q0td5pjeAnbYPkTXO8onB7iMy/pxJA8GdoGZegEfSY+gKJ+IcQhKRHW3XxTYxhVvTrn87eUZk8tKNXgt+K9jvOD8QnmVD4VL9nPQgP3s1IXdTRPydrIzWJZZWadZ+DFYJQQuthJb2Z2OUklTYoEF9Ake//M4kEWDE9yEJFA+47xYzQb8mX+ofXbpPqRt4fdEMC3mZVm57sNjD17S1m8iCvIIirkg==;5:XOv9YrEPzgg6KT/ftZjeimcOg2MF83YTdPjnTX37kuKE1rYbmuOHu4fkoS3cI2pvnZPOux9sanxkWyDbiznYlWIImyNIk3SNYOBxmdMw7YV19hQxGvIJm0NJKw1s+8/9cF0eOIGXQHzPtyZjy+ctYg==;24:+NPcKQIL3zp/9463ioq2JAc7gAHDz6BSoGFBafybLVa58keMaCbs3CgpJvEseJGsr12pR3oMK9uZFLzPlinvS0ILtR5bEWa5wkQAAYWu4cQ=;7:MXQpB7NiE2GzgtSoPYQKATWXvpJ1YFwdzgZYGtOHdii18w28/v4gFKSaVP7JH7R/EbfnWbGGxinwkcVjZQ8K6zprvDUybzVqIHXII5Om9S0XqUrfyP0/YzUMACsjv9/uqTCDn+umbY+OuUle1BhCgnb2oxrcvM8GEe6oaM6+SnF/84yJo0Pm+oKs4R9M/JzZHJIpJ4ymajzXGXSC80VXtevzZ9lRMsInSRdGq/0O9PjJKI1Kekh0kMySjH44E95K x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0401MB2629; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026);SRVR:DB6PR0401MB2629;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0401MB2629; x-forefront-prvs: 0058ABBBC7 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(189002)(199003)(5660300001)(5002640100001)(2501003)(3846002)(11100500001)(50986999)(2900100001)(86362001)(76576001)(2906002)(3660700001)(81156014)(81166006)(8936002)(68736007)(92566002)(87936001)(8676002)(189998001)(586003)(9686002)(7696003)(106356001)(7736002)(76176999)(5001770100001)(66066001)(305945005)(2950100001)(105586002)(97736004)(101416001)(7846002)(77096005)(106116001)(6116002)(102836003)(74316002)(122556002)(4326007)(33656002)(3280700002)(10400500002)(54356999);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0401MB2629;H:DB6PR0401MB2631.eurprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2016 08:46:32.4989 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2629 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u879JrYM014810 Hi Stefan, Some comments below > > diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c b/drivers/gpu/drm/fsl- > dcu/fsl_dcu_drm_crtc.c > index d30b61e..62eb284 100644 > --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c > +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c > @@ -27,6 +27,9 @@ static void fsl_dcu_drm_crtc_atomic_flush(struct drm_crtc > *crtc, { > struct drm_pending_vblank_event *event = crtc->state->event; > > + regmap_write(fsl_dev->regmap, > + DCU_UPDATE_MODE, DCU_UPDATE_MODE_READREG); fsl_dev is not declared. I had added these two lines when testing the patches. struct drm_device *dev = crtc->dev; struct fsl_dcu_drm_device *fsl_dev = dev->dev_private; > + > if (event) { > crtc->state->event = NULL; > Best Regards, Meng