From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757407AbcIGNRJ (ORCPT ); Wed, 7 Sep 2016 09:17:09 -0400 Received: from mail-db5eur01on0061.outbound.protection.outlook.com ([104.47.2.61]:17599 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752900AbcIGNRH (ORCPT ); Wed, 7 Sep 2016 09:17:07 -0400 From: Meng Yi To: Stefan Agner , "dri-devel@lists.freedesktop.org" CC: "alison.wang@freescale.com" , "jianwei.wang.chn@gmail.com" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH 0/4] drm/fsl-dcu: add overlay and cursor plane support Thread-Topic: [PATCH 0/4] drm/fsl-dcu: add overlay and cursor plane support Thread-Index: AQHSB/OIoOFa6Mhj+kS6duVPv8VuJaBttVdA Date: Wed, 7 Sep 2016 08:43:55 +0000 Message-ID: References: <20160906040233.32471-1-stefan@agner.ch> In-Reply-To: <20160906040233.32471-1-stefan@agner.ch> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=meng.yi@nxp.com; x-originating-ip: [199.59.231.64] x-ms-office365-filtering-correlation-id: 0bf2be96-f5eb-417c-2f73-08d3d6fb1a4f x-microsoft-exchange-diagnostics: 1;DB6PR0401MB2630;6:mHcq8ZtaTovrjoi6DutqkzigpPU3bdEjTTpth4L6AOOd9jSgz1OOYrof/hQfSTm0tjm1r6uLjEtwF3JybZkbI8fP5MtRteAeJMtRUx6VRtN//wZxEwm8AChiCpQMtNH8EHy/CTgO+lLZrrXUFWacHozWrCDPMkqsm6IASyz/VJ3MvDlX+MDib6VObvPdxoa0jNsDbITD5CC1YbMdKAylIF+Q10rGnVJoCMQqf/sDkrrG9kIcUhMDqSKWmhbMpaSS7BvWaX+UNrJobiAeXRxbIUXhdEWT2z/YcHcdNc/QQXEirG6+X4kZb6lyUfcDWTRtawjx1CH6ZIGs2pQAGOYD9w==;5:kL8iqg/Eh9+M4SlUseJjYroNP+qMrqffkDppTIyNBW8oWiHRpV6z8LGRE85PEjJnyVGjPS1fnO5771A27ZMpZTWV4knDGHuZpfxf149A1673Vhzyxk/zgTxbyCS9FT7GmsuRDJJ2bflcXquZ2nTuHQ==;24:DlW/znEJsR7iftgKHEY9kwuRChjqCEHd2HE49Pv8sdgyDmUZZJE+Ka1B0VM36eODDAhOYnvzQj8DEdGF9V5cZJbTn/V3Z29VvslH4KJ2K44=;7:9pG3OcaGsk1PjKqZD6WsXd+RJHGsSa7qan3DjOLvFz8whjpt+pRxsxqX3IHiIqtG0ZDuj6ZTN4cQKT+J2GmNiCwDBiRkAMdHiDeME/3ODQC573TP3swe+1nDSZ0TsxdqcK40O/icCv3/4xIW8VlKvDXYIxMk1AH6X+Z4cEH/gWvHi3C+7sTxtW5kk89dVOozPfXp7b4P+ueFZvE93WlHluohAaq4A6Z3i5wjHHqu0PVSJ7GpeBMPB5vZHWNOfLax x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0401MB2630; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026);SRVR:DB6PR0401MB2630;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0401MB2630; x-forefront-prvs: 0058ABBBC7 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(199003)(189002)(16799955002)(7846002)(77096005)(2950100001)(11100500001)(6116002)(68736007)(10400500002)(101416001)(8936002)(5001770100001)(3280700002)(102836003)(76176999)(586003)(66066001)(86362001)(189998001)(7736002)(3660700001)(7696003)(19580405001)(19580395003)(33656002)(76576001)(15975445007)(92566002)(122556002)(97736004)(106356001)(74316002)(2900100001)(4326007)(9686002)(2906002)(81156014)(5002640100001)(106116001)(5660300001)(8676002)(2501003)(54356999)(81166006)(87936001)(3846002)(105586002)(50986999)(305945005);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0401MB2630;H:DB6PR0401MB2631.eurprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2016 08:43:55.3682 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2630 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u87DHD0j016180 Hi Stefan, I had tested the patches on LS1021A-TWR board using drmlib. Like set three overlays: root@ls1021atwr:~# ./modetest -P 39:900x100+10+10@RG24 -P 39:200x200+300+0@RG24 -P 39:200x200+400+300@RG24 How did you test the overlays and cursor layer, I mean I see you using x-window like thing in the video. Best Regards, Meng > This patchset adds overlay and cursor plane support. It also fixes some issues > uncovered during implementation of this. > > However, the plane updates currently causes the display to flicker for unknown > reasons. As far as I can tell, the CRTC atomic_flush should trigger the update > correctly via READREG, which according to > documentation: > The READREG bit causes a single transfer to begin at the next frame blanking > period. This bit is cleared when the transfer is complete. > > I made a video how that looks: > https://cloud.agner.ch/index.php/s/Yfqa2u7UBEWUT8N > > Any ideas? > > Stefan Agner (4): > drm/fsl-dcu: support overlay and cursor planes > drm/fsl-dcu: respect pos/size register sizes > drm/fsl-dcu: update all registers on flush > drm/fsl-dcu: do not update when modifying irq registers > > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c | 50 > ++++++++++++++++++++++++----- > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 4 --- > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.h | 8 ++--- > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c | 42 +++++++++++------------- > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.h | 3 +- > 5 files changed, 67 insertions(+), 40 deletions(-) > > -- > 2.9.3 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Meng Yi Subject: RE: [PATCH 0/4] drm/fsl-dcu: add overlay and cursor plane support Date: Wed, 7 Sep 2016 08:43:55 +0000 Message-ID: References: <20160906040233.32471-1-stefan@agner.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0043.outbound.protection.outlook.com [104.47.2.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id EF1826E92F for ; Wed, 7 Sep 2016 08:43:57 +0000 (UTC) In-Reply-To: <20160906040233.32471-1-stefan@agner.ch> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Stefan Agner , "dri-devel@lists.freedesktop.org" Cc: "jianwei.wang.chn@gmail.com" , "linux-kernel@vger.kernel.org" , "alison.wang@freescale.com" List-Id: dri-devel@lists.freedesktop.org SGkgU3RlZmFuLAoKSSBoYWQgdGVzdGVkIHRoZSBwYXRjaGVzIG9uIExTMTAyMUEtVFdSIGJvYXJk IHVzaW5nIGRybWxpYi4KCkxpa2Ugc2V0IHRocmVlIG92ZXJsYXlzOgpyb290QGxzMTAyMWF0d3I6 fiMgLi9tb2RldGVzdCAtUCAzOTo5MDB4MTAwKzEwKzEwQFJHMjQgLVAgMzk6MjAweDIwMCszMDAr MEBSRzI0IC1QIDM5OjIwMHgyMDArNDAwKzMwMEBSRzI0CgpIb3cgZGlkIHlvdSB0ZXN0IHRoZSBv dmVybGF5cyBhbmQgY3Vyc29yIGxheWVyLCBJIG1lYW4gSSBzZWUgeW91IHVzaW5nIHgtd2luZG93 IGxpa2UgdGhpbmcgaW4gdGhlICB2aWRlby4KCkJlc3QgUmVnYXJkcywKTWVuZwoKPiBUaGlzIHBh dGNoc2V0IGFkZHMgb3ZlcmxheSBhbmQgY3Vyc29yIHBsYW5lIHN1cHBvcnQuIEl0IGFsc28gZml4 ZXMgc29tZSBpc3N1ZXMKPiB1bmNvdmVyZWQgZHVyaW5nIGltcGxlbWVudGF0aW9uIG9mIHRoaXMu Cj4gCj4gSG93ZXZlciwgdGhlIHBsYW5lIHVwZGF0ZXMgY3VycmVudGx5IGNhdXNlcyB0aGUgZGlz cGxheSB0byBmbGlja2VyIGZvciB1bmtub3duCj4gcmVhc29ucy4gQXMgZmFyIGFzIEkgY2FuIHRl bGwsIHRoZSBDUlRDIGF0b21pY19mbHVzaCBzaG91bGQgdHJpZ2dlciB0aGUgdXBkYXRlCj4gY29y cmVjdGx5IHZpYSBSRUFEUkVHLCB3aGljaCBhY2NvcmRpbmcgdG8KPiBkb2N1bWVudGF0aW9uOgo+ IFRoZSBSRUFEUkVHIGJpdCBjYXVzZXMgYSBzaW5nbGUgdHJhbnNmZXIgdG8gYmVnaW4gYXQgdGhl IG5leHQgZnJhbWUgYmxhbmtpbmcKPiBwZXJpb2QuIFRoaXMgYml0IGlzIGNsZWFyZWQgd2hlbiB0 aGUgdHJhbnNmZXIgaXMgY29tcGxldGUuCj4gCj4gSSBtYWRlIGEgdmlkZW8gaG93IHRoYXQgbG9v a3M6Cj4gaHR0cHM6Ly9jbG91ZC5hZ25lci5jaC9pbmRleC5waHAvcy9ZZnFhMnU3VUJFV1VUOE4K PiAKPiBBbnkgaWRlYXM/Cj4gCj4gU3RlZmFuIEFnbmVyICg0KToKPiAgIGRybS9mc2wtZGN1OiBz dXBwb3J0IG92ZXJsYXkgYW5kIGN1cnNvciBwbGFuZXMKPiAgIGRybS9mc2wtZGN1OiByZXNwZWN0 IHBvcy9zaXplIHJlZ2lzdGVyIHNpemVzCj4gICBkcm0vZnNsLWRjdTogdXBkYXRlIGFsbCByZWdp c3RlcnMgb24gZmx1c2gKPiAgIGRybS9mc2wtZGN1OiBkbyBub3QgdXBkYXRlIHdoZW4gbW9kaWZ5 aW5nIGlycSByZWdpc3RlcnMKPiAKPiAgZHJpdmVycy9ncHUvZHJtL2ZzbC1kY3UvZnNsX2RjdV9k cm1fY3J0Yy5jICB8IDUwCj4gKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0KPiAgZHJpdmVy cy9ncHUvZHJtL2ZzbC1kY3UvZnNsX2RjdV9kcm1fZHJ2LmMgICB8ICA0IC0tLQo+ICBkcml2ZXJz L2dwdS9kcm0vZnNsLWRjdS9mc2xfZGN1X2RybV9kcnYuaCAgIHwgIDggKystLS0KPiAgZHJpdmVy cy9ncHUvZHJtL2ZzbC1kY3UvZnNsX2RjdV9kcm1fcGxhbmUuYyB8IDQyICsrKysrKysrKysrLS0t LS0tLS0tLS0tLQo+IGRyaXZlcnMvZ3B1L2RybS9mc2wtZGN1L2ZzbF9kY3VfZHJtX3BsYW5lLmgg fCAgMyArLQo+ICA1IGZpbGVzIGNoYW5nZWQsIDY3IGluc2VydGlvbnMoKyksIDQwIGRlbGV0aW9u cygtKQo+IAo+IC0tCj4gMi45LjMKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2RyaS1kZXZlbAo=