From: Meng Yi <meng.yi@nxp.com>
To: "maxime.ripard@free-electrons.com" <maxime.ripard@free-electrons.com>
Cc: "daniel.vetter@intel.com" <daniel.vetter@intel.com>,
"wens@csie.org" <wens@csie.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Subject: RE: [PATCH v3 1/4] drm/bridge: Add RGB to VGA bridge support
Date: Sun, 18 Sep 2016 08:45:36 +0000 [thread overview]
Message-ID: <DB6PR0401MB2631DDFEDDE28F5D871A162BECF50@DB6PR0401MB2631.eurprd04.prod.outlook.com> (raw)
Hi Maxime,
> +
> +static struct drm_encoder *
> +dumb_vga_best_encoder(struct drm_connector *connector)
> +{
> + struct dumb_vga *vga = drm_connector_to_dumb_vga(connector);
> +
> + return vga->bridge.encoder;
> +}
> +
> +static struct drm_connector_helper_funcs dumb_vga_con_helper_funcs = {
> + .get_modes = dumb_vga_get_modes,
> + .best_encoder = dumb_vga_best_encoder,
> +};
> +
We have a 1:1 relationship between connectors and encoders, and the driver
is relying on the atomic helpers: we can drop the custom ->best_encoder(),
and let the core call drm_atomic_helper_best_encoder() for us.
Meng
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next reply other threads:[~2016-09-18 8:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-18 8:45 Meng Yi [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-09-08 12:17 [PATCH v3 0/4] drm: Add Support for Passive RGB to VGA bridges Maxime Ripard
[not found] ` <20160908121751.16911-1-maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-09-08 12:17 ` [PATCH v3 1/4] drm/bridge: Add RGB to VGA bridge support Maxime Ripard
2016-09-08 12:17 ` Maxime Ripard
[not found] ` <20160908121751.16911-2-maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-09-12 6:42 ` Chen-Yu Tsai
2016-09-12 6:42 ` Chen-Yu Tsai
2016-09-12 8:31 ` Archit Taneja
2016-09-12 8:31 ` Archit Taneja
2016-09-18 10:01 ` Laurent Pinchart
2016-09-18 10:01 ` Laurent Pinchart
2016-09-18 10:04 ` Laurent Pinchart
2016-09-18 10:04 ` Laurent Pinchart
2016-09-19 9:23 ` Maxime Ripard
2016-09-19 9:23 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB6PR0401MB2631DDFEDDE28F5D871A162BECF50@DB6PR0401MB2631.eurprd04.prod.outlook.com \
--to=meng.yi@nxp.com \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=maxime.ripard@free-electrons.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.