From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peng Fan <peng.fan@nxp.com>
Date: Tue, 26 May 2020 01:24:29 +0000
Subject: [PATCH] armv8: cache_v8: fix mmu_set_region_dcache_behaviour
In-Reply-To: <20200525175916.GB12717@bill-the-cat>
References: <20200511084107.7196-1-peng.fan@nxp.com>
 <20200525175916.GB12717@bill-the-cat>
Message-ID: <DB6PR0402MB2760C7BAEFCACAB85283C98E88B00@DB6PR0402MB2760.eurprd04.prod.outlook.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

> Subject: Re: [PATCH] armv8: cache_v8: fix
> mmu_set_region_dcache_behaviour
> 
> On Mon, May 11, 2020 at 04:41:07PM +0800, Peng Fan wrote:
> 
> > enum dcache_option already shift left 2 bits, PMD_ATTRINDX(option),
> > will wrongly shift left the attr 4bits, which is wrong. And make the
> > region user set not has expected attribute and might affect the
> > splitted block region.
> >
> > Reviewed-by: Ye Li <ye.li@nxp.com>
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> 
> Please note that I reworded the commit message a bit.  In the interest of
> fixing the bug now:
> 
> Applied to u-boot/master.
> 
> But on reading the code and macros to understand things better for the
> commit message, I wonder why we don't just use options directly now in the
> code?  

Seems directly using options would make it a bit simplier! I agree.

Thanks,
Peng.

Thanks!
> 
> --
> Tom