From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B177C433ED for ; Tue, 4 May 2021 11:22:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 451EF613BC for ; Tue, 4 May 2021 11:22:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230198AbhEDLXr (ORCPT ); Tue, 4 May 2021 07:23:47 -0400 Received: from mail-eopbgr60062.outbound.protection.outlook.com ([40.107.6.62]:6919 "EHLO EUR04-DB3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229903AbhEDLXq (ORCPT ); Tue, 4 May 2021 07:23:46 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LDPvbSTFDkB+QG2wnN50wTJo2TMoEC4OPxtjv3GUFRhO214jYSk7XaslUjTDsIXZ/qHGoXTjxUMIZ4masMb+twK6JmK0DV0wQPaHGdLyyc+ppXt25pLqrRPwcrxKv2oXRKLJhpiGgFDgXZ3t3LRYdVtEBD/5Bek8Cy7vrEJwT523puVfa0vrzRZLZCrKm6dFvW9P82Rcx2KxoGe2vJn/vX+zTHLDB8dKQHd50rUcRVHZ2Jgk0QF1o2iSteDjU9siv6Wg4/E0pLKB8ZVIItik+s1o2E5KX5s3UB5htXJHVQlVce1L8RBfV7Q5L76RQk7kexjW6mLYODPFRvXAnW8G2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uKo/FrhTur0NynfMbqP9HpYxZxTxfslgyYjpvVO5fQA=; b=dthI8IDn7KpCLIZggTRX11YKZI6tYMk8MvOTuZcHmk/qRJ01EK6Nv9Yap+yEWeowo9gWVrurLvgaMYdfaSuGfpB/zAAfIHhm9apAkEvaugKQDAZwlXPTW7wdUnsN4l9PoBuiBmtnYzt14vqBtJSBGyRn98MjeAkaQ9snZOQKhaeQZhWO73nILsIgIsZoM8jbRe0jds4ta3ceDqdPu9I7Yw4SRzKX2zToynVRxnUvW4DcXWElVdSeALL7W9NzILa8kBokfmW84ymSHQt39FUvGP0EPI99nmS9Rz9OGzsOGVhfOIfkyaHdJhPcnd6Y2MFXQGlGsgBi7DZeb/A7OYMXJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uKo/FrhTur0NynfMbqP9HpYxZxTxfslgyYjpvVO5fQA=; b=poDp8u7er7fCCjC3xug9lbSCkOvasHCdW3l9RhOE794uhf5Y2zI2PNj+wMAI0PgSm7+yrWB0fo6d7Dq7e7Wb5z2a93iaTaNfQmjDrTIw1yDF9FaLyKozthKAXGUyrWZFXM1u9EmzZ+cVAuOfPIBH/HXTVMNEYOFd863BnPt0uaY= Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) by DB6PR04MB3125.eurprd04.prod.outlook.com (2603:10a6:6:11::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.23; Tue, 4 May 2021 11:22:49 +0000 Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64]) by DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64%8]) with mapi id 15.20.4065.039; Tue, 4 May 2021 11:22:48 +0000 From: Peng Fan To: Fabio Estevam , "Peng Fan (OSS)" CC: Rob Herring , Shawn Guo , Sascha Hauer , Sascha Hauer , dl-linux-imx , Philipp Zabel , Lucas Stach , Krzysztof Kozlowski , =?utf-8?B?R3VpZG8gR8O8bnRoZXI=?= , Marek Vasut , Andrey Smirnov , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-kernel , Jacky Bai , Schrempf Frieder , Adam Ford , Abel Vesa Subject: RE: [PATCH V2 4/4] soc: imx: Add blk-ctl driver for i.MX8MM Thread-Topic: [PATCH V2 4/4] soc: imx: Add blk-ctl driver for i.MX8MM Thread-Index: AQHXPX0eRMyCb+5Z90CURUSnlReObarTMhSAgAACgOA= Date: Tue, 4 May 2021 11:22:48 +0000 Message-ID: References: <20210430052746.10815-1-peng.fan@oss.nxp.com> <20210430052746.10815-5-peng.fan@oss.nxp.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [58.223.139.112] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0e9962b0-537e-4422-9da8-08d90eeef2e5 x-ms-traffictypediagnostic: DB6PR04MB3125: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1169; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jhVLI71bzlcrrYQf+83ZNliiXkV8ajiZjMKTrSCRhP38VOk+5yRrRHJr+c1L0SdTBGixghYx+P34/PlQX2auH1hPGTus9GTMgWfifsCnCMcPBgGTiu6cGKK4vQ6TDe5oGRsRgJ5B3vKJNAnYk+/uFRtenqGKB0yLvos1VXkjgFSPL+TNJMLWtNF3be4E+AYsQMN3ip2qOrz/ldUk09RWYMtlKN9NwuW4WoxdF04Zvzn7qDGyNXNxlxQqUVsmk5SXR3izksl511JXQZXTcr8hiWvyLZ7m9bSSoqoleb3akft5yAl4vPitdZOZhF52LHm9vFvpFSXSkaJX7N+btPoMvCPeE2II9ZnEU/Jip150+T3Rc6m9rR7G/RPve7N4rXrWZuWNOjPFHkw0TQAJUr8VYtauJBflLNchN8Nf9N3nDLuH4EMdVprsR9Q5ZMwExyHcZH1AkKO1gNs/enEvoZW7ghcf4fs3ITgw7NES9tIcmc0B+sKLrv8afdZosfJ6VzNpCN+THd154MuI8sTdlVjE/t1B9mUWvsxG7KTHj/MMhydLP5u9VdpqTOruMCwvcJi4qCZ4xivZN+VLI0eQUq5htL3qAt7i2lBCD1N4Y8OjjD4= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR0402MB2760.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(39860400002)(396003)(376002)(136003)(346002)(110136005)(5660300002)(52536014)(76116006)(54906003)(4326008)(44832011)(9686003)(33656002)(8936002)(55016002)(53546011)(71200400001)(6506007)(316002)(122000001)(478600001)(2906002)(7696005)(66946007)(8676002)(66446008)(64756008)(7416002)(66556008)(86362001)(66476007)(26005)(186003)(38100700002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?utf-8?B?TkRwemQ2Yk1PakpqN1B1WGQzY1pBSU5EK1RqbHFVMkw3OEpVNUZkejNUMHF1?= =?utf-8?B?SlJsQWoxTVB5S0tvOHpWYnN4ZjdBclIvMjFRZ0JzS1NidTU4bVhMbEY3dG9X?= =?utf-8?B?Y20zV3NNZ0N5b1dmV1Z3Z2pHKzlhanJqTy9MaEZlQktFOTl3eDlIc3hOSW1s?= =?utf-8?B?TjRIZFRnd1ZvZTB6NmxzdE9UOTU2NU9ZM0lCN2VqR1htem9YbWNCU25GbWJX?= =?utf-8?B?cWVnZnJLZHo3REpJYks0ODhWQ3pxeXptY1NSYlhjQmtsbVhzSlpONnQwTW8y?= =?utf-8?B?aUpsb3ZPSjZ2MHJHeHNFaVFPWFVYVGpPd0pmME1IWmhyNWhaNzJXeGJ2MzZK?= =?utf-8?B?alhJK1Qwc1NHendMU0tTL3phTVRYNWM0SmN0a3cya0VuSVNCUTgvczNycXVT?= =?utf-8?B?V21lOE1Vdm8xZUJXUkY5d1FwL0wxcW5WQXpiSnN3ZVJnbUZxbG9abFJGZDF1?= =?utf-8?B?Z2FOR1h2WERUYUhyZ1NSc3BoL1VVZEthR0RhbW1KVnRmSFd5QzRCMTViR0Ja?= =?utf-8?B?ekhlRkVkemFpUjkwbzlPYUpGWUV2cU9MeXByR2lEUktqVTRYN1IzTzIxL2ZH?= =?utf-8?B?ZkFUZmJSRTVvUzhBQjMzQ0NmL1didDJEM2hFL3cyME4rUzZicTloY3d0N2xh?= =?utf-8?B?d0VFOFlwdFJiNDRxRHRLSmh3M1FvWHJZMEJNa2krTWJuYXZDeFA2MDdhSktn?= =?utf-8?B?RldtbDRiUHVtUGRLMjNKN2UvODBlY294RDBVeXBKVXdmNU1xR05jZW1wQmNR?= =?utf-8?B?eE44QkhPUFJJV1gxcmxCTXl1UURTSEQvZlB6dDFMTGY3MzVnNEYyYkJQWlN3?= =?utf-8?B?NHZyYktSK21mZll2YUFpRG9sZ1lxb1RzMWVxR2pFSUFmcmUwcTRRT29TZkx2?= =?utf-8?B?dUhzajhmRVBNUEkrWFNST3ZOQUhFY2padU1teGZMOHdRUThTTTlmZm5VSy8z?= =?utf-8?B?UTl4bkdSZGxaZ29tR2ZoMlF4UW1HejV2WnJPeU9YOG9TczREZFBqL0tIaXoy?= =?utf-8?B?UXVaWHRxdmlnYXhTa0tOdms2akEybUs2UllnT0lzY3ZIMjFQbW1PL3BoOS9w?= =?utf-8?B?TUlCUk9YV2FURFFqaHA3K2hpbzRheGx5QlltTVBaRzAzdnhJalowaFNyOGxK?= =?utf-8?B?cS9IaC9EK3I2M1Q5Z3JXcVdycmxJRTZUMVlYN0ZpeEZEQ3dwK01Na1VrTkhk?= =?utf-8?B?dHdSTWpqbDJrb2sreDlWaW0zbFBTaXd4N2ZlVU5HNnV1TUtVenVvM0NPY2JM?= =?utf-8?B?dVhuc2JIaGJaUGtLZnpqcmxqTWhrcG83TlE1akd4U01hY3NJUzBBamN6a2tM?= =?utf-8?B?TW9xMXdaTTMvOGVDdE1rb3dqVjEreEFwRlQyZjJLOTAzNmloZllzbVpyRVhI?= =?utf-8?B?NEpzdlJ0cDdIaEwyakRETDFxUlV5TVBGR1FsaWVPdy9xL0M1Q0Q1WmpWMGtV?= =?utf-8?B?akJDQ2MxSi9NcVRJY0V1M1NpN3JXR1hTZ1k0MUNkN0IzUVFtckduZFl5eHRs?= =?utf-8?B?T1JDUGRXWmpzS0xRL2MxLzIyc3MyUFBkeWh5cGZ6bjFOdTh4WFN0WG0wRS9E?= =?utf-8?B?SllORm9TRmkxdUwybGdtc2x0ZmVWZklWQnJQbStXcGNjVHZzU0RuK2JGbW5U?= =?utf-8?B?MGp1U2tjd2ZaV3hraEllMVYvUXo2Z0lzcC96UHFsWVpXQ21LaElZVk5qS1I1?= =?utf-8?B?bEkybUFpR0pOM1A3cHJGUGt4UDNpOVdGVDhIb1VQOU9LZXhBZmR6eGVGUU83?= =?utf-8?Q?LXLul/AcD1O2+sJJ9Q=3D?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DB6PR0402MB2760.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0e9962b0-537e-4422-9da8-08d90eeef2e5 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 May 2021 11:22:48.8775 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pIZ0jXbHWO0YhJ/f+CJ9HMgMIyqqWfhoKFa+dxy9N8768Ihc1UspR7TtCwyxEUGUEdqsJ1kM31Ew3NmNic17yw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR04MB3125 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org PiBTdWJqZWN0OiBSZTogW1BBVENIIFYyIDQvNF0gc29jOiBpbXg6IEFkZCBibGstY3RsIGRyaXZl ciBmb3IgaS5NWDhNTQ0KPiANCj4gSGkgUGVuZywNCj4gDQo+IE9uIEZyaSwgQXByIDMwLCAyMDIx IGF0IDE6NTYgQU0gUGVuZyBGYW4gKE9TUykgPHBlbmcuZmFuQG9zcy5ueHAuY29tPg0KPiB3cm90 ZToNCj4gDQo+ID4gK3N0YXRpYyBpbnQgaW14OG1tX2Jsa19jdGxfcHJvYmUoc3RydWN0IHBsYXRm b3JtX2RldmljZSAqcGRldikgew0KPiA+ICsgICAgICAgc3RydWN0IGRldmljZSAqZGV2ID0gJnBk ZXYtPmRldjsNCj4gPiArICAgICAgIGNvbnN0IHN0cnVjdCBpbXhfYmxrX2N0bF9kZXZfZGF0YSAq ZGV2X2RhdGEgPQ0KPiBvZl9kZXZpY2VfZ2V0X21hdGNoX2RhdGEoZGV2KTsNCj4gPiArICAgICAg IHN0cnVjdCByZWdtYXAgKnJlZ21hcDsNCj4gPiArICAgICAgIHN0cnVjdCByZXNvdXJjZSAqcmVz Ow0KPiA+ICsgICAgICAgc3RydWN0IGlteF9ibGtfY3RsICpjdGw7DQo+ID4gKyAgICAgICB2b2lk IF9faW9tZW0gKmJhc2U7DQo+ID4gKw0KPiA+ICsgICAgICAgY3RsID0gZGV2bV9remFsbG9jKGRl diwgc2l6ZW9mKCpjdGwpLCBHRlBfS0VSTkVMKTsNCj4gPiArICAgICAgIGlmICghY3RsKQ0KPiA+ ICsgICAgICAgICAgICAgICByZXR1cm4gLUVOT01FTTsNCj4gPiArDQo+ID4gKyAgICAgICByZXMg PSBwbGF0Zm9ybV9nZXRfcmVzb3VyY2UocGRldiwgSU9SRVNPVVJDRV9NRU0sIDApOw0KPiA+ICsg ICAgICAgYmFzZSA9IGRldm1faW9yZW1hcF9yZXNvdXJjZShkZXYsIHJlcyk7DQo+ID4gKyAgICAg ICBpZiAoSVNfRVJSKGJhc2UpKQ0KPiA+ICsgICAgICAgICAgICAgICByZXR1cm4gUFRSX0VSUihi YXNlKTsNCj4gPiArDQo+ID4gKyAgICAgICByZWdtYXAgPSBkZXZtX3JlZ21hcF9pbml0X21taW8o ZGV2LCBiYXNlLA0KPiAmZGV2X2RhdGEtPmNvbmZpZyk7DQo+ID4gKyAgICAgICBpZiAoSVNfRVJS KHJlZ21hcCkpDQo+ID4gKyAgICAgICAgICAgICAgIHJldHVybiBQVFJfRVJSKHJlZ21hcCk7DQo+ ID4gKw0KPiA+ICsgICAgICAgY3RsLT5yZWdtYXAgPSByZWdtYXA7DQo+ID4gKyAgICAgICBjdGwt PmRldiA9IGRldjsNCj4gPiArICAgICAgIGF0b21pY19zZXQoJmN0bC0+cG93ZXJfY291bnQsIDAp Ow0KPiA+ICsNCj4gPiArICAgICAgIGN0bC0+bnVtX2Nsa3MgPSBkZXZtX2Nsa19idWxrX2dldF9h bGwoZGV2LCAmY3RsLT5jbGtzKTsNCj4gPiArICAgICAgIGlmIChjdGwtPm51bV9jbGtzIDwgMCkN Cj4gPiArICAgICAgICAgICAgICAgcmV0dXJuIGN0bC0+bnVtX2Nsa3M7DQo+ID4gKw0KPiA+ICsg ICAgICAgZGV2X3NldF9kcnZkYXRhKGRldiwgY3RsKTsNCj4gPiArICAgICAgIGN0bC0+ZGV2X2Rh dGEgPSBvZl9kZXZpY2VfZ2V0X21hdGNoX2RhdGEoZGV2KTsNCj4gDQo+IE5vIG5lZWQgdG8gY2Fs bCBvZl9kZXZpY2VfZ2V0X21hdGNoX2RhdGEoKSB0d2ljZS4gWW91IGNvdWxkIGRvOg0KPiANCj4g Y3RsLT5kZXZfZGF0YSA9IGRldl9kYXRhOw0KDQpGaXggaW4gVjMuDQoNClRoYW5rcywNClBlbmcu DQoNCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 771F3C433ED for ; Tue, 4 May 2021 11:24:38 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE682613BA for ; Tue, 4 May 2021 11:24:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE682613BA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References:Message-ID:Date: Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gONimKaVSX5ylur3B66I9J1CBNpFaXKzays3AJJ0+4k=; b=FtMFng9teQQ3j2VIsHEi2wue3 w5AAUypC7RNQ7m09yK3HVs15IBUd7lVxYBZ3kRS26702i65mWr6Y93Bxuj67h2RNdQgdmLqdoUgZ/ yswOcegU7Ud86fMkWxMhRAtc3y5pQQsliDw3aCVqnmroXgr6/edwf0S3PdEXUK6N4MXfCHwHBU3TN mXmNx1NPPcP2s5adYnAOllti/2/KuM6RvlLGil5KGMHoJZEI0fMlmI3VRsbus+dD7Kdchfw105mBE W5RJUqC/H8It/J62U23zuZPJH1xs6zKEsCgr0rZnjZTumTF+3IuDAMMfbPjru1c3RJgBO5E/7E7WM BG89AqTWA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1ldt8m-00G4FQ-So; Tue, 04 May 2021 11:23:01 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ldt8k-00G4Es-9Y for linux-arm-kernel@desiato.infradead.org; Tue, 04 May 2021 11:22:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version: Content-Transfer-Encoding:Content-Type:In-Reply-To:References:Message-ID:Date :Subject:CC:To:From:Sender:Reply-To:Content-ID:Content-Description; bh=uKo/FrhTur0NynfMbqP9HpYxZxTxfslgyYjpvVO5fQA=; b=a6UGGNl2FYZ5EmJqm6x+UCYwpO YmFaBcQfDZqef/i0VozEITSW5BzaB0T38sTmiOZweOcJWHi0wlTvnivWLae6IQps63gsNEuJ4j2lw VIlCKXnAU3NSO3j18/SbqUj4uBi68ubULf1UKRz9d8zsi2AQTKlLmATHqwX0jzafaF1dzbXaoF2Cd keqgaulrBQ2UWPQ49qdV+tt/F8BJ5TdgN1Zhiy43fC7RKHoQ78kvZafIBc2lmuCMJzE4kQuuuF7VP qylVoucVTlpvbfv/GHvz4+2FdEQEzhOg0d9sFLBlxY50OROCoD90/xUwrOioZ0NJoWoqibs+0KrqF HoWscRyg==; Received: from mail-vi1eur05on2087.outbound.protection.outlook.com ([40.107.21.87] helo=EUR05-VI1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ldt8h-003vkP-J9 for linux-arm-kernel@lists.infradead.org; Tue, 04 May 2021 11:22:57 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LDPvbSTFDkB+QG2wnN50wTJo2TMoEC4OPxtjv3GUFRhO214jYSk7XaslUjTDsIXZ/qHGoXTjxUMIZ4masMb+twK6JmK0DV0wQPaHGdLyyc+ppXt25pLqrRPwcrxKv2oXRKLJhpiGgFDgXZ3t3LRYdVtEBD/5Bek8Cy7vrEJwT523puVfa0vrzRZLZCrKm6dFvW9P82Rcx2KxoGe2vJn/vX+zTHLDB8dKQHd50rUcRVHZ2Jgk0QF1o2iSteDjU9siv6Wg4/E0pLKB8ZVIItik+s1o2E5KX5s3UB5htXJHVQlVce1L8RBfV7Q5L76RQk7kexjW6mLYODPFRvXAnW8G2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uKo/FrhTur0NynfMbqP9HpYxZxTxfslgyYjpvVO5fQA=; b=dthI8IDn7KpCLIZggTRX11YKZI6tYMk8MvOTuZcHmk/qRJ01EK6Nv9Yap+yEWeowo9gWVrurLvgaMYdfaSuGfpB/zAAfIHhm9apAkEvaugKQDAZwlXPTW7wdUnsN4l9PoBuiBmtnYzt14vqBtJSBGyRn98MjeAkaQ9snZOQKhaeQZhWO73nILsIgIsZoM8jbRe0jds4ta3ceDqdPu9I7Yw4SRzKX2zToynVRxnUvW4DcXWElVdSeALL7W9NzILa8kBokfmW84ymSHQt39FUvGP0EPI99nmS9Rz9OGzsOGVhfOIfkyaHdJhPcnd6Y2MFXQGlGsgBi7DZeb/A7OYMXJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uKo/FrhTur0NynfMbqP9HpYxZxTxfslgyYjpvVO5fQA=; b=poDp8u7er7fCCjC3xug9lbSCkOvasHCdW3l9RhOE794uhf5Y2zI2PNj+wMAI0PgSm7+yrWB0fo6d7Dq7e7Wb5z2a93iaTaNfQmjDrTIw1yDF9FaLyKozthKAXGUyrWZFXM1u9EmzZ+cVAuOfPIBH/HXTVMNEYOFd863BnPt0uaY= Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) by DB6PR04MB3125.eurprd04.prod.outlook.com (2603:10a6:6:11::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.23; Tue, 4 May 2021 11:22:49 +0000 Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64]) by DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64%8]) with mapi id 15.20.4065.039; Tue, 4 May 2021 11:22:48 +0000 From: Peng Fan To: Fabio Estevam , "Peng Fan (OSS)" CC: Rob Herring , Shawn Guo , Sascha Hauer , Sascha Hauer , dl-linux-imx , Philipp Zabel , Lucas Stach , Krzysztof Kozlowski , =?utf-8?B?R3VpZG8gR8O8bnRoZXI=?= , Marek Vasut , Andrey Smirnov , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-kernel , Jacky Bai , Schrempf Frieder , Adam Ford , Abel Vesa Subject: RE: [PATCH V2 4/4] soc: imx: Add blk-ctl driver for i.MX8MM Thread-Topic: [PATCH V2 4/4] soc: imx: Add blk-ctl driver for i.MX8MM Thread-Index: AQHXPX0eRMyCb+5Z90CURUSnlReObarTMhSAgAACgOA= Date: Tue, 4 May 2021 11:22:48 +0000 Message-ID: References: <20210430052746.10815-1-peng.fan@oss.nxp.com> <20210430052746.10815-5-peng.fan@oss.nxp.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [58.223.139.112] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0e9962b0-537e-4422-9da8-08d90eeef2e5 x-ms-traffictypediagnostic: DB6PR04MB3125: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1169; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jhVLI71bzlcrrYQf+83ZNliiXkV8ajiZjMKTrSCRhP38VOk+5yRrRHJr+c1L0SdTBGixghYx+P34/PlQX2auH1hPGTus9GTMgWfifsCnCMcPBgGTiu6cGKK4vQ6TDe5oGRsRgJ5B3vKJNAnYk+/uFRtenqGKB0yLvos1VXkjgFSPL+TNJMLWtNF3be4E+AYsQMN3ip2qOrz/ldUk09RWYMtlKN9NwuW4WoxdF04Zvzn7qDGyNXNxlxQqUVsmk5SXR3izksl511JXQZXTcr8hiWvyLZ7m9bSSoqoleb3akft5yAl4vPitdZOZhF52LHm9vFvpFSXSkaJX7N+btPoMvCPeE2II9ZnEU/Jip150+T3Rc6m9rR7G/RPve7N4rXrWZuWNOjPFHkw0TQAJUr8VYtauJBflLNchN8Nf9N3nDLuH4EMdVprsR9Q5ZMwExyHcZH1AkKO1gNs/enEvoZW7ghcf4fs3ITgw7NES9tIcmc0B+sKLrv8afdZosfJ6VzNpCN+THd154MuI8sTdlVjE/t1B9mUWvsxG7KTHj/MMhydLP5u9VdpqTOruMCwvcJi4qCZ4xivZN+VLI0eQUq5htL3qAt7i2lBCD1N4Y8OjjD4= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0402MB2760.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(39860400002)(396003)(376002)(136003)(346002)(110136005)(5660300002)(52536014)(76116006)(54906003)(4326008)(44832011)(9686003)(33656002)(8936002)(55016002)(53546011)(71200400001)(6506007)(316002)(122000001)(478600001)(2906002)(7696005)(66946007)(8676002)(66446008)(64756008)(7416002)(66556008)(86362001)(66476007)(26005)(186003)(38100700002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?utf-8?B?TkRwemQ2Yk1PakpqN1B1WGQzY1pBSU5EK1RqbHFVMkw3OEpVNUZkejNUMHF1?= =?utf-8?B?SlJsQWoxTVB5S0tvOHpWYnN4ZjdBclIvMjFRZ0JzS1NidTU4bVhMbEY3dG9X?= =?utf-8?B?Y20zV3NNZ0N5b1dmV1Z3Z2pHKzlhanJqTy9MaEZlQktFOTl3eDlIc3hOSW1s?= =?utf-8?B?TjRIZFRnd1ZvZTB6NmxzdE9UOTU2NU9ZM0lCN2VqR1htem9YbWNCU25GbWJX?= =?utf-8?B?cWVnZnJLZHo3REpJYks0ODhWQ3pxeXptY1NSYlhjQmtsbVhzSlpONnQwTW8y?= =?utf-8?B?aUpsb3ZPSjZ2MHJHeHNFaVFPWFVYVGpPd0pmME1IWmhyNWhaNzJXeGJ2MzZK?= =?utf-8?B?alhJK1Qwc1NHendMU0tTL3phTVRYNWM0SmN0a3cya0VuSVNCUTgvczNycXVT?= =?utf-8?B?V21lOE1Vdm8xZUJXUkY5d1FwL0wxcW5WQXpiSnN3ZVJnbUZxbG9abFJGZDF1?= =?utf-8?B?Z2FOR1h2WERUYUhyZ1NSc3BoL1VVZEthR0RhbW1KVnRmSFd5QzRCMTViR0Ja?= =?utf-8?B?ekhlRkVkemFpUjkwbzlPYUpGWUV2cU9MeXByR2lEUktqVTRYN1IzTzIxL2ZH?= =?utf-8?B?ZkFUZmJSRTVvUzhBQjMzQ0NmL1didDJEM2hFL3cyME4rUzZicTloY3d0N2xh?= =?utf-8?B?d0VFOFlwdFJiNDRxRHRLSmh3M1FvWHJZMEJNa2krTWJuYXZDeFA2MDdhSktn?= =?utf-8?B?RldtbDRiUHVtUGRLMjNKN2UvODBlY294RDBVeXBKVXdmNU1xR05jZW1wQmNR?= =?utf-8?B?eE44QkhPUFJJV1gxcmxCTXl1UURTSEQvZlB6dDFMTGY3MzVnNEYyYkJQWlN3?= =?utf-8?B?NHZyYktSK21mZll2YUFpRG9sZ1lxb1RzMWVxR2pFSUFmcmUwcTRRT29TZkx2?= =?utf-8?B?dUhzajhmRVBNUEkrWFNST3ZOQUhFY2padU1teGZMOHdRUThTTTlmZm5VSy8z?= =?utf-8?B?UTl4bkdSZGxaZ29tR2ZoMlF4UW1HejV2WnJPeU9YOG9TczREZFBqL0tIaXoy?= =?utf-8?B?UXVaWHRxdmlnYXhTa0tOdms2akEybUs2UllnT0lzY3ZIMjFQbW1PL3BoOS9w?= =?utf-8?B?TUlCUk9YV2FURFFqaHA3K2hpbzRheGx5QlltTVBaRzAzdnhJalowaFNyOGxK?= =?utf-8?B?cS9IaC9EK3I2M1Q5Z3JXcVdycmxJRTZUMVlYN0ZpeEZEQ3dwK01Na1VrTkhk?= =?utf-8?B?dHdSTWpqbDJrb2sreDlWaW0zbFBTaXd4N2ZlVU5HNnV1TUtVenVvM0NPY2JM?= =?utf-8?B?dVhuc2JIaGJaUGtLZnpqcmxqTWhrcG83TlE1akd4U01hY3NJUzBBamN6a2tM?= =?utf-8?B?TW9xMXdaTTMvOGVDdE1rb3dqVjEreEFwRlQyZjJLOTAzNmloZllzbVpyRVhI?= =?utf-8?B?NEpzdlJ0cDdIaEwyakRETDFxUlV5TVBGR1FsaWVPdy9xL0M1Q0Q1WmpWMGtV?= =?utf-8?B?akJDQ2MxSi9NcVRJY0V1M1NpN3JXR1hTZ1k0MUNkN0IzUVFtckduZFl5eHRs?= =?utf-8?B?T1JDUGRXWmpzS0xRL2MxLzIyc3MyUFBkeWh5cGZ6bjFOdTh4WFN0WG0wRS9E?= =?utf-8?B?SllORm9TRmkxdUwybGdtc2x0ZmVWZklWQnJQbStXcGNjVHZzU0RuK2JGbW5U?= =?utf-8?B?MGp1U2tjd2ZaV3hraEllMVYvUXo2Z0lzcC96UHFsWVpXQ21LaElZVk5qS1I1?= =?utf-8?B?bEkybUFpR0pOM1A3cHJGUGt4UDNpOVdGVDhIb1VQOU9LZXhBZmR6eGVGUU83?= =?utf-8?Q?LXLul/AcD1O2+sJJ9Q=3D?= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DB6PR0402MB2760.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0e9962b0-537e-4422-9da8-08d90eeef2e5 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 May 2021 11:22:48.8775 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pIZ0jXbHWO0YhJ/f+CJ9HMgMIyqqWfhoKFa+dxy9N8768Ihc1UspR7TtCwyxEUGUEdqsJ1kM31Ew3NmNic17yw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR04MB3125 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210504_042255_659028_D5F81777 X-CRM114-Status: GOOD ( 15.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > Subject: Re: [PATCH V2 4/4] soc: imx: Add blk-ctl driver for i.MX8MM > > Hi Peng, > > On Fri, Apr 30, 2021 at 1:56 AM Peng Fan (OSS) > wrote: > > > +static int imx8mm_blk_ctl_probe(struct platform_device *pdev) { > > + struct device *dev = &pdev->dev; > > + const struct imx_blk_ctl_dev_data *dev_data = > of_device_get_match_data(dev); > > + struct regmap *regmap; > > + struct resource *res; > > + struct imx_blk_ctl *ctl; > > + void __iomem *base; > > + > > + ctl = devm_kzalloc(dev, sizeof(*ctl), GFP_KERNEL); > > + if (!ctl) > > + return -ENOMEM; > > + > > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > + base = devm_ioremap_resource(dev, res); > > + if (IS_ERR(base)) > > + return PTR_ERR(base); > > + > > + regmap = devm_regmap_init_mmio(dev, base, > &dev_data->config); > > + if (IS_ERR(regmap)) > > + return PTR_ERR(regmap); > > + > > + ctl->regmap = regmap; > > + ctl->dev = dev; > > + atomic_set(&ctl->power_count, 0); > > + > > + ctl->num_clks = devm_clk_bulk_get_all(dev, &ctl->clks); > > + if (ctl->num_clks < 0) > > + return ctl->num_clks; > > + > > + dev_set_drvdata(dev, ctl); > > + ctl->dev_data = of_device_get_match_data(dev); > > No need to call of_device_get_match_data() twice. You could do: > > ctl->dev_data = dev_data; Fix in V3. Thanks, Peng. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel