All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peng Fan <peng.fan@nxp.com>
To: u-boot@lists.denx.de
Subject: [PATCH v3 1/5] imx: mkimage_fit_atf: Fix FIT image if BL31.bin missing
Date: Tue, 26 May 2020 12:53:31 +0000	[thread overview]
Message-ID: <DB6PR0402MB2760FBAEA8D7AD7C4EA2E11688B00@DB6PR0402MB2760.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20200526104412.3666210-2-heiko@sntech.de>

> Subject: [PATCH v3 1/5] imx: mkimage_fit_atf: Fix FIT image if BL31.bin
> missing
> 
> From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
> 
> Right now if its bl31.bin is missing, the imx make_fit_atf.sh does return
> "sucessful" without generating an .its source file, which makes autobuilders
> unhappy.
> 
> So this change is similar to Tom Rini's
> commit 4c78028737c3 ("mksunxi_fit_atf.sh: Allow for this to complete when
> bl31.bin is missing") in that it changes the behaviour to a warning and still lets
> the script generate a usable u-boot.its and thus also lets the u-boot.itb get
> build successfully
> 
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: uboot-imx at nxp.com
> Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
> ---
> changes in v3:
> - new patch
> 
>  arch/arm/mach-imx/mkimage_fit_atf.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-imx/mkimage_fit_atf.sh
> b/arch/arm/mach-imx/mkimage_fit_atf.sh
> index dd1ca5ad3f..2224d85281 100755
> --- a/arch/arm/mach-imx/mkimage_fit_atf.sh
> +++ b/arch/arm/mach-imx/mkimage_fit_atf.sh
> @@ -12,8 +12,8 @@
>  [ -z "$BL33_LOAD_ADDR" ] && BL33_LOAD_ADDR="0x40200000"
> 
>  if [ ! -f $BL31 ]; then
> -	echo "ERROR: BL31 file $BL31 NOT found" >&2
> -	exit 0
> +	echo "WARNING: BL31 file $BL31 NOT found, resulting binary is
> not-functional" >&2
> +	BL31=/dev/null
>  else
>  	echo "$BL31 size: " >&2
>  	ls -lct $BL31 | awk '{print $5}' >&2

Reviewed-by: Peng Fan <peng.fan@nxp.com>

  reply	other threads:[~2020-05-26 12:53 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-26 10:44 [PATCH v3 0/5] rockchip: make it possible to sign the u-boot.itb Heiko Stuebner
2020-05-26 10:44 ` [PATCH v3 1/5] imx: mkimage_fit_atf: Fix FIT image if BL31.bin missing Heiko Stuebner
2020-05-26 12:53   ` Peng Fan [this message]
2020-05-26 10:44 ` [PATCH v3 2/5] mkimage: fit_image: handle multiple errors when writing signatures Heiko Stuebner
2020-05-31 14:07   ` Simon Glass
2020-06-19 10:47     ` Heiko Stuebner
2020-05-26 10:44 ` [PATCH v3 3/5] spl: fit: enable signing a generated u-boot.itb Heiko Stuebner
2020-05-31 14:07   ` Simon Glass
2020-05-26 10:44 ` [PATCH v3 4/5] spl: fit: add Kconfig option to specify key-hint for fit_generator Heiko Stuebner
2020-05-26 10:44 ` [PATCH v3 5/5] rockchip: make_fit_atf: add signature handling Heiko Stuebner
2020-05-31 14:07   ` Simon Glass
2020-05-31  8:28 ` [PATCH v3 0/5] rockchip: make it possible to sign the u-boot.itb Kever Yang
2020-06-19 10:47   ` Heiko Stuebner
2020-06-26  1:12     ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB6PR0402MB2760FBAEA8D7AD7C4EA2E11688B00@DB6PR0402MB2760.eurprd04.prod.outlook.com \
    --to=peng.fan@nxp.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.