From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Liming Sun Subject: Re: [PATCH v8 1/2] platform/mellanox: Add TmFifo driver for Mellanox BlueField Soc Date: Wed, 13 Feb 2019 13:34:53 +0000 Message-ID: References: <1548696487-8840-1-git-send-email-lsun@mellanox.com> <1548696487-8840-2-git-send-email-lsun@mellanox.com>, In-Reply-To: Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_DB6PR05MB3223AD04997CCB8D58D48ED7A1660DB6PR05MB3223eurp_" MIME-Version: 1.0 To: Andy Shevchenko Cc: Rob Herring , Mark Rutland , Arnd Bergmann , David Woods , Andy Shevchenko , Darren Hart , Vadim Pasternak , devicetree , Linux Kernel Mailing List , Platform Driver List-ID: --_000_DB6PR05MB3223AD04997CCB8D58D48ED7A1660DB6PR05MB3223eurp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Thanks Andy! V9 has been posted with the devm_ changes and coding style fixes according = to the received comments in the other patch. It also has changes for commen= ts from Vadim during Mellanox internal review. Regards, Liming ________________________________ From: Andy Shevchenko Sent: Tuesday, January 29, 2019 5:06 PM To: Liming Sun Cc: Rob Herring; Mark Rutland; Arnd Bergmann; David Woods; Andy Shevchenko;= Darren Hart; Vadim Pasternak; devicetree; Linux Kernel Mailing List; Platf= orm Driver Subject: Re: [PATCH v8 1/2] platform/mellanox: Add TmFifo driver for Mellan= ox BlueField Soc On Mon, Jan 28, 2019 at 7:28 PM Liming Sun wrote: > > This commit adds the TmFifo platform driver for Mellanox BlueField > Soc. TmFifo is a shared FIFO which enables external host machine > to exchange data with the SoC via USB or PCIe. The driver is based > on virtio framework and has console and network access enabled. > > Reviewed-by: David Woods > Signed-off-by: Liming Sun Please, go through this series taking into account review I just did for your another patch. On top of that, see recent (for few years I think) drivers what modern APIs they are using, e.g. devm_. -- With Best Regards, Andy Shevchenko --_000_DB6PR05MB3223AD04997CCB8D58D48ED7A1660DB6PR05MB3223eurp_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable

Thanks Andy!


V9 has been posted with the devm_= changes and coding style fixes according to the received comments in the o= ther patch. It also has changes for comments from Vadim during Mellanox int= ernal review.


Regards,

Liming



From: Andy Shevchenko <= ;andy.shevchenko@gmail.com>
Sent: Tuesday, January 29, 2019 5:06 PM
To: Liming Sun
Cc: Rob Herring; Mark Rutland; Arnd Bergmann; David Woods; Andy Shev= chenko; Darren Hart; Vadim Pasternak; devicetree; Linux Kernel Mailing List= ; Platform Driver
Subject: Re: [PATCH v8 1/2] platform/mellanox: Add TmFifo driver for= Mellanox BlueField Soc
 
On Mon, Jan 28, 2019 at 7:28 PM Liming Sun <lsu= n@mellanox.com> wrote:
>
> This commit adds the TmFifo platform driver for Mellanox BlueField
> Soc. TmFifo is a shared FIFO which enables external host machine
> to exchange data with the SoC via USB or PCIe. The driver is based
> on virtio framework and has console and network access enabled.
>
> Reviewed-by: David Woods <dwoods@mellanox.com>
> Signed-off-by: Liming Sun <lsun@mellanox.com>


Please, go through this series taking into account review I just did
for your another patch.

On top of that, see recent (for few years I think) drivers what modern
APIs they are using, e.g. devm_.

--
With Best Regards,
Andy Shevchenko
--_000_DB6PR05MB3223AD04997CCB8D58D48ED7A1660DB6PR05MB3223eurp_--