From mboxrd@z Thu Jan 1 00:00:00 1970 From: York Sun Date: Tue, 25 Sep 2018 18:48:42 +0000 Subject: [U-Boot] [PATCH v3 6/8] powerpc: mpc85xx: Use binman to embed dtb inside U-Boot References: <1535990712-8359-1-git-send-email-jagdish.gediya@nxp.com> <1535990712-8359-7-git-send-email-jagdish.gediya@nxp.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 09/02/2018 10:08 PM, Jagdish Gediya wrote: > Below is the sequence to embed dtb inside U-Boot, > 1. Remove bootpg and resetvec section if needed > 2. Append dtb > 3. Append bootpg and resetvec section back if removed in step 1 > > Above procedure is required only when CONFIG_MPC85xx and > CONFIG_OF_SEPARATE are defined. > > Add new config CONFIG_MPC85XX_HAVE_RESET_VECTOR to indicate that > image has resetvec section. Step 1 and step 3 described above are > required only if this config is y. > > Signed-off-by: Jagdish Gediya > --- > Changes for v2: > - Don't change the generic target > - Add new config option to use binman > > Changes for v3: > - Commit message change('u-boot' -> 'U-Boot') > > Makefile | 23 ++++++++++++++++++++++- > arch/powerpc/cpu/mpc85xx/Kconfig | 4 ++++ > 2 files changed, 26 insertions(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index b5bf8ab..03baa74 100644 > --- a/Makefile > +++ b/Makefile > @@ -861,6 +861,10 @@ ifneq ($(CONFIG_SYS_INIT_SP_BSS_OFFSET),) > ALL-y += init_sp_bss_offset_check > endif > > +ifeq ($(CONFIG_MPC85xx)$(CONFIG_OF_SEPARATE),yy) > +ALL-y += u-boot-with-dtb.bin > +endif > + One thing confuses me is the output file. My understand is we will use u-boot-with-dtb.bin file. Other files are intermediate files. It would be helpful to explain each output file, especially for debugging, and let other know we switch from one file to another after this patch set. CONFIG_OF_SEPARATE seems not be selected explicitly anywhere. Are we relying on the first choice to be selected automatically? Is it guaranteed? York