From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rajesh Bhagat <rajesh.bhagat@nxp.com>
Date: Thu, 4 Oct 2018 11:30:19 +0000
Subject: [U-Boot] [PATCH 15/53] net: fm: add TFABOOT support
In-Reply-To: <DB7PR04MB4298CB41CFC32A95E750AB849AE90@DB7PR04MB4298.eurprd04.prod.outlook.com>
References: <20181003113736.14981-1-rajesh.bhagat@nxp.com>
 <20181003113736.14981-16-rajesh.bhagat@nxp.com>
 <DB7PR04MB4298CB41CFC32A95E750AB849AE90@DB7PR04MB4298.eurprd04.prod.outlook.com>
Message-ID: <DB7PR04MB48571E06D903FE85E989C043E3EA0@DB7PR04MB4857.eurprd04.prod.outlook.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de



> -----Original Message-----
> From: York Sun
> Sent: Wednesday, October 3, 2018 9:49 PM
> To: Rajesh Bhagat <rajesh.bhagat@nxp.com>; u-boot at lists.denx.de
> Cc: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>; Pankit Garg
> <pankit.garg@nxp.com>
> Subject: Re: [PATCH 15/53] net: fm: add TFABOOT support
> 
> On 10/03/2018 04:39 AM, Rajesh Bhagat wrote:
> > Adds TFABOOT support and allows to pick FMAN firmware on basis of boot
> > source.
> >
> > Signed-off-by: Pankit Garg <pankit.garg@nxp.com>
> > Signed-off-by: Rajesh Bhagat <rajesh.bhagat@nxp.com>
> > ---
> >  drivers/net/fm/fm.c | 104
> > ++++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 104 insertions(+)
> >
> > diff --git a/drivers/net/fm/fm.c b/drivers/net/fm/fm.c index
> > 3327073bf1..427ea1a627 100644
> > --- a/drivers/net/fm/fm.c
> > +++ b/drivers/net/fm/fm.c
> > @@ -11,6 +11,15 @@
> >  #include "fm.h"
> >  #include <fsl_qe.h>		/* For struct qe_firmware */
> >
> > +#ifdef CONFIG_TFABOOT
> 
> Same here. Do not use ifdef if you don't have to.
> 

Will take care in v2. 

> York