From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rajesh Bhagat Date: Thu, 4 Oct 2018 11:30:25 +0000 Subject: [U-Boot] [PATCH 16/53] drivers: qe: add TFABOOT support In-Reply-To: References: <20181003113736.14981-1-rajesh.bhagat@nxp.com> <20181003113736.14981-17-rajesh.bhagat@nxp.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de > -----Original Message----- > From: York Sun > Sent: Wednesday, October 3, 2018 9:50 PM > To: Rajesh Bhagat ; u-boot at lists.denx.de > Cc: Prabhakar Kushwaha ; Pankit Garg > > Subject: Re: [PATCH 16/53] drivers: qe: add TFABOOT support > > On 10/03/2018 04:39 AM, Rajesh Bhagat wrote: > > Adds TFABOOT support and allows to pick QE firmware on basis of boot > > source. > > > > Signed-off-by: Pankit Garg > > Signed-off-by: Rajesh Bhagat > > --- > > drivers/qe/qe.c | 81 > > +++++++++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 81 insertions(+) > > > > diff --git a/drivers/qe/qe.c b/drivers/qe/qe.c index > > 7654df8008..d7e3a1b923 100644 > > --- a/drivers/qe/qe.c > > +++ b/drivers/qe/qe.c > > @@ -17,9 +17,17 @@ > > #include > > #endif > > > > +#ifdef CONFIG_TFABOOT > > +#include > > +/* required to include IFC and QSPI base address */ #include > > + #include #include > > > +#else > > You have many of this ifdef. Please fix all if you don't have to use ifdef. > Will take care in v2. > York