From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shahaf Shuler <shahafs@mellanox.com>
Subject: Re: [PATCH 3/4] ethdev: add Rx offload outer L4 checksum
 definitions
Date: Sun, 16 Sep 2018 05:53:30 +0000
Message-ID: <DB7PR05MB44264203F0B2C7B1C6E731FDC31F0@DB7PR05MB4426.eurprd05.prod.outlook.com>
References: <20180913134707.23698-1-jerin.jacob@caviumnetworks.com>
 <20180913134707.23698-3-jerin.jacob@caviumnetworks.com>
 <DB7PR05MB44260F75F455AA767A18C331C31A0@DB7PR05MB4426.eurprd05.prod.outlook.com>
 <20180914030541.GA3822@jerin>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: Wenzhuo Lu <wenzhuo.lu@intel.com>, Jingjing Wu <jingjing.wu@intel.com>,
 Bernard Iremonger <bernard.iremonger@intel.com>, John McNamara
 <john.mcnamara@intel.com>, Marko Kovacevic <marko.kovacevic@intel.com>,
 Thomas Monjalon <thomas@monjalon.net>, Ferruh Yigit <ferruh.yigit@intel.com>,
 Andrew Rybchenko <arybchenko@solarflare.com>, Olivier Matz
 <olivier.matz@6wind.com>, "dev@dpdk.org" <dev@dpdk.org>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01on0045.outbound.protection.outlook.com [104.47.2.45])
 by dpdk.org (Postfix) with ESMTP id 133582B9E
 for <dev@dpdk.org>; Sun, 16 Sep 2018 07:53:32 +0200 (CEST)
In-Reply-To: <20180914030541.GA3822@jerin>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Friday, September 14, 2018 6:06 AM, Jerin Jacob:
> Subject: Re: [dpdk-dev] [PATCH 3/4] ethdev: add Rx offload outer L4
> checksum definitions
>=20
> -----Original Message-----
> > Date: Thu, 13 Sep 2018 17:24:26 +0000
> > From: Shahaf Shuler <shahafs@mellanox.com>
> > To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, Wenzhuo Lu
> > <wenzhuo.lu@intel.com>, Jingjing Wu <jingjing.wu@intel.com>, Bernard
> > Iremonger <bernard.iremonger@intel.com>, John McNamara
> > <john.mcnamara@intel.com>, Marko Kovacevic
> > <marko.kovacevic@intel.com>,  Thomas Monjalon
> <thomas@monjalon.net>,
> > Ferruh Yigit  <ferruh.yigit@intel.com>, Andrew Rybchenko
> > <arybchenko@solarflare.com>,  Olivier Matz <olivier.matz@6wind.com>
> > CC: "dev@dpdk.org" <dev@dpdk.org>
> > Subject: RE: [dpdk-dev] [PATCH 3/4] ethdev: add Rx offload outer L4
> > checksum definitions
> >
> >
> > Thursday, September 13, 2018 4:47 PM, Jerin Jacob:
> > > Subject: [dpdk-dev] [PATCH 3/4] ethdev: add Rx offload outer L4
> > > checksum definitions
> > >
> > > Introduced DEV_RX_OFFLOAD_OUTER_UDP_CKSUM,
> > > DEV_RX_OFFLOAD_OUTER_TCP_CKSUM and
> DEV_RX_OFFLOAD_OUTER_SCTP_CKSUM
> > > offload flags and
> >
> > Out of curiosity, which TCP based tunnels you target with this current
> patchset?
>=20
> I am not aware of any _popular_/_non proprietary_  protocols except SSTP
> for VPN.

And your device can support such protocol inner and outer checksum check?
>>From what I see the inner packet of SSTP is encrypted by SSL.

So for outer and inner checksum validation device will need to:
1. compute the outer TCP checksum
2. if valid decrypt the inner PPP packet
3. compute the PPP checksum.=20