All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shahaf Shuler <shahafs@mellanox.com>
To: Luca Boccassi <bluca@debian.org>,
	Timothy Redaelli <tredaelli@redhat.com>,
	Yongseok Koh <yskoh@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	Adrien Mazarguil <adrien.mazarguil@6wind.com>
Subject: Re: [PATCH] net/mlx5: Avoid stripping the glue library
Date: Wed, 1 Aug 2018 08:29:50 +0000	[thread overview]
Message-ID: <DB7PR05MB44264607E66CA86D4FD29D26C32D0@DB7PR05MB4426.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <1533043863.20916.49.camel@debian.org>

Tuesday, July 31, 2018 4:31 PM, Luca Boccassi:
> Subject: Re: [dpdk-dev] [PATCH] net/mlx5: Avoid stripping the glue library
> 
> On Tue, 2018-07-31 at 15:15 +0200, Timothy Redaelli wrote:
> > Stripping binaries at build time is usually a bad thing since it makes
> > impossible to generate (split) debug symbols and this can lead to a
> > more difficult debugging.
> >
> > CC: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> > Fixes: 59b91bec12c6 ("net/mlx5: spawn rdma-core dependency plug-in")
> >
> > Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
> > ---
> >  drivers/net/mlx5/Makefile | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/mlx5/Makefile b/drivers/net/mlx5/Makefile
> > index 75bee4640..2e70dec5b 100644
> > --- a/drivers/net/mlx5/Makefile
> > +++ b/drivers/net/mlx5/Makefile
> > @@ -409,7 +409,7 @@ endif
> >  $(LIB_GLUE): mlx5_glue.o
> >  	$Q $(LD) $(GLUE_LDFLAGS) $(EXTRA_LDFLAGS) \
> >  		-Wl,-h,$(LIB_GLUE) \
> > -		-s -shared -o $@ $< -libverbs -lmlx5
> > +		-shared -o $@ $< -libverbs -lmlx5
> >
> >  mlx5_glue.o: mlx5_autoconf.h
> 
> Acked-by: Luca Boccassi <bluca@debian.org>

Applied to next-net-mlx, thanks. 

> 
> --
> Kind regards,
> Luca Boccassi

  reply	other threads:[~2018-08-01  8:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-31 13:15 [PATCH] net/mlx5: Avoid stripping the glue library Timothy Redaelli
2018-07-31 13:31 ` Luca Boccassi
2018-08-01  8:29   ` Shahaf Shuler [this message]
2018-07-31 13:33 ` Christian Ehrhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB7PR05MB44264607E66CA86D4FD29D26C32D0@DB7PR05MB4426.eurprd05.prod.outlook.com \
    --to=shahafs@mellanox.com \
    --cc=adrien.mazarguil@6wind.com \
    --cc=bluca@debian.org \
    --cc=dev@dpdk.org \
    --cc=tredaelli@redhat.com \
    --cc=yskoh@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.