From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shahaf Shuler Subject: Re: [PATCH v2 3/3] net/mlx5: implement multicast add list devop Date: Mon, 23 Apr 2018 05:52:08 +0000 Message-ID: References: <870d4840cdb872d363d103808f82eb3645fd36b0.1524059312.git.nelio.laranjeiro@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: Adrien Mazarguil To: =?iso-8859-1?Q?N=E9lio_Laranjeiro?= , "dev@dpdk.org" , Yongseok Koh Return-path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20086.outbound.protection.outlook.com [40.107.2.86]) by dpdk.org (Postfix) with ESMTP id 9CD3C1C01 for ; Mon, 23 Apr 2018 07:52:10 +0200 (CEST) In-Reply-To: <870d4840cdb872d363d103808f82eb3645fd36b0.1524059312.git.nelio.laranjeiro@6wind.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Nelio, Small comments before I merge. Wednesday, April 18, 2018 4:50 PM, Nelio Laranjeiro: > Subject: [dpdk-dev] [PATCH v2 3/3] net/mlx5: implement multicast add list > devop >=20 > Signed-off-by: Nelio Laranjeiro > --- > drivers/net/mlx5/mlx5.c | 2 ++ > drivers/net/mlx5/mlx5.h | 2 ++ > drivers/net/mlx5/mlx5_defs.h | 5 ++++- drivers/net/mlx5/mlx5_mac.c | = 33 > +++++++++++++++++++++++++++++++++ > 4 files changed, 41 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index > 68783c3ac..887924d07 100644 > --- a/drivers/net/mlx5/mlx5.c > +++ b/drivers/net/mlx5/mlx5.c > @@ -277,6 +277,7 @@ const struct eth_dev_ops mlx5_dev_ops =3D { > .mac_addr_remove =3D mlx5_mac_addr_remove, > .mac_addr_add =3D mlx5_mac_addr_add, > .mac_addr_set =3D mlx5_mac_addr_set, > + .set_mc_addr_list =3D mlx5_set_mc_addr_list, > .mtu_set =3D mlx5_dev_set_mtu, > .vlan_strip_queue_set =3D mlx5_vlan_strip_queue_set, > .vlan_offload_set =3D mlx5_vlan_offload_set, @@ -329,6 +330,7 @@ > const struct eth_dev_ops mlx5_dev_ops_isolate =3D { > .mac_addr_remove =3D mlx5_mac_addr_remove, > .mac_addr_add =3D mlx5_mac_addr_add, > .mac_addr_set =3D mlx5_mac_addr_set, > + .set_mc_addr_list =3D mlx5_set_mc_addr_list, > .mtu_set =3D mlx5_dev_set_mtu, > .vlan_strip_queue_set =3D mlx5_vlan_strip_queue_set, > .vlan_offload_set =3D mlx5_vlan_offload_set, diff --git > a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h index > 6ad41390a..64f025d22 100644 > --- a/drivers/net/mlx5/mlx5.h > +++ b/drivers/net/mlx5/mlx5.h > @@ -203,6 +203,8 @@ void mlx5_mac_addr_remove(struct rte_eth_dev > *dev, uint32_t index); int mlx5_mac_addr_add(struct rte_eth_dev *dev, > struct ether_addr *mac, > uint32_t index, uint32_t vmdq); int > mlx5_mac_addr_set(struct rte_eth_dev *dev, struct ether_addr > *mac_addr); > +int mlx5_set_mc_addr_list(struct rte_eth_dev *dev, > + struct ether_addr *mc_addr_set, uint32_t > nb_mc_addr); >=20 > /* mlx5_rss.c */ >=20 > diff --git a/drivers/net/mlx5/mlx5_defs.h b/drivers/net/mlx5/mlx5_defs.h > index e3aa03bef..5973742a7 100644 > --- a/drivers/net/mlx5/mlx5_defs.h > +++ b/drivers/net/mlx5/mlx5_defs.h > @@ -15,8 +15,11 @@ >=20 > /* Maximum number of simultaneous unicast MAC addresses. */ #define > MLX5_MAX_UC_MAC_ADDRESSES 128 > +/* Maximum number of simultaneous Multicast MAC addresses. */ #define > +MLX5_MAX_MC_MAC_ADDRESSES 128 > /* Maximum number of simultaneous MAC addresses. */ -#define > MLX5_MAX_MAC_ADDRESSES MLX5_MAX_UC_MAC_ADDRESSES > +#define MLX5_MAX_MAC_ADDRESSES \ > + (MLX5_MAX_UC_MAC_ADDRESSES + > MLX5_MAX_MC_MAC_ADDRESSES) >=20 > /* Maximum number of simultaneous VLAN filters. */ #define > MLX5_MAX_VLAN_IDS 128 diff --git a/drivers/net/mlx5/mlx5_mac.c > b/drivers/net/mlx5/mlx5_mac.c index e9334ea4a..32560d55e 100644 > --- a/drivers/net/mlx5/mlx5_mac.c > +++ b/drivers/net/mlx5/mlx5_mac.c > @@ -201,3 +201,36 @@ mlx5_mac_addr_set(struct rte_eth_dev *dev, struct > ether_addr *mac_addr) > dev->data->port_id); > return mlx5_mac_addr_add(dev, mac_addr, 0, 0); } > + > +/** > + * DPDK callback to set multicast addresses list. > + * > + * @param dev > + * Pointer to Ethernet device structure. > + * @param mac_addr_set > + * Multicast MAC address pointer array. > + * @param nb_mac_addr > + * Number of entries in the array. > + * > + * @return > + * 0 on success, a negative errno value otherwise and rte_errno is set= . > + */ > +int > +mlx5_set_mc_addr_list(struct rte_eth_dev *dev, > + struct ether_addr *mc_addr_set, uint32_t nb_mc_addr) { > + uint32_t i; > + int ret; > + We should check nb_mc_addr < MLX5_MAX_MC_MAC_ADDRESSES before we start oper= ate.=20 > + for (i =3D MLX5_MAX_UC_MAC_ADDRESSES; i !=3D > MLX5_MAX_MAC_ADDRESSES; ++i) > + mlx5_internal_mac_addr_remove(dev, i); > + i =3D MLX5_MAX_UC_MAC_ADDRESSES; > + while (nb_mc_addr--) { Maybe worth checking is_multicast_ether_addr(mc_addr_set) and to skip + war= n if it is not.=20 > + ret =3D mlx5_internal_mac_addr_add(dev, mc_addr_set++, > i++); > + if (ret) > + return ret; > + } > + if (!dev->data->promiscuous) > + return mlx5_traffic_restart(dev); > + return 0; > +} > -- > 2.17.0