From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shahaf Shuler Subject: Re: [PATCH v6 00/11] mlx5 Rx tunnel offloading Date: Thu, 26 Apr 2018 06:23:46 +0000 Message-ID: References: <20180420122340.113348-1-xuemingl@mellanox.com> <20180423123310.32991-1-xuemingl@mellanox.com> <20180424082430.qksxomxm7dh425df@laranjeiro-vm.dev.6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" To: =?iso-8859-1?Q?N=E9lio_Laranjeiro?= , "Xueming(Steven) Li" Return-path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0067.outbound.protection.outlook.com [104.47.2.67]) by dpdk.org (Postfix) with ESMTP id 284A76CA2 for ; Thu, 26 Apr 2018 08:23:48 +0200 (CEST) In-Reply-To: <20180424082430.qksxomxm7dh425df@laranjeiro-vm.dev.6wind.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Tuesday, April 24, 2018 11:25 AM, N=E9lio Laranjeiro: > Subject: Re: [PATCH v6 00/11] mlx5 Rx tunnel offloading >=20 > On Mon, Apr 23, 2018 at 08:32:59PM +0800, Xueming Li wrote: > > > > Important note: > > please note that this patchset relies on Adrien's patchset of f= low API > > overhaul: > > > https://emea01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fww > w. > > > dpdk.org%2Fdev%2Fpatchwork%2Fpatch%2F38508%2F&data=3D02%7C01%7Cs > hahafs%4 > > > 0mellanox.com%7Ccd5e14a1081b4b4d06ee08d5a9bcb19c%7Ca652971c7d2e4 > d9ba6a > > > 4d149256f461b%7C0%7C0%7C636601550259090665&sdata=3DcCj7YufX7oNyl9J > %2FC4C > > zKJM3UPoD5S5QJpAG1SkNMBA%3D&reserved=3D0 > > v6: > > - Fixed commit log of tunnel type identification > > v5: > > - Removed %lx prints > > - Per review request, clear mbuf tunnel type in case of multiple tunnel > types. > > - Rebase on Adriens flow API overhaul patchset > > - Split feature requirement document into patches of L3 VXLAN and > > VXLAN-GPE > > - Per review request, add device parameter to enable L3 VXLAN and > > VXLAN-GPE > > v4: > > - Fix RSS level according to value defination > > - Add "Inner RSS" column to NIC feature doc > > - Fixed flow creation error in case of ipv4 rss on ipv6 pattern > > - new patch: enforce IP protocol of GRE to be 47. > > - Removed MPLS-in-UDP and MPLS-in-GRE replated patchset > > - Removed invalid RSS type check > > v3: > > - Refactor 16 Verbs priority detection. > > - Other updates according to ML discussion. > > v2: > > - Split into 2 series: public api and mlx5, this one is the second. > > - Rebased on Adrien's rte flow overhaul: > > > > > https://emea01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fww > w. > > dpdk.org%2Fml%2Farchives%2Fdev%2F2018- > April%2F095774.html&data=3D02%7C01 > > > %7Cshahafs%40mellanox.com%7Ccd5e14a1081b4b4d06ee08d5a9bcb19c%7C > a652971 > > > c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636601550259090665&sdata=3DPO > Air3I7R > > 45xtoemp8dQ%2BZt6YYePWS%2FHezXQbBQgbQY%3D&reserved=3D0 > > v1: > > - Support new tunnel type MPLS-in-GRE and MPLS-in-UDP > > - Remove deprecation notes of rss level > > > > This patchset supports MLX5 Rx tunnel checksum, inner rss, inner ptype > offloading of following tunnel types: > > - Standard VXLAN > > - L3 VXLAN (no inner ethernet header) > > - VXLAN-GPE > > > > Xueming Li (11): > > net/mlx5: support 16 hardware priorities > > net/mlx5: support GRE tunnel flow > > net/mlx5: support L3 VXLAN flow > > net/mlx5: support Rx tunnel type identification > > net/mlx5: cleanup tunnel checksum offloads > > net/mlx5: split flow RSS handling logic > > net/mlx5: support tunnel RSS level > > net/mlx5: add hardware flow debug dump > > net/mlx5: introduce VXLAN-GPE tunnel type > > net/mlx5: allow flow tunnel ID 0 with outer pattern > > doc: update mlx5 guide on tunnel offloading > > > > doc/guides/nics/features/default.ini | 1 + > > doc/guides/nics/features/mlx5.ini | 3 + > > doc/guides/nics/mlx5.rst | 30 +- > > drivers/net/mlx5/Makefile | 2 +- > > drivers/net/mlx5/mlx5.c | 24 + > > drivers/net/mlx5/mlx5.h | 6 + > > drivers/net/mlx5/mlx5_flow.c | 844 > +++++++++++++++++++++++++++------- > > drivers/net/mlx5/mlx5_glue.c | 16 + > > drivers/net/mlx5/mlx5_glue.h | 8 + > > drivers/net/mlx5/mlx5_rxq.c | 89 +++- > > drivers/net/mlx5/mlx5_rxtx.c | 33 +- > > drivers/net/mlx5/mlx5_rxtx.h | 11 +- > > drivers/net/mlx5/mlx5_rxtx_vec_neon.h | 21 +- > > drivers/net/mlx5/mlx5_rxtx_vec_sse.h | 17 +- > > drivers/net/mlx5/mlx5_trigger.c | 8 - > > drivers/net/mlx5/mlx5_utils.h | 6 + > > 16 files changed, 896 insertions(+), 223 deletions(-) > > > > -- > > 2.13.3 > > >=20 > I think we have caught almost all issues, if something remains fixes can > be added. >=20 > Acked-by: Nelio Laranjeiro Series applied to next-net-mlx, thanks.=20 >=20 > -- > N=E9lio Laranjeiro > 6WIND