From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A662C47404 for ; Fri, 11 Oct 2019 13:53:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3CB0F2064A for ; Fri, 11 Oct 2019 13:53:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.b="0ll6BaS+"; dkim=pass (1024-bit key) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.b="0ll6BaS+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728202AbfJKNw7 (ORCPT ); Fri, 11 Oct 2019 09:52:59 -0400 Received: from mail-eopbgr60040.outbound.protection.outlook.com ([40.107.6.40]:8551 "EHLO EUR04-DB3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728120AbfJKNw6 (ORCPT ); Fri, 11 Oct 2019 09:52:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MgL+Jy3wjKTV4DdhtJqxlJIzAG1S5mIBShX5SWP/tL8=; b=0ll6BaS+ZPqP18wBb1+GMACX6yzLZp5oLKXusnkCsxcB5NLRlJ4I2RwmhTVInRPWd/xkMLwAhux36bfbrrMaO3NWHjx/az/qx2b/s2hB5aZgMPytyhdLNP5wOxXrOsjDSVTVMQ8bJY92UCWUpYZ2cjm+3aEu5Xu6MxHdBDfh4to= Received: from VI1PR0802CA0025.eurprd08.prod.outlook.com (2603:10a6:800:a9::11) by DB8PR08MB4091.eurprd08.prod.outlook.com (2603:10a6:10:a2::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2347.16; Fri, 11 Oct 2019 13:51:12 +0000 Received: from DB5EUR03FT059.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e0a::209) by VI1PR0802CA0025.outlook.office365.com (2603:10a6:800:a9::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2347.18 via Frontend Transport; Fri, 11 Oct 2019 13:51:12 +0000 Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; vger.kernel.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;vger.kernel.org; dmarc=none action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT059.mail.protection.outlook.com (10.152.21.175) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2305.15 via Frontend Transport; Fri, 11 Oct 2019 13:51:10 +0000 Received: ("Tessian outbound e4042aced47b:v33"); Fri, 11 Oct 2019 13:51:07 +0000 X-CR-MTA-TID: 64aa7808 Received: from 109d1fc128e0.3 (ip-172-16-0-2.eu-west-1.compute.internal [104.47.2.52]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id B97160E5-B932-4307-8A84-D455A67856C8.1; Fri, 11 Oct 2019 13:51:02 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01lp2052.outbound.protection.outlook.com [104.47.2.52]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 109d1fc128e0.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 11 Oct 2019 13:51:02 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oSjmn4rJzLtd95RWvjzqWs9Axeopm2IdkWVFXWx8emiImlf381KZV/iJamn4tmpjvd1zLTzeFo6t7rBQwiSfyRimOtDxaDxda+EE2Cr85tfOfz94NYtID+h1ikNfl7EyDhD4xg3vjN9bXFBmpihiwVR5DZ93XgXOz23FypQpra0uFgxnyoz4LcDQyGfs/NMAQEA+8T+TOb6Muz9G3UVw8AL7S4jSV8MPbjJ9jR7AvB7CHcoRBG1iyBx/Y6IMxFJPu5BkJz/vAU7PKhTL328q2ql6jKPrC0E2rJrUGjiOc6sxX5ANJe6WbT4NCps9imiVMGKb2kpmhmY19Qhf96x1Dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MgL+Jy3wjKTV4DdhtJqxlJIzAG1S5mIBShX5SWP/tL8=; b=mOCrtJPQd+f8x6owbc4clg9yhRS+w7gyOUla4iMlCSf2km9khSzH0tbTtSY/neFTEJNe12IUV0jN5zI/OJbFSZ32hTP6NcSns2FwUkajQS6ZZLM/4iBWB+H1/DKP7TD40e2EXzpy9+lFT12qhRPmP9E+rk2Pr68v5inpyVy41NfPYmLCCg3Z5SQG9inELbJ3rTOw65m/+UXET1a82+qOjeayPx/wZJHh+oTw7+5sSX4bkK5qDV2Q6kJSGVozj5kD3173ikqoAaSlYE8WgHHF2zMmODUb8D7E/UMRarizUThOGK1J9h1AV8Vf8Qn5fAvCDQxejIVYLXQKSpgIWkouHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MgL+Jy3wjKTV4DdhtJqxlJIzAG1S5mIBShX5SWP/tL8=; b=0ll6BaS+ZPqP18wBb1+GMACX6yzLZp5oLKXusnkCsxcB5NLRlJ4I2RwmhTVInRPWd/xkMLwAhux36bfbrrMaO3NWHjx/az/qx2b/s2hB5aZgMPytyhdLNP5wOxXrOsjDSVTVMQ8bJY92UCWUpYZ2cjm+3aEu5Xu6MxHdBDfh4to= Received: from DB7PR08MB3082.eurprd08.prod.outlook.com (52.134.110.24) by DB7PR08MB3658.eurprd08.prod.outlook.com (20.176.237.205) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2347.16; Fri, 11 Oct 2019 13:51:01 +0000 Received: from DB7PR08MB3082.eurprd08.prod.outlook.com ([fe80::f9f9:ad51:6636:42f0]) by DB7PR08MB3082.eurprd08.prod.outlook.com ([fe80::f9f9:ad51:6636:42f0%6]) with mapi id 15.20.2347.016; Fri, 11 Oct 2019 13:51:01 +0000 From: "Justin He (Arm Technology China)" To: Catalin Marinas CC: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "x86@kernel.org" , "hejianet@gmail.com" , "Kaly Xin (Arm Technology China)" , nd Subject: RE: [PATCH v11 1/4] arm64: cpufeature: introduce helper cpu_has_hw_af() Thread-Topic: [PATCH v11 1/4] arm64: cpufeature: introduce helper cpu_has_hw_af() Thread-Index: AQHVfn2fVz/WJ52EYEizqdXPogUta6dUFqAAgACNw7CAAJ7OAIAANRzg Date: Fri, 11 Oct 2019 13:51:01 +0000 Message-ID: References: <20191009084246.123354-1-justin.he@arm.com> <20191009084246.123354-2-justin.he@arm.com> <20191010164312.GB40923@arrakis.emea.arm.com> <20191011103857.GB54842@arrakis.emea.arm.com> In-Reply-To: <20191011103857.GB54842@arrakis.emea.arm.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 51cc0dae-e2ad-4a87-97e9-8c67649a08d7.1 x-checkrecipientchecked: true Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Justin.He@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 68de0af2-0ae5-4d08-a5fa-08d74e52129b X-MS-Office365-Filtering-HT: Tenant X-MS-TrafficTypeDiagnostic: DB7PR08MB3658:|DB7PR08MB3658:|DB8PR08MB4091: X-MS-Exchange-PUrlCount: 1 x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:421;OLM:421; x-forefront-prvs: 0187F3EA14 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(979002)(4636009)(39860400002)(376002)(136003)(396003)(346002)(366004)(13464003)(51914003)(189003)(199004)(11346002)(5660300002)(81156014)(7696005)(8676002)(81166006)(55236004)(446003)(76176011)(26005)(25786009)(102836004)(229853002)(53546011)(6506007)(14454004)(55016002)(71190400001)(486006)(99286004)(71200400001)(86362001)(476003)(6636002)(186003)(66066001)(8936002)(6436002)(7736002)(66446008)(6306002)(52536014)(74316002)(66556008)(66476007)(966005)(305945005)(316002)(6862004)(66946007)(76116006)(9686003)(2906002)(6246003)(6116002)(256004)(3846002)(33656002)(478600001)(64756008)(4326008)(54906003)(309714004)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1101;SCL:1;SRVR:DB7PR08MB3658;H:DB7PR08MB3082.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: bNKoMGHhR5bA+Dv9W7HW4uxPlkPEPx1zQY9+nurjPuQmT87bsBB/Et7xGePq2sEko1BnbN5mA/GogUl7Z/Bp5Qnxz8BKQpINlEe0rl2iRChK0XrIDrdHbMPUEW3EOrQ/NBoi6bH0Kj9B+HqW2tSMX1chsLjWHdpupeVXmioG2PhDpA4Mr2Edg7s9GSGX4nQJ3H61ERTudO30EdOKeYpXsmZq2bDJIEVUUOX4VLixVXcRPzrRXBkgz6+3/lkywxoVXVkHqzgPSibI/Qv73bJL6czcv22yHR6UGY7TqAS3o1zVFWDK+zFY0HwS8azmhPN8w840ZHNpCu6geZCzt6v1VluvUAHXnhdafU3njoXqfB1aaMzIubiX5M3t5whF+DrwXo5b32aL/EsYQWMSfrXe/IV1Y3mR4TNaccbqGdgwiPSmp/qS3uK4ZxlcxLbJJOLJ+jiXYdSkmKu0/AIhyYS09Q== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3658 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Justin.He@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT059.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123;IPV:CAL;SCL:-1;CTRY:IE;EFV:NLI;SFV:NSPM;SFS:(10009020)(979002)(4636009)(346002)(376002)(39850400004)(396003)(136003)(51914003)(13464003)(199004)(189003)(2906002)(23726003)(5660300002)(26826003)(99286004)(6116002)(966005)(478600001)(126002)(6636002)(47776003)(76130400001)(3846002)(50466002)(70586007)(97756001)(46406003)(476003)(33656002)(486006)(356004)(70206006)(6862004)(4326008)(26005)(63350400001)(186003)(25786009)(446003)(8746002)(8936002)(81166006)(81156014)(7696005)(8676002)(229853002)(6246003)(66066001)(86362001)(305945005)(14454004)(54906003)(52536014)(11346002)(316002)(22756006)(6506007)(53546011)(74316002)(6306002)(55016002)(102836004)(76176011)(9686003)(7736002)(336012)(309714004)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1101;SCL:1;SRVR:DB8PR08MB4091;H:64aa7808-outbound-1.mta.getcheckrecipient.com;FPR:;SPF:TempError;LANG:en;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;A:1;MX:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: 639bb178-45ff-406c-2e81-08d74e520d93 NoDisclaimer: True X-Forefront-PRVS: 0187F3EA14 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0JManUeCoORKWfi14LpzlI0+dY/clIKXK01DAcRCa6WN4hOZyk3+ijPBvLq96FuIci5flFSQkUT//AOBBBvATsnfyt3WgDXMAHBkIkthi7kwNfi8Q1wJW7LT1GNhuyD3FHDgk/ISK47Hd1lCJhSAfqu8hqr2YJWmeag+GueYLXndrPwgfTV2Jj1T/xQ+JcbdjVtr81SKevycATJ9mZgVCKrGBbnCvDxsuO/1OaOJBDYeykffmWEQpYCIh4rWc1EMCbCkjmpd2M1ae7FcJ3vhaQOlYd2xJfYHCZuMlDImRi1fc4BPBEpN9PmJDE2JoztgZ0dlOC/ySy2pd2x2ldfLBHVNNdxAhG0mC9L+nDk3MXG+Nt6tr2nF+XpGCphmihOuiOLQHRWytIDUVEeR9wimXt2lTUjJBFiBYwsTjmiqNrDXTNmIf2ckbbv7re63C6+WoRZTpGBXHlzrPslfb3z9iw== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2019 13:51:10.1118 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 68de0af2-0ae5-4d08-a5fa-08d74e52129b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB4091 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Catanlin Thanks for the detailed explanation. Will send out v12 soon after testing -- Cheers, Justin (Jia He) =20 > -----Original Message----- > From: Catalin Marinas > Sent: Friday, October 11, 2019 6:39 PM > To: Justin He (Arm Technology China) > Cc: Will Deacon ; Mark Rutland > ; James Morse ; Marc > Zyngier ; Matthew Wilcox ; Kirill A. > Shutemov ; linux-arm- > kernel@lists.infradead.org; linux-kernel@vger.kernel.org; linux- > mm@kvack.org; Suzuki Poulose ; Borislav > Petkov ; H. Peter Anvin ; x86@kernel.org; > Thomas Gleixner ; Andrew Morton foundation.org>; hejianet@gmail.com; Kaly Xin (Arm Technology China) > ; nd > Subject: Re: [PATCH v11 1/4] arm64: cpufeature: introduce helper > cpu_has_hw_af() >=20 > On Fri, Oct 11, 2019 at 01:16:36AM +0000, Justin He (Arm Technology China= ) > wrote: > > From: Catalin Marinas > > > On Wed, Oct 09, 2019 at 04:42:43PM +0800, Jia He wrote: > > > > + u64 mmfr1 =3D read_cpuid(ID_AA64MMFR1_EL1); > > > > + > > > > + return !!cpuid_feature_extract_unsigned_field(mmfr1, > > > > + > > > ID_AA64MMFR1_HADBS_SHIFT); > > > > > > No need for !!, the return type is a bool already. > > > > But cpuid_feature_extract_unsigned_field has the return type "unsigned > int" [1] > > > > [1] > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/a= rch > /arm64/include/asm/cpufeature.h#n444 >=20 > And the C language gives you the automatic conversion from unsigned int > to bool without the need for !!. The reason we use !! in some places is > for converting long to int (not bool) and losing the top 32-bit. See > commit 84fe6826c28f ("arm64: mm: Add double logical invert to pte > accessors") for an explanation. >=20 > -- > Catalin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7FEFC47404 for ; Fri, 11 Oct 2019 13:51:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3D0A92064A for ; Fri, 11 Oct 2019 13:51:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.b="0ll6BaS+"; dkim=pass (1024-bit key) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.b="0ll6BaS+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3D0A92064A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C90E68E0001; Fri, 11 Oct 2019 09:51:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C1AF26B0005; Fri, 11 Oct 2019 09:51:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ABAD58E0001; Fri, 11 Oct 2019 09:51:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0161.hostedemail.com [216.40.44.161]) by kanga.kvack.org (Postfix) with ESMTP id 89F0F6B0003 for ; Fri, 11 Oct 2019 09:51:20 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 4189B37E7 for ; Fri, 11 Oct 2019 13:51:20 +0000 (UTC) X-FDA: 76031640720.06.army34_7fe38af21cc44 X-HE-Tag: army34_7fe38af21cc44 X-Filterd-Recvd-Size: 12977 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140073.outbound.protection.outlook.com [40.107.14.73]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Fri, 11 Oct 2019 13:51:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MgL+Jy3wjKTV4DdhtJqxlJIzAG1S5mIBShX5SWP/tL8=; b=0ll6BaS+ZPqP18wBb1+GMACX6yzLZp5oLKXusnkCsxcB5NLRlJ4I2RwmhTVInRPWd/xkMLwAhux36bfbrrMaO3NWHjx/az/qx2b/s2hB5aZgMPytyhdLNP5wOxXrOsjDSVTVMQ8bJY92UCWUpYZ2cjm+3aEu5Xu6MxHdBDfh4to= Received: from AM6PR08CA0006.eurprd08.prod.outlook.com (2603:10a6:20b:b2::18) by AM6PR08MB3592.eurprd08.prod.outlook.com (2603:10a6:20b:4b::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2347.19; Fri, 11 Oct 2019 13:51:14 +0000 Received: from AM5EUR03FT028.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e08::200) by AM6PR08CA0006.outlook.office365.com (2603:10a6:20b:b2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2347.16 via Frontend Transport; Fri, 11 Oct 2019 13:51:14 +0000 Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; kvack.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;kvack.org; dmarc=none action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT028.mail.protection.outlook.com (10.152.16.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2305.15 via Frontend Transport; Fri, 11 Oct 2019 13:51:13 +0000 Received: ("Tessian outbound e4042aced47b:v33"); Fri, 11 Oct 2019 13:51:07 +0000 X-CR-MTA-TID: 64aa7808 Received: from 109d1fc128e0.3 (ip-172-16-0-2.eu-west-1.compute.internal [104.47.2.52]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id B97160E5-B932-4307-8A84-D455A67856C8.1; Fri, 11 Oct 2019 13:51:02 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01lp2052.outbound.protection.outlook.com [104.47.2.52]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 109d1fc128e0.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 11 Oct 2019 13:51:02 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oSjmn4rJzLtd95RWvjzqWs9Axeopm2IdkWVFXWx8emiImlf381KZV/iJamn4tmpjvd1zLTzeFo6t7rBQwiSfyRimOtDxaDxda+EE2Cr85tfOfz94NYtID+h1ikNfl7EyDhD4xg3vjN9bXFBmpihiwVR5DZ93XgXOz23FypQpra0uFgxnyoz4LcDQyGfs/NMAQEA+8T+TOb6Muz9G3UVw8AL7S4jSV8MPbjJ9jR7AvB7CHcoRBG1iyBx/Y6IMxFJPu5BkJz/vAU7PKhTL328q2ql6jKPrC0E2rJrUGjiOc6sxX5ANJe6WbT4NCps9imiVMGKb2kpmhmY19Qhf96x1Dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MgL+Jy3wjKTV4DdhtJqxlJIzAG1S5mIBShX5SWP/tL8=; b=mOCrtJPQd+f8x6owbc4clg9yhRS+w7gyOUla4iMlCSf2km9khSzH0tbTtSY/neFTEJNe12IUV0jN5zI/OJbFSZ32hTP6NcSns2FwUkajQS6ZZLM/4iBWB+H1/DKP7TD40e2EXzpy9+lFT12qhRPmP9E+rk2Pr68v5inpyVy41NfPYmLCCg3Z5SQG9inELbJ3rTOw65m/+UXET1a82+qOjeayPx/wZJHh+oTw7+5sSX4bkK5qDV2Q6kJSGVozj5kD3173ikqoAaSlYE8WgHHF2zMmODUb8D7E/UMRarizUThOGK1J9h1AV8Vf8Qn5fAvCDQxejIVYLXQKSpgIWkouHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MgL+Jy3wjKTV4DdhtJqxlJIzAG1S5mIBShX5SWP/tL8=; b=0ll6BaS+ZPqP18wBb1+GMACX6yzLZp5oLKXusnkCsxcB5NLRlJ4I2RwmhTVInRPWd/xkMLwAhux36bfbrrMaO3NWHjx/az/qx2b/s2hB5aZgMPytyhdLNP5wOxXrOsjDSVTVMQ8bJY92UCWUpYZ2cjm+3aEu5Xu6MxHdBDfh4to= Received: from DB7PR08MB3082.eurprd08.prod.outlook.com (52.134.110.24) by DB7PR08MB3658.eurprd08.prod.outlook.com (20.176.237.205) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2347.16; Fri, 11 Oct 2019 13:51:01 +0000 Received: from DB7PR08MB3082.eurprd08.prod.outlook.com ([fe80::f9f9:ad51:6636:42f0]) by DB7PR08MB3082.eurprd08.prod.outlook.com ([fe80::f9f9:ad51:6636:42f0%6]) with mapi id 15.20.2347.016; Fri, 11 Oct 2019 13:51:01 +0000 From: "Justin He (Arm Technology China)" To: Catalin Marinas CC: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "x86@kernel.org" , "hejianet@gmail.com" , "Kaly Xin (Arm Technology China)" , nd Subject: RE: [PATCH v11 1/4] arm64: cpufeature: introduce helper cpu_has_hw_af() Thread-Topic: [PATCH v11 1/4] arm64: cpufeature: introduce helper cpu_has_hw_af() Thread-Index: AQHVfn2fVz/WJ52EYEizqdXPogUta6dUFqAAgACNw7CAAJ7OAIAANRzg Date: Fri, 11 Oct 2019 13:51:01 +0000 Message-ID: References: <20191009084246.123354-1-justin.he@arm.com> <20191009084246.123354-2-justin.he@arm.com> <20191010164312.GB40923@arrakis.emea.arm.com> <20191011103857.GB54842@arrakis.emea.arm.com> In-Reply-To: <20191011103857.GB54842@arrakis.emea.arm.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 51cc0dae-e2ad-4a87-97e9-8c67649a08d7.1 x-checkrecipientchecked: true Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Justin.He@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 18bf9198-1daa-4fe2-372d-08d74e521496 X-MS-Office365-Filtering-HT: Tenant X-MS-TrafficTypeDiagnostic: DB7PR08MB3658:|DB7PR08MB3658:|AM6PR08MB3592: X-MS-Exchange-PUrlCount: 1 x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:421;OLM:421; x-forefront-prvs: 0187F3EA14 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(979002)(4636009)(39860400002)(376002)(136003)(396003)(346002)(366004)(13464003)(51914003)(189003)(199004)(11346002)(5660300002)(81156014)(7696005)(8676002)(81166006)(55236004)(446003)(76176011)(26005)(25786009)(102836004)(229853002)(53546011)(6506007)(14454004)(55016002)(71190400001)(486006)(99286004)(71200400001)(86362001)(476003)(6636002)(186003)(66066001)(8936002)(6436002)(7736002)(66446008)(6306002)(52536014)(74316002)(66556008)(66476007)(966005)(305945005)(316002)(6862004)(66946007)(76116006)(9686003)(2906002)(6246003)(6116002)(256004)(3846002)(33656002)(478600001)(64756008)(4326008)(54906003)(309714004)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1101;SCL:1;SRVR:DB7PR08MB3658;H:DB7PR08MB3082.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: bNKoMGHhR5bA+Dv9W7HW4uxPlkPEPx1zQY9+nurjPuQmT87bsBB/Et7xGePq2sEko1BnbN5mA/GogUl7Z/Bp5Qnxz8BKQpINlEe0rl2iRChK0XrIDrdHbMPUEW3EOrQ/NBoi6bH0Kj9B+HqW2tSMX1chsLjWHdpupeVXmioG2PhDpA4Mr2Edg7s9GSGX4nQJ3H61ERTudO30EdOKeYpXsmZq2bDJIEVUUOX4VLixVXcRPzrRXBkgz6+3/lkywxoVXVkHqzgPSibI/Qv73bJL6czcv22yHR6UGY7TqAS3o1zVFWDK+zFY0HwS8azmhPN8w840ZHNpCu6geZCzt6v1VluvUAHXnhdafU3njoXqfB1aaMzIubiX5M3t5whF+DrwXo5b32aL/EsYQWMSfrXe/IV1Y3mR4TNaccbqGdgwiPSmp/qS3uK4ZxlcxLbJJOLJ+jiXYdSkmKu0/AIhyYS09Q== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3658 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Justin.He@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT028.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123;IPV:CAL;SCL:-1;CTRY:IE;EFV:NLI;SFV:NSPM;SFS:(10009020)(979002)(4636009)(136003)(396003)(376002)(39850400004)(346002)(189003)(199004)(51914003)(13464003)(2906002)(47776003)(6506007)(53546011)(46406003)(22756006)(356004)(74316002)(54906003)(76176011)(33656002)(7696005)(26826003)(316002)(36906005)(99286004)(52536014)(97756001)(229853002)(76130400001)(478600001)(305945005)(7736002)(66066001)(63350400001)(446003)(25786009)(11346002)(486006)(476003)(6246003)(6636002)(55016002)(9686003)(6306002)(81156014)(86362001)(8936002)(8676002)(8746002)(966005)(23726003)(6116002)(81166006)(3846002)(14454004)(70586007)(70206006)(26005)(186003)(6862004)(126002)(102836004)(5660300002)(4326008)(50466002)(336012)(309714004)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1101;SCL:1;SRVR:AM6PR08MB3592;H:64aa7808-outbound-1.mta.getcheckrecipient.com;FPR:;SPF:TempError;LANG:en;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;MX:1;A:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: 639bb178-45ff-406c-2e81-08d74e520d93 NoDisclaimer: True X-Forefront-PRVS: 0187F3EA14 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Uf473IrHuBMIVzZ08jhBYnxCk5RAypML8vVj97cqKBc62snDatCkc1krAit0/PwBqVRIboH5XMkfy5gRBScUL8v7rVIqCRQdXxVfbjq5Sum4zd/9vi3aT3HfCnyTOCS5SpDCXB/eeEp1K7+bzyCyhMyXuLay5ZVjC1ZGEgqPfRlV1MY3mgVGY3gtlqSjKtQa+pDXs+n1GJvWAIb6s67Qe5nKeVbEsADF0JR7KNlB/lQsuWlYMNDcmI8O7JdJiV6ZN+hwwWEsaVNt+Y+QZ2WyjtrmpcFx9+XEHPT+U0KNlMddKhDkdKM4doOYoUGoH0wqUnfATz+5KyJ+8D21Ea8slf2r98WUg2vs3oE7rOVxPDbPXfH5ar0aiuZqB0ozZt7+gyk1zA9kU0mYAm4qy1v4pcehje7KGFa4Z/nXYiiNyDKsuhOW84M9AOSxZAOGLTKiGLKDIog67MrRcr4VWiZp4w== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2019 13:51:13.5337 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 18bf9198-1daa-4fe2-372d-08d74e521496 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3592 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Catanlin Thanks for the detailed explanation. Will send out v12 soon after testing -- Cheers, Justin (Jia He) =20 > -----Original Message----- > From: Catalin Marinas > Sent: Friday, October 11, 2019 6:39 PM > To: Justin He (Arm Technology China) > Cc: Will Deacon ; Mark Rutland > ; James Morse ; Marc > Zyngier ; Matthew Wilcox ; Kirill A. > Shutemov ; linux-arm- > kernel@lists.infradead.org; linux-kernel@vger.kernel.org; linux- > mm@kvack.org; Suzuki Poulose ; Borislav > Petkov ; H. Peter Anvin ; x86@kernel.org; > Thomas Gleixner ; Andrew Morton foundation.org>; hejianet@gmail.com; Kaly Xin (Arm Technology China) > ; nd > Subject: Re: [PATCH v11 1/4] arm64: cpufeature: introduce helper > cpu_has_hw_af() >=20 > On Fri, Oct 11, 2019 at 01:16:36AM +0000, Justin He (Arm Technology China= ) > wrote: > > From: Catalin Marinas > > > On Wed, Oct 09, 2019 at 04:42:43PM +0800, Jia He wrote: > > > > + u64 mmfr1 =3D read_cpuid(ID_AA64MMFR1_EL1); > > > > + > > > > + return !!cpuid_feature_extract_unsigned_field(mmfr1, > > > > + > > > ID_AA64MMFR1_HADBS_SHIFT); > > > > > > No need for !!, the return type is a bool already. > > > > But cpuid_feature_extract_unsigned_field has the return type "unsigned > int" [1] > > > > [1] > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/a= rch > /arm64/include/asm/cpufeature.h#n444 >=20 > And the C language gives you the automatic conversion from unsigned int > to bool without the need for !!. The reason we use !! in some places is > for converting long to int (not bool) and losing the top 32-bit. See > commit 84fe6826c28f ("arm64: mm: Add double logical invert to pte > accessors") for an explanation. >=20 > -- > Catalin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBC04ECE58C for ; Fri, 11 Oct 2019 13:51:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 84E7C2064A for ; Fri, 11 Oct 2019 13:51:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gz5SEgHc"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.b="0ll6BaS+"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.b="0ll6BaS+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 84E7C2064A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GsckeJv5tUZg1eWiqWYA9k1mUz0doqPPM4i+WSTu/TY=; b=gz5SEgHcAN664z R+BI6wKK14d4pugbsKis22j79tXAwLpxKlI6xJ/8I9OqEcFH5bksN5DydRFEhen4KSRUkQmCu406V vGfJoey2MPY43PIwrGF0lrgSVRDODkIAdBY1V6j1ePgGPLa+WTAWAr2xFDRjHO+hg46EmK7S7vRmv 4lsuPADMtHCIwMsmk9vPyPeXw2rx1yCk1ALGGSBOmYT/scdS9UsCYCUVDUPCx+3wdcS3h8dSj28w2 876HRgacCWcpIRcUv21BuynRHdgb2KhUQ3SMJbniJhb6XFIImPqGH2MOtLdz9GScBzVisrOEDkHAn ZYBWr1IbhtguUkhTA+2Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iIvKE-0004OI-IJ; Fri, 11 Oct 2019 13:51:22 +0000 Received: from mail-eopbgr40061.outbound.protection.outlook.com ([40.107.4.61] helo=EUR03-DB5-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iIvK9-0004NX-Qg for linux-arm-kernel@lists.infradead.org; Fri, 11 Oct 2019 13:51:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MgL+Jy3wjKTV4DdhtJqxlJIzAG1S5mIBShX5SWP/tL8=; b=0ll6BaS+ZPqP18wBb1+GMACX6yzLZp5oLKXusnkCsxcB5NLRlJ4I2RwmhTVInRPWd/xkMLwAhux36bfbrrMaO3NWHjx/az/qx2b/s2hB5aZgMPytyhdLNP5wOxXrOsjDSVTVMQ8bJY92UCWUpYZ2cjm+3aEu5Xu6MxHdBDfh4to= Received: from AM6PR08CA0011.eurprd08.prod.outlook.com (2603:10a6:20b:b2::23) by VE1PR08MB5037.eurprd08.prod.outlook.com (2603:10a6:803:110::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2347.16; Fri, 11 Oct 2019 13:51:12 +0000 Received: from AM5EUR03FT028.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e08::209) by AM6PR08CA0011.outlook.office365.com (2603:10a6:20b:b2::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2347.16 via Frontend Transport; Fri, 11 Oct 2019 13:51:12 +0000 Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.infradead.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.infradead.org; dmarc=none action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT028.mail.protection.outlook.com (10.152.16.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2305.15 via Frontend Transport; Fri, 11 Oct 2019 13:51:10 +0000 Received: ("Tessian outbound e4042aced47b:v33"); Fri, 11 Oct 2019 13:51:07 +0000 X-CR-MTA-TID: 64aa7808 Received: from 109d1fc128e0.3 (ip-172-16-0-2.eu-west-1.compute.internal [104.47.2.52]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id B97160E5-B932-4307-8A84-D455A67856C8.1; Fri, 11 Oct 2019 13:51:02 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01lp2052.outbound.protection.outlook.com [104.47.2.52]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 109d1fc128e0.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 11 Oct 2019 13:51:02 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oSjmn4rJzLtd95RWvjzqWs9Axeopm2IdkWVFXWx8emiImlf381KZV/iJamn4tmpjvd1zLTzeFo6t7rBQwiSfyRimOtDxaDxda+EE2Cr85tfOfz94NYtID+h1ikNfl7EyDhD4xg3vjN9bXFBmpihiwVR5DZ93XgXOz23FypQpra0uFgxnyoz4LcDQyGfs/NMAQEA+8T+TOb6Muz9G3UVw8AL7S4jSV8MPbjJ9jR7AvB7CHcoRBG1iyBx/Y6IMxFJPu5BkJz/vAU7PKhTL328q2ql6jKPrC0E2rJrUGjiOc6sxX5ANJe6WbT4NCps9imiVMGKb2kpmhmY19Qhf96x1Dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MgL+Jy3wjKTV4DdhtJqxlJIzAG1S5mIBShX5SWP/tL8=; b=mOCrtJPQd+f8x6owbc4clg9yhRS+w7gyOUla4iMlCSf2km9khSzH0tbTtSY/neFTEJNe12IUV0jN5zI/OJbFSZ32hTP6NcSns2FwUkajQS6ZZLM/4iBWB+H1/DKP7TD40e2EXzpy9+lFT12qhRPmP9E+rk2Pr68v5inpyVy41NfPYmLCCg3Z5SQG9inELbJ3rTOw65m/+UXET1a82+qOjeayPx/wZJHh+oTw7+5sSX4bkK5qDV2Q6kJSGVozj5kD3173ikqoAaSlYE8WgHHF2zMmODUb8D7E/UMRarizUThOGK1J9h1AV8Vf8Qn5fAvCDQxejIVYLXQKSpgIWkouHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MgL+Jy3wjKTV4DdhtJqxlJIzAG1S5mIBShX5SWP/tL8=; b=0ll6BaS+ZPqP18wBb1+GMACX6yzLZp5oLKXusnkCsxcB5NLRlJ4I2RwmhTVInRPWd/xkMLwAhux36bfbrrMaO3NWHjx/az/qx2b/s2hB5aZgMPytyhdLNP5wOxXrOsjDSVTVMQ8bJY92UCWUpYZ2cjm+3aEu5Xu6MxHdBDfh4to= Received: from DB7PR08MB3082.eurprd08.prod.outlook.com (52.134.110.24) by DB7PR08MB3658.eurprd08.prod.outlook.com (20.176.237.205) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2347.16; Fri, 11 Oct 2019 13:51:01 +0000 Received: from DB7PR08MB3082.eurprd08.prod.outlook.com ([fe80::f9f9:ad51:6636:42f0]) by DB7PR08MB3082.eurprd08.prod.outlook.com ([fe80::f9f9:ad51:6636:42f0%6]) with mapi id 15.20.2347.016; Fri, 11 Oct 2019 13:51:01 +0000 From: "Justin He (Arm Technology China)" To: Catalin Marinas Subject: RE: [PATCH v11 1/4] arm64: cpufeature: introduce helper cpu_has_hw_af() Thread-Topic: [PATCH v11 1/4] arm64: cpufeature: introduce helper cpu_has_hw_af() Thread-Index: AQHVfn2fVz/WJ52EYEizqdXPogUta6dUFqAAgACNw7CAAJ7OAIAANRzg Date: Fri, 11 Oct 2019 13:51:01 +0000 Message-ID: References: <20191009084246.123354-1-justin.he@arm.com> <20191009084246.123354-2-justin.he@arm.com> <20191010164312.GB40923@arrakis.emea.arm.com> <20191011103857.GB54842@arrakis.emea.arm.com> In-Reply-To: <20191011103857.GB54842@arrakis.emea.arm.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 51cc0dae-e2ad-4a87-97e9-8c67649a08d7.1 x-checkrecipientchecked: true Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Justin.He@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: e8369078-240a-400f-2511-08d74e5212e3 X-MS-Office365-Filtering-HT: Tenant X-MS-TrafficTypeDiagnostic: DB7PR08MB3658:|DB7PR08MB3658:|VE1PR08MB5037: X-MS-Exchange-PUrlCount: 1 x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:421;OLM:421; x-forefront-prvs: 0187F3EA14 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(979002)(4636009)(39860400002)(376002)(136003)(396003)(346002)(366004)(13464003)(51914003)(189003)(199004)(11346002)(5660300002)(81156014)(7696005)(8676002)(81166006)(55236004)(446003)(76176011)(26005)(25786009)(102836004)(229853002)(53546011)(6506007)(14454004)(55016002)(71190400001)(486006)(99286004)(71200400001)(86362001)(476003)(6636002)(186003)(66066001)(8936002)(6436002)(7736002)(66446008)(6306002)(52536014)(74316002)(66556008)(66476007)(966005)(305945005)(316002)(6862004)(66946007)(76116006)(9686003)(2906002)(6246003)(6116002)(256004)(3846002)(33656002)(478600001)(64756008)(4326008)(54906003)(309714004)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR08MB3658; H:DB7PR08MB3082.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: bNKoMGHhR5bA+Dv9W7HW4uxPlkPEPx1zQY9+nurjPuQmT87bsBB/Et7xGePq2sEko1BnbN5mA/GogUl7Z/Bp5Qnxz8BKQpINlEe0rl2iRChK0XrIDrdHbMPUEW3EOrQ/NBoi6bH0Kj9B+HqW2tSMX1chsLjWHdpupeVXmioG2PhDpA4Mr2Edg7s9GSGX4nQJ3H61ERTudO30EdOKeYpXsmZq2bDJIEVUUOX4VLixVXcRPzrRXBkgz6+3/lkywxoVXVkHqzgPSibI/Qv73bJL6czcv22yHR6UGY7TqAS3o1zVFWDK+zFY0HwS8azmhPN8w840ZHNpCu6geZCzt6v1VluvUAHXnhdafU3njoXqfB1aaMzIubiX5M3t5whF+DrwXo5b32aL/EsYQWMSfrXe/IV1Y3mR4TNaccbqGdgwiPSmp/qS3uK4ZxlcxLbJJOLJ+jiXYdSkmKu0/AIhyYS09Q== MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3658 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Justin.He@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT028.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; IPV:CAL; SCL:-1; CTRY:IE; EFV:NLI; SFV:NSPM; SFS:(10009020)(979002)(4636009)(376002)(39850400004)(346002)(136003)(396003)(13464003)(51914003)(199004)(189003)(6506007)(53546011)(86362001)(2906002)(966005)(229853002)(26826003)(102836004)(478600001)(336012)(6636002)(33656002)(46406003)(8746002)(76130400001)(186003)(99286004)(8936002)(81156014)(81166006)(8676002)(74316002)(66066001)(23726003)(26005)(3846002)(6116002)(63350400001)(70206006)(70586007)(6306002)(9686003)(22756006)(7696005)(7736002)(47776003)(55016002)(5660300002)(52536014)(25786009)(305945005)(6246003)(6862004)(446003)(316002)(36906005)(14454004)(54906003)(11346002)(126002)(97756001)(476003)(50466002)(4326008)(356004)(486006)(76176011)(309714004)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR08MB5037; H:64aa7808-outbound-1.mta.getcheckrecipient.com; FPR:; SPF:TempError; LANG:en; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; A:1; MX:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: 639bb178-45ff-406c-2e81-08d74e520d93 NoDisclaimer: True X-Forefront-PRVS: 0187F3EA14 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SIxSR1KLYdToxlJaFszW36CP3NFessJAzy+Rl232EPegucfvmxFsHHfsWupFwOluYRT+qabyzmI7uUHeHXc6Lk0Moer2LkFCfteCkQRQAjwmCtL4ySYemUtEealm7nMuwWzt9B/4emAPjUxxgbubdX6BdyuYcCpB8BkaARXG7jyF5nrymZ5RR9M8zKiHvACmAiuQYDFz7qeXJ3VTxFbYev8q0kdLkaeRwCxBe879tr7BC1k5tA/NQuPuHEmAMKZQK02Gmqf3YyBZGofXXN1rnl3RFHwjid4vX/Kvuvv518BtXFMa7aFjoNaiU9m0+2/QrRDdWjWzjg5u5Jrx+6AAicTWyxvGYKNj75xx/Gzu7/snLxmRwqrL4ogzoUjBhbcZBY3/hg55LS4sAdRkqdG3ZtaMtIY5qBHqaWarmkEsE1KNwJB+lK5LC/kNI9NezUqly8GR5p3lpPvNP33ZOmezOw== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2019 13:51:10.6834 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e8369078-240a-400f-2511-08d74e5212e3 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5037 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191011_065117_912027_30556C77 X-CRM114-Status: GOOD ( 11.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Kaly Xin \(Arm Technology China\)" , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "hejianet@gmail.com" , nd , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Catanlin Thanks for the detailed explanation. Will send out v12 soon after testing -- Cheers, Justin (Jia He) > -----Original Message----- > From: Catalin Marinas > Sent: Friday, October 11, 2019 6:39 PM > To: Justin He (Arm Technology China) > Cc: Will Deacon ; Mark Rutland > ; James Morse ; Marc > Zyngier ; Matthew Wilcox ; Kirill A. > Shutemov ; linux-arm- > kernel@lists.infradead.org; linux-kernel@vger.kernel.org; linux- > mm@kvack.org; Suzuki Poulose ; Borislav > Petkov ; H. Peter Anvin ; x86@kernel.org; > Thomas Gleixner ; Andrew Morton foundation.org>; hejianet@gmail.com; Kaly Xin (Arm Technology China) > ; nd > Subject: Re: [PATCH v11 1/4] arm64: cpufeature: introduce helper > cpu_has_hw_af() > > On Fri, Oct 11, 2019 at 01:16:36AM +0000, Justin He (Arm Technology China) > wrote: > > From: Catalin Marinas > > > On Wed, Oct 09, 2019 at 04:42:43PM +0800, Jia He wrote: > > > > + u64 mmfr1 = read_cpuid(ID_AA64MMFR1_EL1); > > > > + > > > > + return !!cpuid_feature_extract_unsigned_field(mmfr1, > > > > + > > > ID_AA64MMFR1_HADBS_SHIFT); > > > > > > No need for !!, the return type is a bool already. > > > > But cpuid_feature_extract_unsigned_field has the return type "unsigned > int" [1] > > > > [1] > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch > /arm64/include/asm/cpufeature.h#n444 > > And the C language gives you the automatic conversion from unsigned int > to bool without the need for !!. The reason we use !! in some places is > for converting long to int (not bool) and losing the top 32-bit. See > commit 84fe6826c28f ("arm64: mm: Add double logical invert to pte > accessors") for an explanation. > > -- > Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel