All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joakim Zhang <qiangqing.zhang@nxp.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>, Michael Walle <michael@walle.cc>
Cc: "kernel@pengutronix.de" <kernel@pengutronix.de>,
	"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>
Subject: RE: [PATCH 20/20] can: flexcan: add lx2160ar1 support
Date: Wed, 23 Sep 2020 08:31:10 +0000	[thread overview]
Message-ID: <DB8PR04MB67955FEC9B6A44A1A2C04DE8E6380@DB8PR04MB6795.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <8e2e2994-a3c8-cf06-012a-fcb0ac18a888@pengutronix.de>


> -----Original Message-----
> From: Marc Kleine-Budde <mkl@pengutronix.de>
> Sent: 2020年9月23日 16:11
> To: Michael Walle <michael@walle.cc>
> Cc: Joakim Zhang <qiangqing.zhang@nxp.com>; kernel@pengutronix.de;
> linux-can@vger.kernel.org
> Subject: Re: [PATCH 20/20] can: flexcan: add lx2160ar1 support
> 
> On 9/23/20 10:02 AM, Michael Walle wrote:
> [...]
> 
> >> The compatible of your can device matches the one listed in the
> >> driver. So there's no need for the "fsl,ls1028ar1-flexcan"
> >> in the driver.
> >>
> >> If it turns out, that the "fsl,ls1028ar1-flexcan" needs different
> >> handling than the "fsl,lx2160ar1-flexcan", we would add it with
> >> different quirks to the driver.
> >
> > That was what I was asking. Ie. if Joakim already knows any and if it
> > makes sense to have some added right now.
> 
> ACK, I don't know of any difference.
> 
> > And maybe you/he want to see the LS1028A added to the table in the
> > header of the file. I've had a look at the vendor manual but couldn't
> > even find the IP version. Seems to me that only Joakim is able to fill
> > out that row ;)
> 
> Right, the more IP cores in the table are appreciated. I don't think the IP core
> version used in the SoCs is available to the public. Joakim, feel free to add a line
> for the ls1028ar1 and the imx8mp.

Hi Marc, Michael,

I check locally, for LS1028A, it also uses the "fsl,lx2160ar1-flexcan" compatible string, so I think LS1028A should reuse IP core from LX2160A.

I am more familiar to i.MX, I will add a compatible string for i.MX8MP, since it configures ECC, extra patches are needed.
After this patch set is merged into mainline, I will send out related patches to community.

Best Regards,
Joakim Zhang
> regards,
> Marc
> 
> --
> Pengutronix e.K.                 | Marc Kleine-Budde           |
> Embedded Linux                   | https://www.pengutronix.de  |
> Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
> Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |


  reply	other threads:[~2020-09-23  8:31 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-22 14:44 [RFC]: flexcan FD support - can-next 2020-09-22 Marc Kleine-Budde
2020-09-22 14:44 ` [PATCH 01/20] can: flexcan: sort include files alphabetically Marc Kleine-Budde
2020-09-22 14:44 ` [PATCH 02/20] can: flexcan: flexcan_exit_stop_mode(): remove stray empty line Marc Kleine-Budde
2020-09-22 14:44 ` [PATCH 03/20] can: flexcan: more register names Marc Kleine-Budde
2020-09-22 14:44 ` [PATCH 04/20] can: flexcan: struct flexcan_regs: document registers not affected by soft reset Marc Kleine-Budde
2020-09-22 14:44 ` [PATCH 05/20] can: flexcan: quirks: get rid of long lines Marc Kleine-Budde
2020-09-22 14:44 ` [PATCH 06/20] can: flexcan: Ack wakeup interrupt separately Marc Kleine-Budde
2020-09-22 14:44 ` [PATCH 07/20] can: flexcan: flexcan_probe(): make regulator xceiver optional Marc Kleine-Budde
2020-09-22 14:44 ` [PATCH 08/20] can: flexcan: Add check for transceiver maximum bitrate limitation Marc Kleine-Budde
2020-09-22 14:44 ` [PATCH 09/20] can: flexcan: add correctable errors correction when HW supports ECC Marc Kleine-Budde
2020-09-22 14:44 ` [PATCH 10/20] can: flexcan: flexcan_chip_stop(): add error handling and propagate error value Marc Kleine-Budde
2020-09-22 14:44 ` [PATCH 11/20] can: flexcan: disable clocks during stop mode Marc Kleine-Budde
2020-09-22 14:44 ` [PATCH 12/20] can: flexcan: add LPSR mode support Marc Kleine-Budde
2020-09-22 14:44 ` [PATCH 13/20] can: flexcan: flexcan_set_bittiming(): move setup of CAN-2.0 bitiming into separate function Marc Kleine-Budde
2020-09-22 14:44 ` [PATCH 14/20] can: flexcan: use struct canfd_frame for CAN classic frame Marc Kleine-Budde
2020-09-22 14:44 ` [PATCH 15/20] can: flexcan: add CAN-FD mode support Marc Kleine-Budde
2020-09-22 14:44 ` [PATCH 16/20] can: flexcan: add ISO CAN FD feature support Marc Kleine-Budde
2020-09-22 14:44 ` [PATCH 17/20] can: flexcan: add CAN FD BRS support Marc Kleine-Budde
2020-09-22 14:44 ` [PATCH 18/20] can: flexcan: add Transceiver Delay Compensation support Marc Kleine-Budde
2020-09-22 14:44 ` [PATCH 19/20] can: flexcan: add imx8qm support Marc Kleine-Budde
2020-09-22 14:44 ` [PATCH 20/20] can: flexcan: add lx2160ar1 support Marc Kleine-Budde
2020-09-23  7:45   ` Michael Walle
2020-09-23  7:54     ` Marc Kleine-Budde
2020-09-23  8:02       ` Michael Walle
2020-09-23  8:10         ` Marc Kleine-Budde
2020-09-23  8:31           ` Joakim Zhang [this message]
2020-09-23  8:58             ` Marc Kleine-Budde
2020-09-23  9:38               ` Michael Walle
2020-09-23  9:50               ` Joakim Zhang
2020-09-23  8:53 pull-request: can-next 2020-09-23 Marc Kleine-Budde
2020-09-23  8:54 ` [PATCH 20/20] can: flexcan: add lx2160ar1 support Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB8PR04MB67955FEC9B6A44A1A2C04DE8E6380@DB8PR04MB6795.eurprd04.prod.outlook.com \
    --to=qiangqing.zhang@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-can@vger.kernel.org \
    --cc=michael@walle.cc \
    --cc=mkl@pengutronix.de \
    --subject='RE: [PATCH 20/20] can: flexcan: add lx2160ar1 support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.