All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andrej Valek" <andrej.valek@siemens.com>
To: Khem Raj <raj.khem@gmail.com>,
	"openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core][PATCH] vim: add option to disable NLS support
Date: Mon, 23 Aug 2021 17:12:10 +0000	[thread overview]
Message-ID: <DB8PR10MB3977E6C2E704FF73707CA62492C49@DB8PR10MB3977.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <ce3005b3-6213-9528-2c82-c4f612f3b549@gmail.com>

Hello Khem,

I looked exactly into configure.ac which arguments are expecting for those options. So I think, it has to be mentioned explicitly. 

Regards,
Andrej

> On 8/23/21 3:12 AM, Andrej Valek wrote:
>> - Some distributions with UTF-8 locale have problem when National Language
>>   Support is enabled. Add there an option to disable it.
>> - refresh options based on configure.ac
>> 
>> Signed-off-by: Andrej Valek <andrej.valek@siemens.com>
>> ---
>>   meta/recipes-support/vim/vim.inc | 8 +++++---
>>   1 file changed, 5 insertions(+), 3 deletions(-)
>> 
>> diff --git a/meta/recipes-support/vim/vim.inc 
>> b/meta/recipes-support/vim/vim.inc
>> index 17d1c24a7c..7cc47884f2 100644
>> --- a/meta/recipes-support/vim/vim.inc
>> +++ b/meta/recipes-support/vim/vim.inc
>> @@ -54,19 +54,21 @@ do_compile() {
>>       autotools_do_compile
>>   }
>>   
>> -#Available PACKAGECONFIG options are gtkgui, acl, x11, tiny
>> +#Available PACKAGECONFIG options are gtkgui, acl, x11, tiny, selinux, 
>> +elfutils, nls
>>   PACKAGECONFIG ??= ""
>>   PACKAGECONFIG += " \
>>       ${@bb.utils.filter('DISTRO_FEATURES', 'acl selinux', d)} \
>>       ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11 gtkgui', '', 
>> d)} \
>> +    nls \
>>   "
>>   
>>   PACKAGECONFIG[gtkgui] = "--enable-gui=gtk3,--enable-gui=no,gtk+3"
>> -PACKAGECONFIG[acl] = "--enable-acl,--disable-acl,acl,"
>> +PACKAGECONFIG[acl] = "enable_acl="yes",--disable-acl,acl,"
>
>is 'yes' needed to be explicit ? I thought --enable-XYZ meant it implicitly
>
>>   PACKAGECONFIG[x11] = "--with-x,--without-x,xt,"
>>   PACKAGECONFIG[tiny] = "--with-features=tiny,--with-features=big,,"
>> -PACKAGECONFIG[selinux] = "--enable-selinux,--disable-selinux,libselinux,"
>> +PACKAGECONFIG[selinux] = "enable_selinux="yes",--disable-selinux,libselinux,"
>>   PACKAGECONFIG[elfutils] = "--enable-elf-check,,elfutils,"
>> +PACKAGECONFIG[nls] = "enable_nls="yes",--disable-nls,,"
>>   
>>   EXTRA_OECONF = " \
>>       --disable-gpm \

  reply	other threads:[~2021-08-23 17:12 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-23 10:12 [OE-core][PATCH] vim: add option to disable NLS support Andrej Valek
2021-08-23 11:23 ` [OE-core][PATCH v2] busybox: 1.33.1 -> 1.34.0 Andrej Valek
2021-08-23 16:12 ` [OE-core][PATCH] vim: add option to disable NLS support Khem Raj
2021-08-23 17:12   ` Andrej Valek [this message]
2021-08-23 22:14     ` Andre McCurdy
2021-08-24  6:56       ` Andrej Valek
2021-08-26  9:58         ` Andrej Valek
2021-08-26 10:59           ` Richard Purdie
2021-08-26 11:24             ` Andrej Valek
2021-08-26 12:00               ` Richard Purdie
2021-08-26 13:15 ` [OE-core][PATCH v2] " Andrej Valek
2021-09-01 19:04   ` Andrej Valek
2021-09-01 22:35     ` Steve Sakoman
2021-09-08  7:49       ` Andrej Valek
2021-09-08 14:26         ` Steve Sakoman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB8PR10MB3977E6C2E704FF73707CA62492C49@DB8PR10MB3977.EURPRD10.PROD.OUTLOOK.COM \
    --to=andrej.valek@siemens.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=raj.khem@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.