RE: [PATCH v3 10/15] net/dpaa2: support recycle loopback port

[Nipun Gupta <nipun.gupta@nxp.com>]

Hi David,
	Sure, we will send a patch asap.

Regards,
Nipun

> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: 01 February 2022 14:58
> To: Nipun Gupta <nipun.gupta@nxp.com>; Jun Yang <jun.yang@nxp.com>
> Cc: dev <dev@dpdk.org>; Thomas Monjalon <thomas@monjalon.net>; Yigit,
> Ferruh <ferruh.yigit@intel.com>; Hemant Agrawal <hemant.agrawal@nxp.com>;
> Stephen Hemminger <stephen@networkplumber.org>
> Subject: Re: [PATCH v3 10/15] net/dpaa2: support recycle loopback port
> 
> Hello guys,
> 
> On Mon, Jan 3, 2022 at 11:02 AM <nipun.gupta@nxp.com> wrote:
> > diff --git a/drivers/net/dpaa2/dpaa2_recycle.c
> b/drivers/net/dpaa2/dpaa2_recycle.c
> > new file mode 100644
> > index 0000000000..e274d24ead
> > --- /dev/null
> > +++ b/drivers/net/dpaa2/dpaa2_recycle.c
> > @@ -0,0 +1,780 @@
> > +/* * SPDX-License-Identifier: BSD-3-Clause
> > + *
> > + *   Copyright 2019-2021 NXP
> > + *
> > + */
> > +
> > +#include <time.h>
> > +#include <net/if.h>
> > +
> > +#include <rte_mbuf.h>
> > +#include <ethdev_driver.h>
> > +#include <rte_malloc.h>
> > +#include <rte_memcpy.h>
> > +#include <rte_string_fns.h>
> > +#include <rte_cycles.h>
> > +#include <rte_kvargs.h>
> > +#include <rte_dev.h>
> > +#include <rte_fslmc.h>
> > +#include <rte_flow_driver.h>
> > +
> > +#include "dpaa2_pmd_logs.h"
> > +#include <fslmc_vfio.h>
> > +#include <dpaa2_hw_pvt.h>
> > +#include <dpaa2_hw_mempool.h>
> > +#include <dpaa2_hw_dpio.h>
> > +#include <mc/fsl_dpmng.h>
> > +#include "dpaa2_ethdev.h"
> > +#include "dpaa2_sparser.h"
> > +#include <fsl_qbman_debug.h>
> > +
> > +#include <rte_io.h>
> > +#include <unistd.h>
> > +#include <sys/mman.h>
> > +
> > +#define PAGE_SIZE                      (sysconf(_SC_PAGESIZE))
> > +#define PAGE_MASK                      (~(PAGE_SIZE - 1))
> 
> This patch breaks compilation in Alpine Linux in next-net and main repositories.
> Can you provide a fix?
> Thanks.
> 
> 
> This was initially reported by UNH:
> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmails.dpd
> k.org%2Farchives%2Ftest-report%2F2022-
> January%2F250111.html&amp;data=04%7C01%7Cnipun.gupta%40nxp.com%7C
> a8213a91a0014639650d08d9e5652600%7C686ea1d3bc2b4c6fa92cd99c5c3016
> 35%7C0%7C0%7C637793044866714334%7CUnknown%7CTWFpbGZsb3d8eyJWI
> joiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C300
> 0&amp;sdata=b%2BT8BinlyFWaYSLaaOLtNTN9TA0epJAxN0Si9jbom7I%3D&amp
> ;reserved=0
> 
> FAILED:
> drivers/a715181@@tmp_rte_net_dpaa2@sta/net_dpaa2_dpaa2_recycle.c.o
> ccache cc -Idrivers/a715181@@tmp_rte_net_dpaa2@sta -Idrivers
> -I../drivers -Idrivers/net/dpaa2 -I../drivers/net/dpaa2
> -I../drivers/net/dpaa2/base -I../drivers/net/dpaa2/mc -Ilib/ethdev
> -I../lib/ethdev -I. -I../ -Iconfig -I../config -Ilib/eal/include
> -I../lib/eal/include -Ilib/eal/linux/include
> -I../lib/eal/linux/include -Ilib/eal/x86/include
> -I../lib/eal/x86/include -Ilib/eal/common -I../lib/eal/common
> -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs
> -Ilib/telemetry/../metrics -I../lib/telemetry/../metrics
> -Ilib/telemetry -I../lib/telemetry -Ilib/net -I../lib/net -Ilib/mbuf
> -I../lib/mbuf -Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/ring
> -Ilib/meter -I../lib/meter -Idrivers/bus/pci -I../drivers/bus/pci
> -I../drivers/bus/pci/linux -Ilib/pci -I../lib/pci -Idrivers/bus/vdev
> -I../drivers/bus/vdev -Idrivers/mempool/dpaa2
> -I../drivers/mempool/dpaa2 -Idrivers/bus/fslmc -I../drivers/bus/fslmc
> -I../drivers/bus/fslmc/mc -I../drivers/bus/fslmc/qbman/include
> -I../drivers/bus/fslmc/portal -Idrivers/common/dpaax
> -I../drivers/common/dpaax -I../drivers/common/dpaax/caamflib
> -Ilib/eventdev -I../lib/eventdev -Ilib/hash -I../lib/hash -Ilib/rcu
> -I../lib/rcu -Ilib/timer -I../lib/timer -Ilib/cryptodev
> -I../lib/cryptodev -fdiagnostics-color=always -pipe
> -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Werror -O3 -include
> rte_config.h -Wextra -Wcast-qual -Wdeprecated -Wformat
> -Wformat-nonliteral -Wformat-security -Wmissing-declarations
> -Wmissing-prototypes -Wnested-externs -Wold-style-definition
> -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef
> -Wwrite-strings -Wno-address-of-packed-member -Wno-packed-not-aligned
> -Wno-missing-field-initializers -Wno-zero-length-bounds -D_GNU_SOURCE
> -fPIC -march=native -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API
> -Wno-format-truncation -DRTE_LOG_DEFAULT_LOGTYPE=pmd.net.dpaa2  -MD
> -MQ
> 'drivers/a715181@@tmp_rte_net_dpaa2@sta/net_dpaa2_dpaa2_recycle.c.o'
> -MF
> 'drivers/a715181@@tmp_rte_net_dpaa2@sta/net_dpaa2_dpaa2_recycle.c.o.d'
> -o
> 'drivers/a715181@@tmp_rte_net_dpaa2@sta/net_dpaa2_dpaa2_recycle.c.o'
> -c ../drivers/net/dpaa2/dpaa2_recycle.c
> ../drivers/net/dpaa2/dpaa2_recycle.c:35: error: "PAGE_SIZE" redefined [-Werror]
>    35 | #define PAGE_SIZE   (sysconf(_SC_PAGESIZE))
>       |
> In file included from /usr/include/fortify/stdlib.h:29,
>                  from ../lib/eal/include/rte_common.h:20,
>                  from ../lib/mbuf/rte_mbuf.h:36,
>                  from ../drivers/net/dpaa2/dpaa2_recycle.c:10:
> /usr/include/limits.h:97: note: this is the location of the previous definition
>    97 | #define PAGE_SIZE PAGESIZE
>       |
> cc1: all warnings being treated as errors
> 
> 
> 
> --
> David Marchand