From: "Starke, Daniel" <daniel.starke@siemens.com>
To: "m.brock@vanmierlo.com" <m.brock@vanmierlo.com>
Cc: "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"jirislaby@kernel.org" <jirislaby@kernel.org>,
"ilpo.jarvinen@linux.intel.com" <ilpo.jarvinen@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v5 1/1] tty: n_gsm: add keep alive support
Date: Mon, 13 Feb 2023 11:32:47 +0000 [thread overview]
Message-ID: <DB9PR10MB5881C08001D7FA76D6E2C06CE0DD9@DB9PR10MB5881.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <aec7575cd784ae4fe9e9f2c1e08107a9@vanmierlo.com>
> > From: Daniel Starke <daniel.starke@siemens.com>
> > + u32 keep_alive; /* Control channel keep-alive in ms */
> [...]
> > + if (dlci && !dlci->dead)
> > + mod_timer(&gsm->ka_timer, jiffies + gsm->keep_alive * HZ / 100);
>
> keep-alive is in ms? or in 10ms?
Good found. The comment is wrong. It is in 10ms as also written in the
comment for "keep_alive" within gsmmux.h to be in line with t1 and t2.
I will correct this for v6 of the patch.
Best regards,
Daniel Starke
prev parent reply other threads:[~2023-02-13 11:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 9:43 [PATCH v5 1/1] tty: n_gsm: add keep alive support D. Starke
2023-02-13 11:10 ` m.brock
2023-02-13 11:32 ` Starke, Daniel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB9PR10MB5881C08001D7FA76D6E2C06CE0DD9@DB9PR10MB5881.EURPRD10.PROD.OUTLOOK.COM \
--to=daniel.starke@siemens.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=m.brock@vanmierlo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.