From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6821FC54EE9 for ; Tue, 27 Sep 2022 21:04:17 +0000 (UTC) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9C57841133; Tue, 27 Sep 2022 23:04:16 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60056.outbound.protection.outlook.com [40.107.6.56]) by mails.dpdk.org (Postfix) with ESMTP id A8BF540694; Tue, 27 Sep 2022 23:04:14 +0200 (CEST) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=PKXPsm/6L2lnLHd9u0iwPENi3cVk+/+UPj27opkaKkhC1aTa9XuOC0z1a9hpmQg4c/6WaeMvcwXW/cUnmHoNLoF7w4MorLOhABiA8M1JA8Ab/JTLX3q7guect75UJwjPDm6dQFuI2wL8leFbS3zGOra0YZ1tlGTG9I5ffK8DE+CaUKvWLoTWnRVWjTz0CPyOlf3lxEyu0xEaHKfLMn/dDOe3Tss2rGwPY5QV3fe5jdKQUQ1qmmK7ihRdmhE2XITueHIPeSa2kqum7QpQ4Ot9RqIQTT6Ej0aHlWQ6mPcTikrz4rKuZuyVhc0Z3M6yuVGIa+90fpvRoNfB8VRBpybWWQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=itebte+4L5ifGYvT4FeUnVo6gjQHufzLmQcTBMfa6II=; b=EgP6+tAuP655K7VAP/xtwVN8mTjvzLIn+m5dUaOFUoPqAhj2FvQy/7MbABUSO61skfX6qpjMkTfd4DmQQ98Zql6tqF+TxHfI2dEMz2xvgvObsT8h3rwcMLa3f9X+UcEDv7B06X3os4j2eHR+OWowbhv1FMRfEfcOPiWukw/siQ08Wj6bCGxxN/hRfF2ZST5lY++VddDHfLr92zUd9m42VDTSS4XZfnsJNzb3VoWr0wbqXi1nTNdLcJi8l+ZtdKH7z+lH6Gtj5B4Rn7g5RwgoBNnxogWqBd4qKDilY03/KtsWMJopY28CzWnlIwy5VjWFnFZ/DlOyto9+AkfAZSo8Gg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=dpdk.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=itebte+4L5ifGYvT4FeUnVo6gjQHufzLmQcTBMfa6II=; b=5CPqTCbjq3H1SkoyHMM2so0WpW5dxsCyRVffnojmDqjuR8HnKq4/SV/R5U5o0bWdxggMK1iJX6auY5oSCLezgMLxbMH/Ii7gMSQwytWaUYSMxwk7dIcrRc4DaFyzCp8B+qR8V0bxAelzA2zjGXV7LiiRzgc3IJ+PEXMCBr5E5Is= Received: from AM5P194CA0015.EURP194.PROD.OUTLOOK.COM (2603:10a6:203:8f::25) by GV2PR08MB8461.eurprd08.prod.outlook.com (2603:10a6:150:c3::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Tue, 27 Sep 2022 21:04:06 +0000 Received: from VE1EUR03FT035.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:8f:cafe::83) by AM5P194CA0015.outlook.office365.com (2603:10a6:203:8f::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17 via Frontend Transport; Tue, 27 Sep 2022 21:04:06 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT035.mail.protection.outlook.com (10.152.18.110) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14 via Frontend Transport; Tue, 27 Sep 2022 21:04:05 +0000 Received: ("Tessian outbound 7e4a920b87c0:v128"); Tue, 27 Sep 2022 21:04:05 +0000 X-CR-MTA-TID: 64aa7808 Received: from fef4a1892330.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C1D11E4D-DF53-42EF-A688-BB1AB41A1C3D.1; Tue, 27 Sep 2022 21:03:59 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id fef4a1892330.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 27 Sep 2022 21:03:59 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ikQHow0RoOedRoDldjpdrxyhlRjvQNYGpfdKjWj97W1t1T7JEq9+87cO2V0ZrXJtnNr22+ibLbkXWkgGWvF0+lgtVy9QxzcIvlGY72sU6VeXn8LhV4+OZJXUgtpJEyZJ3ynU43kE+W9kaOuZRVOJ5ENzgEKEZ5Ibll5qeAwTetA6qpmijMu2N2+xx6w9PWkLVU9rwXZE+HFyf7tfBywMAgyiU29Rr9TKAxWhGqUQ3u6tqE/Jj1pNxqVU7xGMHcTo4/nP0OeL3NmRqQbQNN3c1KtH6tx+x99uNvVN4pUPM5q7ZnnF/g0gYGhk7exonqBSWbEtn2pIPBFiOo9vnb7l1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=itebte+4L5ifGYvT4FeUnVo6gjQHufzLmQcTBMfa6II=; b=Jwmm6n2ZeZkfawy94xyk5JbfJd3RqPMGmxQkRdDwqjLPJJYwTc02ZwKiuNwmtNqIbYAudp+jDEyzltZCkPlEZQRWDxIATfEkIyyLj04vetX008ZKCKa3U8u7iPMyyV8ZF60aeQ9tt1uNNj6tospD1b9TtHT1DlusXb8Yn/QDKqHx1UKozkhGQwywaogBgv0lhnN5UuaTvxZESsUEyZiruD27g7lgx3mvW+/BGq07PXYKzdq/7w6a/cT+12jo1WcYWIoRznV+uhUKQGoqMvew/eloI5oOj1r0P6KByEpe5Dwj404IYV7yptMhnhbjeD+aIbKTJCgUT5wgpPKV2EpHGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=itebte+4L5ifGYvT4FeUnVo6gjQHufzLmQcTBMfa6II=; b=5CPqTCbjq3H1SkoyHMM2so0WpW5dxsCyRVffnojmDqjuR8HnKq4/SV/R5U5o0bWdxggMK1iJX6auY5oSCLezgMLxbMH/Ii7gMSQwytWaUYSMxwk7dIcrRc4DaFyzCp8B+qR8V0bxAelzA2zjGXV7LiiRzgc3IJ+PEXMCBr5E5Is= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by DBBPR08MB6057.eurprd08.prod.outlook.com (2603:10a6:10:1f5::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26; Tue, 27 Sep 2022 21:03:58 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::c1ee:db1:105:9372]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::c1ee:db1:105:9372%8]) with mapi id 15.20.5654.026; Tue, 27 Sep 2022 21:03:58 +0000 From: Honnappa Nagarahalli To: Slava Ovsiienko , "dev@dpdk.org" , Ruifeng Wang , Matan Azrad , Shahaf Shuler CC: nd , Matan Azrad , "stable@dpdk.org" , nd Subject: RE: [PATCH v2] net/mlx5: use just sufficient barrier for Arm platforms Thread-Topic: [PATCH v2] net/mlx5: use just sufficient barrier for Arm platforms Thread-Index: AQHY0js6kBq/o7BFf0Kgf4d3XmoqKq3zvuag Date: Tue, 27 Sep 2022 21:03:58 +0000 Message-ID: References: <20210606164948.35997-1-honnappa.nagarahalli@arm.com> <20220830200038.1694160-1-honnappa.nagarahalli@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 6E0EA0CD6C273B499753C8B66A7959EE.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: DBAPR08MB5814:EE_|DBBPR08MB6057:EE_|VE1EUR03FT035:EE_|GV2PR08MB8461:EE_ X-MS-Office365-Filtering-Correlation-Id: 64c22f48-c23f-426d-c2dd-08daa0cbd04c x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: BG6MMJRoiyUHIZ9KmsThFYL27/hmVJMJlLgkFlC4l1OT7kI3S5R8seFDxJNNtaKPGBSjf0WE5Xcp8y5HjcDZ9U8u/zoV9OwpuIWCPTzM2xJn26j452OfcPCHPBFaOyuHU1fkhbdL2ccLPi5Geo5vMtsX523ZxYt51BEjAkoq/TUZ9xOzbqE3fxTNT3o90Lm4BLB3IePFUYvaBIiuTBrPcK64cAYgTcTfb4d7wTKEDMzT2MkrVYbll41oWo4PXN0f9FFYv8SFRyNbzVH2bnLqFpaNs0yHfceQcOm//FbWw0HVa7YuOBlCm8p2VqFCThjFOjUuA0AjRwarvQZDMw+sfYrOTY3t1QpgrUrfNez3pa/GULu6oPG87sPEF0Jjpea+U/42dwWVcQRoF7OPK8s4YUAs32udzUJwroYzso+GB0sctkxHkvJ7Fj62e0qqbBKl3r7KscilBrTm/XH40H3QcSHN1jg0nHYGRTAV+AAqSKHyXJky0QmxzUiibs70xW+aROkUwmnFc+P2NdW/KA6Th75c1nNZySTYY4wD7vVc+ldYZtzMaiGOInmL4flSjipRJoKadeDOY8N9o9ZKFuGskGzfRlSeIWapdvI41UqhXrDZcKmh6yCTSfgdmx+ofAIaLQih/itNQ62MorMrvENkYWD/eGCWXqpkWAjlfnNR9AWtNvzALKJAztWPumSpIpAmCZPTa/gE6vrZTWZCmBfEKTfZYeVlIQHoE9Lns93OuCgPIxEljCnOYNmrOr1XjI8sn97t+Wsfby4LscBdWY5KKrsgwX6YoL24L1jCLOHVxbY= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(366004)(376002)(39860400002)(136003)(346002)(396003)(451199015)(2906002)(122000001)(38100700002)(6506007)(33656002)(41300700001)(8936002)(53546011)(55016003)(66476007)(52536014)(7696005)(76116006)(66556008)(66946007)(66446008)(64756008)(4326008)(8676002)(86362001)(966005)(110136005)(38070700005)(54906003)(316002)(478600001)(5660300002)(26005)(9686003)(83380400001)(71200400001)(186003); DIR:OUT; SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6057 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT035.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 15fe9fe5-65dd-4c8f-f616-08daa0cbcbe2 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cHLCKzkdto2pUG3as7Zs0diZ3YW951TmUx/y24WMHuXyQ7owaLNI3sBJdsCJFUzMToqzC6HLQLCLswOspQtFEQ961//YZ23k+kKTvCDCHqvfkDJ+mODv1NI7wndmfzEFnYwJUcIsXv238sCiqaz3b+BN9AD5KdV7dPBdAgk8MvrigToT0iQFgreXu6bQtqdyou3DUqZXo5QzAML9aFwGzG3FAxwIE1W9NxWcJQbGb1rajgXPEjmThjfrjBheXBVO9qcngcWawraNOglN7iAd67MHHrPSlXE7G3VQ4pcjeyLpv8yWDzZ1TJEGzx8SWz5N/KAnuhsdaUsPNxCmrcItqzfAYqzpVKjHs6Va541i9H38slwa41YYcTdWrYgSSIBGwKqMXyVu5WGaPTg98lgpDwQSnIXbmjDEm1RTF0f2dZwLCI9Wp14r8wZiwA9PAy15BqwhO6E6Tjypdf+Ss5Ik1VdIyyRFapqq/j87jb0XOsIVZIwucGUY7pJE7HQXCQKN2NUAs6nU3ha57ppu9qv+U25IdvWlzkUbJjnuwBy+0MvWmvjmpB5S1xsELAdfYs5WQp/I3ICNCFAhJE1pv0OXHNldK5k01y7SMMOlw+1WXr5jpuE19xG35/+kGLHP7zkgrlFoHM0naK9AzRTPESW7LYymADgYXn152YY+4pm457xyQIo89n6GrZi+UdZG6drfI/B6GsZ0bBh9oOR1d+H5o75AH+YanxISs2okqeR6Mrz24em9kktI4aOQ97K/7dZK0oN+QrkWUAmYVT3KdZhBKM85xn0bNvyfKFBVzqG6fkI= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230022)(4636009)(396003)(346002)(376002)(136003)(39860400002)(451199015)(36840700001)(46966006)(40470700004)(33656002)(55016003)(82310400005)(40480700001)(26005)(47076005)(41300700001)(336012)(7696005)(83380400001)(186003)(9686003)(8936002)(52536014)(356005)(2906002)(86362001)(40460700003)(5660300002)(110136005)(54906003)(316002)(70206006)(8676002)(36860700001)(966005)(6506007)(70586007)(478600001)(82740400003)(450100002)(4326008)(81166007)(53546011); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 21:04:05.8280 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 64c22f48-c23f-426d-c2dd-08daa0cbd04c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT035.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8461 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org >=20 > Hi, Honnappa Hi Slava, thanks for the feedback. >=20 > We discussed the barrier here: > http://patches.dpdk.org/project/dpdk/patch/20210606164948.35997-1- > honnappa.nagarahalli@arm.com/ Yes, I have changed the patch according to the discussion. i.e. barrier is = needed, but different (inner sharable domain) barrier is required. >=20 > (BTW, it is good practice to keep the reference to previous patch version= s > below Commit Message of the next ones). >=20 > This barrier is not about compiler ordering, it is about external HW agen= t > memory action completions. > So, I'm not sure the rte_atomic_thread_fence() is safe for x86 - patch im= pacts > x86 as well. The earlier barrier 'rte_io_rmb()', resolves to a compiler barrier on x86 [= 1]. The rte_atomic_thread_fence(__ATOMIC_ACQUIRE) on x86 also acts as a com= piler barrier. So, there is no change for x86. [1] https://github.com/DPDK/dpdk/blob/main/lib/eal/x86/include/rte_atomic.h= #L80 >=20 > With best regards, > Slava >=20 > > -----Original Message----- > > From: Honnappa Nagarahalli > > Sent: Tuesday, August 30, 2022 23:01 > > To: dev@dpdk.org; honnappa.nagarahalli@arm.com; > ruifeng.wang@arm.com; > > Matan Azrad ; Shahaf Shuler ; > > Slava Ovsiienko > > Cc: nd@arm.com; Matan Azrad ; stable@dpdk.org > > Subject: [PATCH v2] net/mlx5: use just sufficient barrier for Arm > > platforms > > > > cqe->op_own indicates if the CQE is owned by the NIC. The rest of > > the fields in CQE should be read only after op_own is read. On Arm > > platforms using "dmb ishld" is sufficient to enforce this. > > > > Fixes: 88c0733535d6 ("net/mlx5: extend Rx completion with error > > handling") > > Cc: matan@mellanox.com > > Cc: stable@dpdk.org > > > > Signed-off-by: Honnappa Nagarahalli > > Reviewed-by: Ruifeng Wang > > --- > > drivers/common/mlx5/mlx5_common.h | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/common/mlx5/mlx5_common.h > > b/drivers/common/mlx5/mlx5_common.h > > index 5028a05b49..ac2e85b15f 100644 > > --- a/drivers/common/mlx5/mlx5_common.h > > +++ b/drivers/common/mlx5/mlx5_common.h > > @@ -195,7 +195,11 @@ check_cqe(volatile struct mlx5_cqe *cqe, const > > uint16_t cqes_n, > > > > if (unlikely((op_owner !=3D (!!(idx))) || (op_code =3D=3D > > MLX5_CQE_INVALID))) > > return MLX5_CQE_STATUS_HW_OWN; > > - rte_io_rmb(); > > + /* Prevent speculative reading of other fields in CQE until > > + * CQE is valid. > > + */ > > + rte_atomic_thread_fence(__ATOMIC_ACQUIRE); > > + > > if (unlikely(op_code =3D=3D MLX5_CQE_RESP_ERR || > > op_code =3D=3D MLX5_CQE_REQ_ERR)) > > return MLX5_CQE_STATUS_ERR; > > -- > > 2.17.1