From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id B57E5C433EF for ; Wed, 11 May 2022 16:51:32 +0000 (UTC) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EC377406B4; Wed, 11 May 2022 18:51:31 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60065.outbound.protection.outlook.com [40.107.6.65]) by mails.dpdk.org (Postfix) with ESMTP id 0494040042 for ; Wed, 11 May 2022 18:51:29 +0200 (CEST) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=E2NG9SALNMp55Y4MuihCXwuA4tcwh5z3LnvGiGzMjqKFVanKD5faKpS7DP9tGGQpqlFi1gbZihPHCe4Yh6fFQoD9qTKspDfDzQy+GF6DUzf3qMo6Gz8TMzIf03uyGfDD+nA3eC+VLBMV+kumVZY4Sw7GVX1DvGStQ6lY6gWTv19UTnJFqNHOzhpxfLTtykRb+ha1OCD1wDbG+y31d4FM2V+ZqUMuv9IX7rCfqzzvDQr8L0gvgBZnTCei92/G6DSdz2ufYGCY4W1hQ5iosKnKB/gxN++ev7MKW7wJudNdl7LOQlg8aKO677IhU8W4PoJYBjd/yVU16XJGRwJfZc/w2A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PwV4xKFhCwiBFJcupzN9hZr3bny5y7gB+kTD8e2DijI=; b=F380UjOER9TuQdFTF5IxmnB9UR9NmIiSpw47TCCorsilhhVylchODY8nEN/vpXokuBWQdOp/7sdALC3MgUo9tlKjhqlOhMRVI5qDgWQ9so1PTL/o+jrXbdsSdqVgphxM6RaZX3MoHNdto3NPJDdp8/VMVVHR/Gb89S1VEwqg/Lzt9YGJnLiZFT0PClGgFiGlMbMAonvpOWzoRP2W38VQNAfajYF8qxEbLpqNjAoYhyU68qWCJsIUSBc3JMuFd/mJUOpb1FIb2Ah3NQ9O1RzMLMrwn1wwu7xDabi1F6Xcfw3p3eCwH2JmDFzWdGLF3fVaVwnMSJvNNTkHZSjiEXF8/w== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=dpdk.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PwV4xKFhCwiBFJcupzN9hZr3bny5y7gB+kTD8e2DijI=; b=9rFuuh714AuPzjNfhurSyMN1W+fue+FuE/SeOgp2SFmfFh6aeDY/fMUnOl4vo8v+eHGgQloo+b6E0yIBSGKmC2YuZ/2Zy+bvYvuE8i2iVpcgc/cy/gdVrZ2/P3I5b5mV4muaiLE64/lrFvWS5BD17hBA7WADpWQ/Q/hIwvzbYv8= Received: from AM6P191CA0029.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8b::42) by DB8PR08MB4140.eurprd08.prod.outlook.com (2603:10a6:10:a8::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.22; Wed, 11 May 2022 16:51:19 +0000 Received: from VE1EUR03FT009.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8b:cafe::d0) by AM6P191CA0029.outlook.office365.com (2603:10a6:209:8b::42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Wed, 11 May 2022 16:51:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT009.mail.protection.outlook.com (10.152.18.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Wed, 11 May 2022 16:51:13 +0000 Received: ("Tessian outbound 3314dea8c23c:v119"); Wed, 11 May 2022 16:51:13 +0000 X-CR-MTA-TID: 64aa7808 Received: from d2eeeea9466a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E0BC2FE7-C450-43B8-B808-05AF2DB5CCA7.1; Wed, 11 May 2022 16:51:06 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d2eeeea9466a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 11 May 2022 16:51:06 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n522LCf/j6Ndgp1tqn6Qv+SX6qNZv/3R8feGDV4FmPUnVbKfLNQgSj259J1ZlxC/A0HZk+A21ZDsaRiHc8RAVuyi9RgdrTP/mSRTxpOCLdmIuqhzS7PJqTNehw4miq0A0hj7SZ/oPAkCpNID+9/yLp2FhEI9mIYWQP+RS0OkNLynL/MZnsWM4qDwEatPwxwdJQWTDryUEWCD3vsOtupChwQX252Vwiu6ugTZ5PQrTACkVjLqjwa3A3arSk+JcD6CTdE53Y+2i3UJTZHcNxpBKpTGjkfzEymBV5rcK2g2FTdg2P8NNFeBxt/AqSTB8RbH/IoXhmkxgpOtu6PLHMMmkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PwV4xKFhCwiBFJcupzN9hZr3bny5y7gB+kTD8e2DijI=; b=DtMQu0gfJVIiQQ5meqDPrYbVJtTUGV72+V+Dsbx6Td6I25uqWzAcHv7U6HqLlB0uKBCpGW4GWRdMqTUVgkdwRGk4qkoGtYXTLGue7UL8HtDAEUjFlwqpgY/g6Y3VJnY6dpf6zje6GyvqU0hMhv1Aq1C7eocqdLNA9FTf3OOyJ1wH0U24dYHHaBxdTH/8j6pRVqrca7mwIhCYd+oI5aQJhGXLZtDSCUJdrnetroN4u8JLhkR+QNIrnjvdDJqmDEdoBY74JPMKULQRY5pQ8CmbJO8P6O4gUQ2DqqtQOf758cIzlFMPbpgL0k44JZgoPXSsTwHbqSU+UpVJ6XGob8BDQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PwV4xKFhCwiBFJcupzN9hZr3bny5y7gB+kTD8e2DijI=; b=9rFuuh714AuPzjNfhurSyMN1W+fue+FuE/SeOgp2SFmfFh6aeDY/fMUnOl4vo8v+eHGgQloo+b6E0yIBSGKmC2YuZ/2Zy+bvYvuE8i2iVpcgc/cy/gdVrZ2/P3I5b5mV4muaiLE64/lrFvWS5BD17hBA7WADpWQ/Q/hIwvzbYv8= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by AM9PR08MB6113.eurprd08.prod.outlook.com (2603:10a6:20b:2d6::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.20; Wed, 11 May 2022 16:51:04 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::44cf:1f8d:e477:1f99]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::44cf:1f8d:e477:1f99%8]) with mapi id 15.20.5227.023; Wed, 11 May 2022 16:51:03 +0000 From: Honnappa Nagarahalli To: Stanislaw Kardach CC: "dev@dpdk.org" , Frank Zhao , Sam Grove , "mw@semihalf.com" , "upstream@semihalf.com" , nd , nd Subject: RE: [PATCH v2 1/1] test/ring: remove excessive inlining Thread-Topic: [PATCH v2 1/1] test/ring: remove excessive inlining Thread-Index: AQHYZUjlIZQCKYqp/UGjG2Dw2/A2r60Z47Ow Date: Wed, 11 May 2022 16:51:03 +0000 Message-ID: References: <20220510115758.457794-1-kda@semihalf.com> <20220511150725.744021-1-kda@semihalf.com> In-Reply-To: <20220511150725.744021-1-kda@semihalf.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 32D7A5D2DA4E67409985F51E9A1D0A87.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: a77ab48d-9557-4982-a242-08da336e7570 x-ms-traffictypediagnostic: AM9PR08MB6113:EE_|VE1EUR03FT009:EE_|DB8PR08MB4140:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: SLadPh7/kCf4AKm9xg+910wgS8WIsEn9Tk8jJ924Vws2PGCCxeejFyKEv27Dz8QKzNTMePObFLi0NSRN1GJDD5mjaUSU9Rp3N1AsnJ5F76ln+CZ7x44B37bXUjSAhXkMjUr+NIqDtt6rKFt+FuMGtnAHUIY44U1RfNEqPOnJk+yV2Bud213YyFPq8rHP3YhaEjwIF3KbNm36w43L0H0PfQDPFZ2XZRSybXnzYL7ReNi5WleGtxkS39qVgTv6Cr9Z13C83t68WiqYbvh4pbzTCz/e4ZY+Bwz4khSKekqF2TFYGjtZSu3X0ObuXyp/0z7AmC9HK9jAtRm9c5dzcevr8zoe94ZbDAc9FaA94qCk7M0FxadSUkt8PfDFrTmBq/o8oMS1dnefQ/hezmBRF7e146SKOVUIn1y3djgHt5ygVE+SYoUxsIyEg46didt24y4YvvXJpYB1/p3zvlEsnDKG3/oC87YwOnMkVS73qGZrbDBtkTAGQtKH6KwYkYWjxDxkjSdetmidQKG/m6OxV1LQRHW0tUq/yz5u0OgnzcQRVRR0mYDWARcTbvRbuIvU49lTw8r0bd1grS6DKC+2dcX+7z+8VF6sMabbNJYEvmmpxfxtIhL0DRbdyRp0iANHuAV6HSMTvzupWPfucQH/WZi9l5tSu3Upt05nhmKBLWHxRlI0Dy58sS2sdkGqUa9mAsDCPwd0sayDtzVZsiJsYMS+16cSTvw1KW8Gj4IfdwnaA6GuZYoEvnbRSwktMzkICIACbgO5UPSn3v9GBjQ/DJYmBe2qKrsvz4iRY9qY/yO1Nsc= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(9686003)(86362001)(186003)(5660300002)(26005)(8936002)(122000001)(8676002)(64756008)(66446008)(66556008)(38100700002)(38070700005)(4326008)(66476007)(66946007)(76116006)(2906002)(966005)(6506007)(71200400001)(6916009)(33656002)(7696005)(54906003)(508600001)(316002)(55016003)(52536014); DIR:OUT; SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6113 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT009.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 4ae46905-a20a-43a0-fe46-08da336e6f6f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: agE0CF6xQBgqsXlw58JuUaIaMiOhLXwkbH7PtTR7HPrRvNyR1x610c4EvQOnzt1mDK4YjnRD4c5a9R7Kym4vveN9tHpK6UvoCyCp9MIlMO8IWkdHq3VOp2u9jAk3kN/ycPll9TOrnGe3wVIxbkynrvwQXWceMrZTeonjOpzzGyv37nbTecUaKvwSIBwx17fIPQspAqDJL5QkRYdQV540x7zu0hZhsxHxfulDphiT2FCAf76Jjmd6Uq5rIlfwZSKGsQx3RmYHAG+WWMUdqd9RA5DwAIaqn5mOUsbIqv0+c1F0/tCEJORS6D1VMFcZ0e9Io1mB7FPeHblHJdAzpR/xOn5tUYSt9XjVWUuwxvXp6vrHTGW7GJPYAX9RATqHEHgfynTfLxTpQTXKqa4If+HtmhYYioMsCP7dL3PZzasTqsIZGuN1Ap9uXUziLCgCPNMaSTg1WlJRQujBTOnJKMXgP1rLbKpEXzgMcvF8h5kxQ9lc7DUxyhpZYTCeEY+GusKgx6QbwbGYmQybN57JouzZqBRdki5LHcAtMrKREJQMOT9IN8wQ7k+a6et+PDkH8lXl3mwx1JJgC7Ma78pZFLLJetloSeDwzN5q6c55dtpDVmDo3muYNSn5DjDut4hoUUKe+cAhQYXmnDA9XiT+X9BumEFCaf6vh3pAoFegHHZkYhNmnU+XpCVfDlsRtdGzkR8V06SHZ30lZxV/VKz6yh1wEvacZ7giwoOmSYVcbut1xzwzAwwUebC1grMuW4ThMZ6TXTbeNAFM7QZpOH/bDqX6rg== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(186003)(356005)(82310400005)(26005)(9686003)(55016003)(70206006)(8676002)(70586007)(4326008)(6862004)(8936002)(52536014)(5660300002)(33656002)(316002)(2906002)(54906003)(47076005)(508600001)(966005)(6506007)(7696005)(86362001)(36860700001)(81166007)(40460700003)(336012); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2022 16:51:13.4987 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a77ab48d-9557-4982-a242-08da336e7570 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT009.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB4140 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org >=20 > Forcing inlining in test_ring_enqueue and test_ring_dequeue can cause the > compiled code to grow extensively when compiled with no optimization > (-O0 or -Og). This is default in the meson's debug configuration. This ca= n collide > with compiler bugs and cause issues during linking of unit tests where th= e > api_type or esize are non-const variables causing inlining cascade. In pe= rf tests > this is not the case in perf-tests as esize and api_type are const values= . >=20 > One such case was discovered when porting DPDK to RISC-V. GCC 11.2 (and n= o > fix still in 12.1) is generating a short relative jump instruction (J ) for > goto and for loops. When loop body grows extensively in ring test, the ta= rget > offset goes beyond supported offfset of +/- 1MB from PC. This is an obvio= us > bug in the GCC as RISC-V has a two-instruction construct to jump to any > absolute address (AUIPC+JALR). >=20 > However there is no reason to force inlining as the test code works perfe= ctly > fine without it. >=20 > GCC has a bug report for a similar case (with conditionals): > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D93062 >=20 > Fixes: a9fe152363 test/ring: add custom element size functional tests >=20 > Signed-off-by: Stanislaw Kardach Reviewed-by: Honnappa Nagarahalli