From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753101AbbJMPYc (ORCPT ); Tue, 13 Oct 2015 11:24:32 -0400 Received: from mail-pa0-f67.google.com ([209.85.220.67]:33464 "EHLO mail-pa0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751565AbbJMPYa (ORCPT ); Tue, 13 Oct 2015 11:24:30 -0400 Subject: Re: [PATCH v3 3/7] arm64: ftrace: fix a stack tracer's output under function graph tracer Mime-Version: 1.0 (Apple Message framework v1283) Content-Type: text/plain; charset=us-ascii From: Jungseok Lee In-Reply-To: <1444298504-10392-4-git-send-email-takahiro.akashi@linaro.org> Date: Wed, 14 Oct 2015 00:24:24 +0900 Cc: catalin.marinas@arm.com, will.deacon@arm.com, rostedt@goodmis.org, olof@lixom.net, broonie@kernel.org, david.griego@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: 7bit Message-Id: References: <1444298504-10392-1-git-send-email-takahiro.akashi@linaro.org> <1444298504-10392-4-git-send-email-takahiro.akashi@linaro.org> To: AKASHI Takahiro X-Mailer: Apple Mail (2.1283) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Oct 8, 2015, at 7:01 PM, AKASHI Takahiro wrote: Hi Akashi, > Function graph tracer modifies a return address (LR) in a stack frame > to hook a function return. This will result in many useless entries > (return_to_handler) showing up in a stack tracer's output. > > This patch replaces such entries with originals values preserved in > current->ret_stack[]. > > Signed-off-by: AKASHI Takahiro The following diff should be folded into this patch, not [7/7] one, to address build breakage. ----8<---- diff --git a/arch/arm64/kernel/stacktrace.c b/arch/arm64/kernel/stacktrace.c index 407991b..7126d4d 100644 --- a/arch/arm64/kernel/stacktrace.c +++ b/arch/arm64/kernel/stacktrace.c @@ -17,6 +17,7 @@ */ #include #include +#include #include #include ----8<---- Best Regards Jungseok Lee From mboxrd@z Thu Jan 1 00:00:00 1970 From: jungseoklee85@gmail.com (Jungseok Lee) Date: Wed, 14 Oct 2015 00:24:24 +0900 Subject: [PATCH v3 3/7] arm64: ftrace: fix a stack tracer's output under function graph tracer In-Reply-To: <1444298504-10392-4-git-send-email-takahiro.akashi@linaro.org> References: <1444298504-10392-1-git-send-email-takahiro.akashi@linaro.org> <1444298504-10392-4-git-send-email-takahiro.akashi@linaro.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Oct 8, 2015, at 7:01 PM, AKASHI Takahiro wrote: Hi Akashi, > Function graph tracer modifies a return address (LR) in a stack frame > to hook a function return. This will result in many useless entries > (return_to_handler) showing up in a stack tracer's output. > > This patch replaces such entries with originals values preserved in > current->ret_stack[]. > > Signed-off-by: AKASHI Takahiro The following diff should be folded into this patch, not [7/7] one, to address build breakage. ----8<---- diff --git a/arch/arm64/kernel/stacktrace.c b/arch/arm64/kernel/stacktrace.c index 407991b..7126d4d 100644 --- a/arch/arm64/kernel/stacktrace.c +++ b/arch/arm64/kernel/stacktrace.c @@ -17,6 +17,7 @@ */ #include #include +#include #include #include ----8<---- Best Regards Jungseok Lee