From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754282AbaIOSOc (ORCPT ); Mon, 15 Sep 2014 14:14:32 -0400 Received: from p3plex2out01.prod.phx3.secureserver.net ([184.168.131.12]:34999 "EHLO p3plex2out01.prod.phx3.secureserver.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752764AbaIOSOb convert rfc822-to-8bit (ORCPT ); Mon, 15 Sep 2014 14:14:31 -0400 From: Hartley Sweeten To: Ian Abbott , "driverdev-devel@linuxdriverproject.org" CC: Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH 03/11] staging: comedi: add comedi_inc_scan_progress() Thread-Topic: [PATCH 03/11] staging: comedi: add comedi_inc_scan_progress() Thread-Index: AQHP0OMRY3oKIFObM0mkhxM1b7uQ3pwCf29A Date: Mon, 15 Sep 2014 18:14:29 +0000 Message-ID: References: <1410785167-28506-1-git-send-email-abbotti@mev.co.uk> <1410785167-28506-4-git-send-email-abbotti@mev.co.uk> In-Reply-To: <1410785167-28506-4-git-send-email-abbotti@mev.co.uk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [184.183.19.121] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, September 15, 2014 5:46 AM, Ian Abbott wrote: > The "comedi_fc" module contains a few functions useful to Comedi > drivers. Their functionality is being migrated to the core "comedi" > module and renamed to start with the prefix `comedi_`. As part of this > migration, move `cfc_inc_scan_progress()` into the core comedi module > and rename it to `comedi_inc_scan_progress()`. Change the external > declaration of `cfc_inc_scan_progress()` into an inline function that > calls `comedi_inc_scan_progress()`. > > Signed-off-by: Ian Abbott > --- > drivers/staging/comedi/comedidev.h | 2 ++ > drivers/staging/comedi/drivers.c | 24 ++++++++++++++++++++++++ > drivers/staging/comedi/drivers/comedi_fc.c | 13 ------------- > drivers/staging/comedi/drivers/comedi_fc.h | 6 +++++- > 4 files changed, 31 insertions(+), 14 deletions(-) Again, I think this function should be in comedi_buf. Regards, Hartley From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Hartley Sweeten Subject: RE: [PATCH 03/11] staging: comedi: add comedi_inc_scan_progress() Date: Mon, 15 Sep 2014 18:14:29 +0000 Message-ID: References: <1410785167-28506-1-git-send-email-abbotti@mev.co.uk> <1410785167-28506-4-git-send-email-abbotti@mev.co.uk> In-Reply-To: <1410785167-28506-4-git-send-email-abbotti@mev.co.uk> Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 List-ID: To: Ian Abbott , "driverdev-devel@linuxdriverproject.org" Cc: Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" On Monday, September 15, 2014 5:46 AM, Ian Abbott wrote: > The "comedi_fc" module contains a few functions useful to Comedi > drivers. Their functionality is being migrated to the core "comedi" > module and renamed to start with the prefix `comedi_`. As part of this > migration, move `cfc_inc_scan_progress()` into the core comedi module > and rename it to `comedi_inc_scan_progress()`. Change the external > declaration of `cfc_inc_scan_progress()` into an inline function that > calls `comedi_inc_scan_progress()`. > > Signed-off-by: Ian Abbott > --- > drivers/staging/comedi/comedidev.h | 2 ++ > drivers/staging/comedi/drivers.c | 24 ++++++++++++++++++++++++ > drivers/staging/comedi/drivers/comedi_fc.c | 13 ------------- > drivers/staging/comedi/drivers/comedi_fc.h | 6 +++++- > 4 files changed, 31 insertions(+), 14 deletions(-) Again, I think this function should be in comedi_buf. Regards, Hartley