From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762855AbbA3RDX (ORCPT ); Fri, 30 Jan 2015 12:03:23 -0500 Received: from p3plex2out01.prod.phx3.secureserver.net ([184.168.131.12]:59129 "EHLO p3plex2out01.prod.phx3.secureserver.netIMP" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755093AbbA3RDV convert rfc822-to-8bit (ORCPT ); Fri, 30 Jan 2015 12:03:21 -0500 From: Hartley Sweeten To: Ian Abbott , "driverdev-devel@linuxdriverproject.org" CC: Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH 00/10] staging: comedi: introduce comedi_pcmcia.h header Thread-Topic: [PATCH 00/10] staging: comedi: introduce comedi_pcmcia.h header Thread-Index: AQHQPHRWzTCc7rjmHkKUpOvflWYhnZzY47IA Date: Fri, 30 Jan 2015 17:03:19 +0000 Message-ID: References: <1422611846-15921-1-git-send-email-abbotti@mev.co.uk> In-Reply-To: <1422611846-15921-1-git-send-email-abbotti@mev.co.uk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [184.183.19.121] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, January 30, 2015 2:57 AM, Ian Abbott wrote: > "comedidev.h" includes PCMCIA-specific stuff that gets included by all > comedi drivers including non-PCMCIA ones. Separate it out into its own > header "comedi_pcmcia.h". Make the new header include > , and "comedidev.h" so that comedi PCMCIA > drivers do not need to include them explicitly. > > 01) staging: comedi: add comedi_pcmcia.h > 02) staging: comedi: comedi_pcmcia.c: include new "comedi_pcmcia.h" > header > 03) staging: comedi: cb_das16_cs: include new "comedi_pcmcia.h" header > 04) staging: comedi: das08_cs: include new "comedi_pcmcia.h" header > 05) staging: comedi: ni_daq_700: include new "comedi_pcmcia.h" header > 06) staging: comedi: ni_daq_dio24: include new "comedi_pcmcia.h" header > 07) staging: comedi: ni_labpc_cs: include new "comedi_pcmcia.h" header > 08) staging: comedi: ni_mio_cs: include new "comedi_pcmcia.h" header > 09) staging: comedi: quatech_daqp_cs: include new "comedi_pcmcia.h" > header > 10) staging: comedi: comedi_pcmcia.h: move PCMCIA stuff out of > comedidev.h > > drivers/staging/comedi/comedi_pcmcia.c | 5 +-- > drivers/staging/comedi/comedi_pcmcia.h | 55 ++++++++++++++++++++++++ > drivers/staging/comedi/comedidev.h | 33 -------------- > drivers/staging/comedi/drivers/cb_das16_cs.c | 5 +-- > drivers/staging/comedi/drivers/das08_cs.c | 5 +-- > drivers/staging/comedi/drivers/ni_daq_700.c | 5 +-- > drivers/staging/comedi/drivers/ni_daq_dio24.c | 6 +-- > drivers/staging/comedi/drivers/ni_labpc_cs.c | 6 +-- > drivers/staging/comedi/drivers/ni_mio_cs.c | 6 +-- > drivers/staging/comedi/drivers/quatech_daqp_cs.c | 7 +-- > 10 files changed, 63 insertions(+), 70 deletions(-) Reviewed-by: H Hartley Sweeten From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Hartley Sweeten Subject: RE: [PATCH 00/10] staging: comedi: introduce comedi_pcmcia.h header Date: Fri, 30 Jan 2015 17:03:19 +0000 Message-ID: References: <1422611846-15921-1-git-send-email-abbotti@mev.co.uk> In-Reply-To: <1422611846-15921-1-git-send-email-abbotti@mev.co.uk> Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 List-ID: To: Ian Abbott , "driverdev-devel@linuxdriverproject.org" Cc: Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" On Friday, January 30, 2015 2:57 AM, Ian Abbott wrote: > "comedidev.h" includes PCMCIA-specific stuff that gets included by all > comedi drivers including non-PCMCIA ones. Separate it out into its own > header "comedi_pcmcia.h". Make the new header include > , and "comedidev.h" so that comedi PCMCIA > drivers do not need to include them explicitly. > > 01) staging: comedi: add comedi_pcmcia.h > 02) staging: comedi: comedi_pcmcia.c: include new "comedi_pcmcia.h" > header > 03) staging: comedi: cb_das16_cs: include new "comedi_pcmcia.h" header > 04) staging: comedi: das08_cs: include new "comedi_pcmcia.h" header > 05) staging: comedi: ni_daq_700: include new "comedi_pcmcia.h" header > 06) staging: comedi: ni_daq_dio24: include new "comedi_pcmcia.h" header > 07) staging: comedi: ni_labpc_cs: include new "comedi_pcmcia.h" header > 08) staging: comedi: ni_mio_cs: include new "comedi_pcmcia.h" header > 09) staging: comedi: quatech_daqp_cs: include new "comedi_pcmcia.h" > header > 10) staging: comedi: comedi_pcmcia.h: move PCMCIA stuff out of > comedidev.h > > drivers/staging/comedi/comedi_pcmcia.c | 5 +-- > drivers/staging/comedi/comedi_pcmcia.h | 55 ++++++++++++++++++= ++++++ > drivers/staging/comedi/comedidev.h | 33 -------------- > drivers/staging/comedi/drivers/cb_das16_cs.c | 5 +-- > drivers/staging/comedi/drivers/das08_cs.c | 5 +-- > drivers/staging/comedi/drivers/ni_daq_700.c | 5 +-- > drivers/staging/comedi/drivers/ni_daq_dio24.c | 6 +-- > drivers/staging/comedi/drivers/ni_labpc_cs.c | 6 +-- > drivers/staging/comedi/drivers/ni_mio_cs.c | 6 +-- > drivers/staging/comedi/drivers/quatech_daqp_cs.c | 7 +-- > 10 files changed, 63 insertions(+), 70 deletions(-) Reviewed-by: H Hartley Sweeten